brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

why Vertical tab don't hide in fullscreen mode. #31082

Open krabhi1 opened 1 year ago

krabhi1 commented 1 year ago

Description

i'm using vertical tab features of brave and i notice that while in fullscreen mode vertical tab don't hide

Steps to Reproduce

  1. just enable vertical tab features of brave
  2. open youtube or spotify
  3. start watching in fullscreen mode

Actual result:

image

Expected result:

Reproduces how often:

Brave version (brave://version info)

1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 1 year ago

Hi @kr-abhi55 What operating system are using?

krabhi1 commented 1 year ago

Operating System: Debian GNU/Linux 11 KDE Plasma Version: 5.20.5 KDE Frameworks Version: 5.78.0 Qt Version: 5.15.2 Kernel Version: 5.10.0-23-amd64 OS Type: 64-bit Processors: 4 × Intel® Core™ i3-4005U CPU @ 1.70GHz Memory: 7.7 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 4400

twinturboV8 commented 1 year ago

Same issue for me on MacOS Ventura but happen only when the app was in full screen ie when I use the green fullscreen button and then proceed to fullscreen the video. It doesn't happen when the browser is in windowed mode.

krabhi1 commented 1 year ago

Same issue for me on MacOS Ventura but happen only when the app was in full screen ie when I use the green fullscreen button and then proceed to fullscreen the video. It doesn't happen when the browser is in windowed mode.

it may be a bug

Brave-Matt commented 1 year ago

Other users on Community seeing this as well: https://community.brave.com/t/vertical-tabs-area-remains-when-using-youtube-full-screen/492272/4

This user left a recording of the behavior as well as instructions on a "workaround" (while it does literally work around the issue it is a hassle as well and not viable for long term): https://youtu.be/WiJiu9m3AAE

To remove the issue, put the video in full screen, create a new window, go to the new window (while the video is fullscreen), collapse the tabs in the new window, go back to your fullscreen window where the vertical tab spaces is magically gone. To revert the workaround, just hover the mouse over the tabs and it’ll revert to having the ugly space there.

HK47196 commented 1 year ago

Same issue on Arch Linux, [Version 1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit)] I see other issues about this from earlier this year claiming it was fixed, but it seems the issue persists.

hho commented 1 year ago

(K)ubuntu 22.04.2 LTS Brave Version 1.57.1 Chromium: 115.0.5790.56 (Official Build) beta (64-bit) With the Beta, it seems to be a little better.

For me, fullscreen with vertical tabs:

Brave-Matt commented 1 year ago

More reports from Community: https://community.brave.com/t/vertical-tabs-should-not-be-visible-in-fullscreen-mode/492019/7

srirambv commented 1 year ago

FWIW I don't think its the vertical tabs, but its the sidebar which is in always show setting that is causing the issue. @rebron this is an issue on all platforms.

I have vertical tabs and sidebar enabled but only see the sidebar show up when on full screen image

phocean commented 1 year ago

@srirambv I don't think so, at least on Mac OS. There is no correlation with the sidebar setting : it shows an empty bar in full screen either in "never", "always" or "scroll over" modes.

And it has the issue only when using vertical tabs.

Moreover, I am not sure it's really the vertical tabs that is really now hiding.

Despite I have multiple tabs open, it always shows an empty bar:

CleanShot 2023-07-26 at 10 31 35@2x

1chappie commented 1 year ago

Same issues here on MacOS, Brave build: Version 1.56.14 Chromium: 115.0.5790.114 (Official Build) (arm64)

bilaharipg commented 1 year ago

@1chappie Update your browser. This issue was resolved in the latest update, and you are not using the latest version

JavierLuna commented 1 year ago

Confirmed, it solved the issue for me!

phildufresne commented 1 year ago

Is there an option to go back to the old behaviour? I like leaving my browser fullscreen on its own virtual desktop, and now I can't do that because my tabs disappear.

gmann42 commented 1 year ago

Yeah I also want the vertical side-bar visible in full-screen mode. I have a zillion tabs open, most of them coding related, switching across them is made easier by the side-bar being visible.

Now I a bit frustrated, to switch tabs I have to either cycle through them with alt+tab, or exit full-screen and come back.

I now search tabs can be used, but the shortcut Cmd + Shift + A, conflicts with in-browser slack.

OS: Mac OS Monterery 12.2.1 Brave version: v1.58.124

balhissay commented 1 year ago

I would also love to be able to keep vertical tabs while on fullscreen in macOS. A specific option for this will be more than welcome. Thanks!!

raduc commented 1 year ago

+1, I always use Brave in full screen mode, especially on smaller screens. This update totally breaks my experience. At lease please add an option to return to the previous behavior.

raduc commented 1 year ago

Can the behavior be similar to horizontal tabs? They do show up in full screen mode, but then they hide when for example a video is playing full-screen. That would be the best behavior.

hho commented 1 year ago

@raduc Horizontal tabs don't show up in fullscreen for me either (Linux) – and I think that's correct: Full screen should be just that, a screen full of the webpage shown.

Do I understand you correctly, that you just want a maximized window minus the address bar?

raduc commented 1 year ago

Horizontal tabs do show up in MacOS full screen, see also https://github.com/brave/brave-browser/issues/33020 Some people prefer running the browser in full screen mode especially with smaller screen laptops (e.g. Macbook 12 inch).

raduc commented 1 year ago

On MacOS there is a difference between full-screen mode (tabs available) and presentation mode (tabs hidden): https://apple.stackexchange.com/a/113736

jvervlied commented 1 year ago

I am adding to the requests of being ale to have vertical tabs available in fullscreen. I use brave in fullscreen exclusively and not having tabs visible makes it unusable.

phildufresne commented 1 year ago

I would argue that this bug-fix has been incorrectly implemented and needs to be reworked with MacOS full-screen / presentation-mode concepts considered.

phildufresne commented 1 year ago

Update: it was reverted - https://github.com/brave/brave-browser/issues/33106

yozachar commented 1 year ago
$ brave --version
Brave Browser 117.1.58.137

To reproduce:

  1. Use Brave 117.1.58.137.
  2. Go to: https://piped.kavin.rocks/watch?v=uiTrB-zA7bc or any YT video link and play the video.
  3. Hit F and the video will go to full-screen without the vertical tabs. Hit F again to quit full-screen.
  4. Hit F11 (or Fn + F11) and the web-page will go to full-screen with the vertical tabs visible. Press same key combination again to exit full-screen.

https://github.com/brave/brave-browser/assets/38415384/3f97c809-a3aa-4f9f-860c-4346ee6f799a

The behaviors is a bit odd, as if F11 is treating vertical tabs as part of the web-page.

raduc commented 8 months ago

This has regressed and it's happening again in 1.63.174.