search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.75k stars 2.32k forks source link

Show/hide bookmarks shortcut behavior #31154

Open ghost opened 1 year ago

ghost commented 1 year ago

Toggling "Show bookmarks" always resets to "Never" with shortcut key (ctrl+shift+b).

Steps to Reproduce

  1. "Show bookmarks" option set to "Only on the new tab page"
  2. Toggle bookmarks bar on/off (ctrl+shift+b twice)
  3. "Show bookmarks" option now set to "Never"

Actual result:

Show bookmarks toggles between Always and Never

Expected result:

Show bookmarks should toggle between Always and User selected option (in this case "Only on the new tab page")

Reproduces how often:

Every time

Brave version (brave://version info)

I got the expected result from earlier versions (> ~2 months ago)

tbdx commented 1 year ago

Bump...

I came here to finally raise the same issue as a regression, as this behaviour used to work as expected. As it does in most other browsers.

Toggling bookmarks bar should not reset the ideal setting from settings.