brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.63k stars 2.29k forks source link

QoL feature: on/off toggle for experimental dark mode #31363

Open faandg opened 1 year ago

faandg commented 1 year ago

Hi,

I use Auto Dark Mode for Web Contents (praise the lord for this flag ๐Ÿ™) to prevent migraines due to excessive eye-strain from staring at cloud apps with white backgrounds.

Certain functionality however is not displayed properly in this mode due to the owners never putting any effort into dark mode compatibility. In the past couple of years I've made plenty mistakes such as but not limited to:

The least we can do as end-users is to provide feedback and report it to their owners and if we are lucky they act upon it.

I acknowledge you cannot fix other people's websites or take over their responsibilities.

But I do propose a slight quality of life change because there will always be incompatible sites: When Auto Dark Mode for Web Contents is set, add a toggle for it somewhere near the extensions/wallet/VPN button area. This would allow us to quickly switch and review our dark mode-created work in the standard light mode other users will see and then switch back.

Right now I have to go to brave://flags/, disable the flag, relaunch (sometimes it even refuses to launch!), review my changes, back to brave://flags/, enable the flag, relaunch. Open to alternative suggestions.

ghost commented 1 year ago

+1, a toggle would be perfect.

If only I had a toggle to turn #enable-force-dark on and off without restarting the whole browser - life would be perfect ๐Ÿ–๏ธ. #enable-force-dark too often breaks many things, and I would like a toggle to quickly switch the flag off, look at the part of the page which was broken with the flag on, then switch the flag back on.

There's the well-known Dark Reader extension https://github.com/darkreader/darkreader, but in order for it to function, it requires access "to read and change all your data on websites you visit", which is a security risk. The probability that this extension will go rogue is minimal, since the developers receive a lot of donations and will highly likely not do anything malicious. But if a browser already has a built-in functionality to apply a dark mode to webpages without having to rely on a third-party extension and increase your attack surface - I would go all out not to use an extension with such a risky and sensitive permission, thereby reducing the number of entities I have to trust.

LorenDB commented 6 months ago

Opera has had this feature for some time now. Their implementation is as follows:

I'd love to see this implemented in Brave as it is a lot smoother than using Dark Reader.