Closed bbondy closed 1 year ago
I like having it as a checkbox on the clear browsing data panel.
Also, Added a separate button in Leo Settings to clear chat history so you users don't have to clear all Leo data along with it.
Comment 0 is updated with the latest.
I like having it as a checkbox on the clear browsing data panel.
That also seems to me like the most natural way to do this.
So maybe we could have two separate things:
brave://settings/clearBrowserData
(both Advanced and On exit tabs).brave://settings/leo-assistant
.Updated comment 0 again with the latest understanding of the work. You should be good to go @vadimstruts
PASSED
usingBrave | 1.60.89 Chromium: 118.0.5993.70 (Official Build) beta (x86_64)
-- | --
Revision | 801f851e0c0664d110cccd46708cd084a83c3729
OS | macOS Version 11.7.10 (Build 20G1427)
Brave Leo
disabled) - PASSED
Brave Leo
enabledbrave://settings/clearBrowserData
, Advanced
- PASSED
brave://settings/clearBrowserData
, On exit
- PASSED
brave://settings/leo-assistant
- PASSED
Verified on Samsung Galaxy S21
using version:
Brave 1.60.109 Chromium: 119.0.6045.59 (Official Build) (64-bit)
Revision fc399c7c433510eb03c2b35281bf8935804b99de
OS Android 13; Build/TP1A.220624.014; 33; REL
Note: This is still in progress on Android and not ready for testing.
Encountered: https://github.com/brave/brave-browser/issues/34018
Add a checkbox to clear "Leo assistant history" in brave://settings/clearBrowserData (Both on Advanced and On Exit tabs):
It should call some empty handlers for now since there is no chat history to clear
The clear in brave://settings/leo-assistant should have only 1 link and it should have a dialog to confirm when you clear. This one will in the future clear history. But it will also continue to clear the opt-in status and reset any other future settings related to our browser AI.
Here is how the confirmation dialog should be:
Text should read:
Reset Brave Leo Resetting the Leo assistant will require you to opt-in to use Brave Leo in the future and will also clear your chat history. Clearing your chat history will delete all your previous conversations with Brave Leo. This action cannot be undone.