Hidden bookmarks appearing when opening a new tab

[lukaslevert]

Description

On all channels and recent versions of Brave on desktop, I notice a brief moment each time I open a new tab where my bookmarks are visible, even though they are disabled.

Steps to Reproduce

1. Set "show bookmarks" to never in settings
2. Click top bar + to open new tab page
3. Briefly observe bookmarks shown as the new tab opens

Actual result:

https://github.com/brave/brave-browser/assets/79997955/4acb557c-d7e3-45b3-82ac-7399e8719804

Expected result:

Tab should open smoothly, with no view.

Reproduces how often:

Seems to happen every single time a new tab is opened.

Brave version (brave://version info)

Version 1.56.9 Chromium: 115.0.5790.98 (Official Build) (arm64)

Version/Channel Information:

Issue occurs on all channels.

[rebron]

@kjozwiak macOS only or can you repro on Windows?

[tabcat]

I am seeing this on linux. but only noticed after setting the new tab to a custom url. did not notice when I was using the default new tab dashboard. would be nice if the custom url new tab could show bookmarks while other sites do not.

[simonhong]

@tabcat Which version are you using and how to set custom url to new tab? We fixed same issue with https://github.com/brave/brave-browser/issues/25834 and it's available from 1.64.x

[tabcat]

Which version are you using

Version 1.64.109 Chromium: 123.0.6312.58 (Official Build) (64-bit)

how to set custom url to new tab?

1) Settings > Get Started > New Tab Page > New Tab Page Shows = Homepage 2) Settings > Appearance > Toolbar > Show Home Button = Enabled > Enter a custom web address

My issue may be different than #25834 because I don't see the bookmarks flash if I set the visibility to never.

[simonhong]

@tabcat Thanks for the info. I can see white page flash before loading custom home page url.

[tabcat]

I do not see a white flash, just the bookmarks. Is it possible that is the site loading for you? This is the custom url I am using: https://newtab.eth.limo