brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.98k stars 2.21k forks source link

Overlay Scrollbar flag was removed in Chromium 115 #31811

Open steviator opened 11 months ago

steviator commented 11 months ago

Description (edited by @bsclifton)

The scrollbars which used to auto hide are now showing on the right hand side of my monitor. I do not like this and don't want to upgrade Brave beyond version 1.52.130 (chromium 114.0.5735.198). I assume this has to do with the removal of the overlay scrollbars option.

Steps to Reproduce

  1. Have overlay scrollbars option experiment enabled
  2. Upgrade Brave past 1.52.130

Actual result:

Scrollbars are now showing again

Expected result:

Overlay scrollbars flag should still work (or there should be a feature to hide the scrollbars)

Reproduces how often:

Once. I downgraded and turned off updates immediately. Presumably I will need to stop using Brave shortly when it gets insistent about downgrading to a later version.

Brave version (brave://version info)

version 1.52.130 (chromium 114.0.5735.198) on Arch Linux

Version/Channel Information:

Happens in release version, so is presumably deliberately replicated in all other channels

Other Additional Information:

Miscellaneous Information:

HMartusewiczVox commented 11 months ago

I had the same reaction in ~friday. The flag is gone in normal Chrome too.

I would like the Overlay Scrollbars flag returned, or even better, made into a regular setting

ghost commented 11 months ago

Moderator note: post edited by @bsclifton

Brave is base on Chromium and a major version like Chromium 115 bring changes to the flags and everything, so what do you expect? well, you don't depend on flags, flags are experimental, flags have a trial period, flags will appear and disappear at Chromium team commands, it can either made default or get removed, simple as that.

The Overlay Scrollbar flag was actually extended until 114 on September 2022, that means that you should be thankful you still have it today https://chromium-review.googlesource.com/c/chromium/src/+/3894241.

The flag was removed but not the feature, so you can start Brave with --enable-features=OverlayScrollbar or you know, the simplest thing that has been a Chromium thing for years, you enable that flag that Temporarily unexpire flags that expired as of blabla which in this case is obviously 114 as explained above, how the overlayscrollbars was extended from 107 to 114. = brave://flags/#temporary-unexpire-flags-m114

Obviously 114 flags will disappear when Brave upgrades to Chromium 116, but then maybe the Chromium team decided to keep it or remove it completely from source code, I don't know, I don't care to research it further to really know what is the plan.

bsclifton commented 11 months ago

Thanks for the passionate views folks - @Emi-TheDhamphirInLoveUnderTheFrozenStar I think you captured things well (although if you're able to edit your post to be more friendly, that would be appreciated).

@steviator @HMartusewiczVox you can keep extending the feature by appending --enable-features=OverlayScrollbar to your shortcut for Brave. Eventually, this will likely stop working too.

I've retitled the issue to capture the actual issue at hand here - how something looks is subjective. The objective thing being asked for is an experimental flag that was removed unfortunately.

I don't see us having the bandwidth to put down other items we're working on to grab this. But it's good to know that folks want the ability to have the scrollbars auto-hidden. We can keep this open to collect more feedback.

cc: @rebron