brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

more spaced out SIWE message #31988

Open HEagle18 opened 1 year ago

HEagle18 commented 1 year ago

Description

On android, We need to space out the text on the screen to be more readable and like iOS.

Came from this issue https://github.com/brave/brave-talk/issues/831

Steps to Reproduce

Actual result:

Android SIWE message

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

HEagle18 commented 1 year ago

This maybe android specific. @Pavneet-Sing to follow up with @darkdh about implementation.

darkdh commented 1 year ago

seems like the newlines got eaten so we are not displaying the real raw message right now. Any messages with newline won't be displayed correctly.

bbondy commented 1 year ago

hope it goes without saying but we shouldn’t modify what is being asked to be signed

Pavneet-Sing commented 1 year ago

On Android, HTML formatting is being applied Html.escapeHtml and newlines are being ignored. Android can use HTML specific tags by replacing newlines or can remove HTML formatting completely like desktop.