brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.85k stars 2.34k forks source link

Upgrade from Chromium 116.0.5845.62 to Chromium 116.0.5845.82. #32168

Closed mkarolin closed 1 year ago

mkarolin commented 1 year ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/116.0.5845.62..116.0.5845.82?pretty=fuller&n=10000

QA tests:

Additional checks:

kjozwiak commented 1 year ago

The above requires 1.57.44 or higher for 1.57.x verification 👍

kjozwiak commented 1 year ago

Quick overview of the work remaining re: affected areas due to C116 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/30747#issue-1736657318.

Platforms that still need to check/verify the affected areas due to C116 changes as per https://github.com/brave/brave-browser/issues/30747#issue-1736657318.

stephendonner commented 1 year ago

Verification PASSED using

Brave | 1.57.44 Chromium: 116.0.5845.82 (Official Build) (x86_64)
-- | --
Revision | 109e984111c5152478bf49d266f4e19861c0b63e
OS | macOS Version 11.7.9 (Build 20G1426)

Previous tests (which I copied and supplanted here) can be found here: https://github.com/brave/brave-browser/issues/30747#issuecomment-1671764256

Substantial testing using the below version, prior:

Brave | 1.57.42 Chromium: 116.0.5845.51 (Official Build) (x86_64)
-- | --
Revision | e25036a089c476c56bf71774a898a1fee014e00d
OS | macOS Version 11.7.9 (Build 20G1426)

Changing Shields settings works correctly - PASSED

### New Profile - `PASSED`
* confirmed defaults in `brave://settings/shields` * confirmed ability to change settings * confirmed settings are retained after browser restarts * confirmed items are blocked or allowed, accordingly ### Trackers & ads blocking - `PASSED`
**Default (Standard)** `brave://settings/shields` | `sfgate.com`, `defaults` --------------------------|-------------------------- Screen Shot 2023-08-09 at 11 48 46 AM | Screen Shot 2023-08-09 at 11 47 21 AM _`Disabled`_ `brave://settings/shields` | `sfgate.com`, `Allow all trackers & ads` --------------------------|---------------------------------------- Screen Shot 2023-08-09 at 12 10 25 PM | Screen Shot 2023-08-09 at 11 48 21 AM
### Block scripts - `PASSED`
**Default (Off/Disabled)** `brave://settings/shields` |`blizzard.com`, `defaults` ---------|--------- Screen Shot 2023-08-09 at 12 03 25 PM | Screen Shot 2023-08-09 at 12 03 21 PM _`Block scripts`, `ON`_ `brave://settings/shields` | `blizzard.com`, `Scripted blocked` --------------------------|----------------------------------- Screen Shot 2023-08-09 at 12 00 36 PM | Screen Shot 2023-08-09 at 12 00 44 PM
### Block fingerprinting - `PASSED`
**Default (Standard)** example | example ---------|--------- Screen Shot 2023-08-09 at 12 28 47 PM | Screen Shot 2023-08-09 at 12 29 17 PM _`Strict, may break sites`_ example | example ---------|--------- Screen Shot 2023-08-09 at 12 27 58 PM | Screen Shot 2023-08-09 at 12 32 20 PM _`Disabled`_ example | example ---------|--------- Screen Shot 2023-08-09 at 12 33 36 PM | Screen Shot 2023-08-09 at 12 34 08 PM
### Block cookies - `PASSED`
**Default (`Only cross-site`)** `brave://settings/shields` | `twitter.com` (logged in via `Google`) | `brave://settings/content/all` --------------------------|---------------------------------------|------------------------------ Screen Shot 2023-08-09 at 1 04 01 PM | Screen Shot 2023-08-09 at 1 26 48 PM | Screen Shot 2023-08-09 at 1 27 01 PM Block cookies, _`All`_ `brave://settings/shields` | `twitter.com` | `brave://settings/content/all` --------------------------|--------------|----------------------------- Screen Shot 2023-08-09 at 1 07 23 PM | Screen Shot 2023-08-09 at 1 20 05 PM | Screen Shot 2023-08-09 at 1 19 14 PM Block cookies, _`Disabled`_ `brave://settings/shields` | `twitter.com` | `brave://settings/content/all` --------------------------|--------------|------------------------------ Screen Shot 2023-08-09 at 1 08 37 PM | Screen Shot 2023-08-09 at 1 24 12 PM | Screen Shot 2023-08-09 at 1 10 14 PM
### Upgraded profile - `PASSED`
Install 1.56.x CR 115 and upgrade it to 1.57.x CR 116 - PASSED **Case 1.1:** Default shield settings upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 4. Upgrade the profile to 1.57.x CR 116 5. Confirmed profile is upgraded to 1.57.x CR 116 6. Confirmed default shield settings are retained **Case 1.2:** Update the default shield settings and then upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 3. Edit the site-specific shield settings 5. Upgrade the profile to 1.57.x CR 116 6. Confirmed profile is upgraded to 1.57.x CR 116 7. Confirmed that updated shield settings are retained after the upgrade **Case 1.3:** Update the global default shield settings and then upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 3. Edit the global shield settings via brave://settings/shields 5. Upgrade the profile to 1.57.x CR 116 6. Confirmed profile is upgraded to 1.57.x CR 116 7. Confirmed that updated global shield settings are retained after the upgrade **Case 1.4:** Turn OFF the shield for a few sites and then upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 3. Turn OFF the shield for a few sites via panel 4. Upgrade the profile to 1.57.x CR 116 6. Confirmed profile is upgraded to 1.57.x CR 116 7. Confirmed that shield settings are retained after the upgrade **Case 1.5:** Block scripts and then upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 3. Block scripts for any of the sites via Panel or via brave://settings/shields 5. Upgrade the profile to 1.57.x CR 116 6. Confirmed profile is upgraded to 1.57.x CR 116 7. Confirmed that script block settings are retained after the upgrade **Case 1.6:** Block HTTPS upgrade and then upgrade - PASSED 1. Clean profile 1.56.x 2. Open a few websites 3. Block HTTPS upgrade via Panel or via brave://settings/shields 5. Upgrade the profile to 1.57.x CR 116 6. Confirmed profile is upgraded to 1.57.x CR 116 7. Confirmed that block HTTPS upgrade settings are retained after the upgrade

All items are present and work as expected in the ☰ menu - PASSED

Screen Shot 2023-08-09 at 10 12 04 AM ### Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Translate page works - PASSED

* confirmed I could translate from `Ukranian` to `English` on `https://www.pravda.com.ua/` * confirmed I could translate from `Spanish` to `English` on `esmas.com` * confirmed I could translate from `Spanish` to `English` and then to `Afrikaans`, on `esmas.com` example | example | example | example | example | example ---------|----------|---------|---------|----------|---------- Screen Shot 2023-08-09 at 10 45 51 AM | Screen Shot 2023-08-09 at 10 46 09 AM | Screen Shot 2023-08-09 at 10 48 26 AM | Screen Shot 2023-08-09 at 10 48 37 AM | Screen Shot 2023-08-09 at 10 48 53 AM | Screen Shot 2023-08-09 at 10 49 06 AM

Signing into Google sites works - PASSED

* confirmed `Allow use of third-party cookies for legacy Google Sign-In` was enabled via `brave://settings/socialBlocking` * confirmed I could log in to `expensify.com` using `SAML`, with the above pref enabled * toggled `Allow use of third-party cookies for legacy Google Sign-In` to `OFF` * confirmed I could NOT log in to `expensify` with the above pref disabled example | example | example | example ---------|----------|---------|--------- Screen Shot 2023-08-09 at 10 30 48 AM | Screen Shot 2023-08-09 at 10 34 50 AM | Screen Shot 2023-08-09 at 10 31 58 AM | Screen Shot 2023-08-09 at 10 32 01 AM |

Brave Side Panel looks/works correctly - PASSED

- Confirmed that sidebar is NOT shown by default - Confirmed that Reading list icon is added to the sidebar menu - Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu - Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab - Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list - Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu - Confirmed that reading list icon is shown in the URL bar, next to wallet icon - Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar) - Confirmed that reading list is shown in all the window types (Normal, PT, TOR, and Guest window) - Websites can't be added to reading list in Guest, encountered https://github.com/brave/brave-browser/issues/24930 - Confirmed that sites can be segregated to Read and Unread list - Confirmed that sites can be deleted from the reading list - Confirmed that tooltip is shown correctly for each menu item in sidebar - Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and Reading list works as expected

Clear browsing data for time span works - PASSED

Basic - last hour - `PASSED`
1. install `1.57.42` 2. launched Brave 3. browsed a few sites 4. logged in to a few sites 5. clicked on `Brave` -> `Clear Browsing Data...` 6. unchecked `Cookies and other site data` 7. clicked `Clear data` 8. confirmed `brave://history` was empty 9. confirmed I was still signed in to `gmail.com` 10. returned to `brave://settings/clearBrowserData` 11. checked `Cookies and other site data` 12. clicked `Clear data` 13. confirmed I was no longer signed in 14. confirmed `brave://history` was cleared example | example | example | example | example ---------|---------|----------|---------|---------- Screen Shot 2023-08-09 at 4 02 08 PM | Screen Shot 2023-08-09 at 4 02 18 PM | Screen Shot 2023-08-09 at 4 02 36 PM | Screen Shot 2023-08-09 at 4 05 22 PM | Screen Shot 2023-08-09 at 4 05 37 PM
Advanced - all time - `PASSED`
1. install `1.57.42` 2. launched Brave 3. browsed a few sites 4. logged in to a few sites 5. clicked on `Brave` -> `Clear Browsing Data...` 6. clicked on the `Advanced` tab 7. selected `All time` from `Time range` 8. clicked `Clear data` 9. confirmed I was no longer signed in 10. confirmed `brave://history` was cleared example | example | example | example | example ---------|----------|---------|----------|--------- Screen Shot 2023-08-09 at 4 27 03 PM | Screen Shot 2023-08-09 at 4 40 26 PM | Screen Shot 2023-08-09 at 4 27 22 PM | Screen Shot 2023-08-09 at 4 34 16 PM | Screen Shot 2023-08-09 at 4 27 15 PM
Advanced - last 7 days - `PASSED`
`Wednesday, August 9th` | clear `Last 7 days` | `Wednesday, August 2nd` ---------|----------|--------- Screen Shot 2023-08-09 at 5 10 10 PM | Screen Shot 2023-08-09 at 5 03 42 PM | Screen Shot 2023-08-09 at 5 03 56 PM
Advanced - last 4 weeks - `PASSED`
`Wednesday, Aug 9th` | clear `cache` | example | clear `cache` and `history` | `Tuesday, Jul 11th` ---------|----------|---------|----------|--------- Screen Shot 2023-08-09 at 5 32 01 PM | Screen Shot 2023-08-09 at 5 38 49 PM | Screen Shot 2023-08-09 at 5 39 08 PM | Screen Shot 2023-08-09 at 5 40 19 PM | Screen Shot 2023-08-09 at 5 40 29 PM

Omnibox suggestions are shown when enabled - PASSED

* confirmed default of no search suggestions when typing `san mateo weather` (and assorted searches) in the URL bar * confirmed `Improve search suggestions` is set to `OFF` in `brave://settings/search` * toggled `Improve search suggestions` to `ON` * typed `san mateo weather` again * confirmed I saw search-autocomplete suggestions in the URL bar * confirmed `Improve search suggestions`, when enabled, has no effect in both `Private` and `Private w/Tor` windows `Improve search suggestions`, `OFF` | `Improve search suggestions`, `ON` --------------------------------------|------------------------------------ Screen Shot 2023-08-09 at 11 04 33 AM | Screen Shot 2023-08-09 at 11 04 23 AM `Improve search suggestions`, `ON` | `Private` window | `Private w/Tor` window | `Guest` window --------------------------------------|------------------|------------------------|---------- Screen Shot 2023-08-09 at 11 12 57 AM | Screen Shot 2023-08-09 at 11 13 14 AM | Screen Shot 2023-08-09 at 11 13 41 AM | Screen Shot 2023-08-09 at 11 19 53 AM ### Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Installation and upgrade work (upgrade 1.56.x -> 1.57.x and 1.57.x to 1.57.x) - PASSED

### Update from `1.56.x` to `1.57.x` - `PASSED`
Done as part of the `Shields`-profile upgrade work, see above
### Update from `1.57.42` to`1.57.44` - `PASSED`
### Steps: 1. installed `1.57.42` 2. launched Brave using a seeded profile, and commandline: `./Brave\ Browser --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml --enable-logging=stderr` 3. loaded `brave://settings/help` 4. confirmed it checked for an update 5. confirmed it found an update 6. clicked on the `Relaunch` button 7. confirmed I was updated to `1.57.44` and the profile was intact `1.57.42` | `updating Brave` | clicked `relaunch` | `1.57.44` ----------|--------|-----------|-------- Screen Shot 2023-08-10 at 5 49 46 AM | Screen Shot 2023-08-10 at 5 50 06 AM | Screen Shot 2023-08-10 at 5 51 27 AM | Screen Shot 2023-08-10 at 5 51 38 AM
LaurenWags commented 1 year ago

Verified with

Brave   1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision    109e984111c5152478bf49d266f4e19861c0b63e
OS  Linux

Previous testing completed with https://github.com/brave/brave-browser/issues/30747#issuecomment-1671666069 includes:

Resuming testing with:

Brave Side Panel looks/works as expected - PASSED - Confirmed that sidebar is not shown by default in the release channel - Confirmed that `Reading list` icon is added to the sidebar menu - Confirmed that reading list panel is shown when user click on the `Reading list` icon in the sidebar menu - Confirmed that user can add the `list of websites` to the reading list by clicking on the `+Add current tab` - Confirmed that user can add the `list of websites` to the reading list by right clicking on the tab and choose the option `Add tab to the reading list` - Confirmed that `reading list panel can be hidden` by clicking on the `Reading list` icon in the sidebar menu - Confirmed that reading list icon is shown in the URL bar, next to wallet icon - Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar) - Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window) - Websites can't be added to reading list in Guest, encountered https://github.com/brave/brave-browser/issues/24930 - Confirmed that sites can be segregated to `Read` and `Unread` list - Confirmed that sites can be deleted from the reading list - Confirmed that tooltip is shown correctly for each menu item in sidebar - Confirmed that click on each side panel button `Brave Talk`, `wallet`, `Bookmarks` and `Reading list` works as expected
Clear browsing data for time span works - PASSED
Basic - last hour - PASSED 1. install `1.57.4x` 2. launched Brave 3. browsed a few sites 4. logged in to a few sites, closed these tabs 5. clicked on `Brave` -> `Clear Browsing Data...` 6. unchecked `Cookies and other site data` 7. clicked `Clear data` 8. confirmed `brave://history` was empty 9. confirmed I was still signed in to `libravatar.org`, closed this tab 10. returned to `brave://settings/clearBrowserData` 11. checked `Cookies and other site data` 12. clicked `Clear data` 13. confirmed I was no longer signed in 14. confirmed `brave://history` was cleared example | example | example | example | example | example ---------|---------|----------|---------|----------| --------- 1 | 2 | 3 | 4 | 5 | 6
Advanced - all time - PASSED 1. install `1.57.x` 2. launched Brave 3. browsed a few sites 4. logged in to a few sites 5. Set up additional data (downloads, site specific shield settings, etc) 6. clicked on `Brave` -> `Clear Browsing Data...` 7. clicked on the `Advanced` tab 8. selected `All time` from `Time range` 9. Selected all items 10. clicked `Clear data` 11. confirmed I was no longer signed in 12. confirmed `brave://history` was cleared 13. Confirmed other items (downloads, site specific shield settings, etc) were cleared example | example | example | example | example | example ---------|----------|---------|----------|---------|-------- 1 | 2 | 3 | 4 | 5 | 6
Omnibox suggestions are shown when enabled - PASSED 1. Confirm that the `Show autocomplete suggestions in address bar` switch is enabled by default under brave://settings/appearance 2. Open a new tab and enter the string `Buzz` in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list 3. Go to brave://settings/appearance and uncheck/disable the checkbox `Top sites` 4. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled 5. Open the buzzfeed.com in any tab 6. Keep the `Top sites` still disabled/unchecked 7. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the `Browsing History` list 8. Go to brave://settings/appearance and uncheck/disable the checkbox `Browsing History` and keep Top sites as it is in step 6 9. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` and `browsing history` toggles are disabled/unchecked 10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab 11. Keep the brave://settings/appearance setting as it is 12. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the `Bookmarks` list 13. Go to brave://settings/appearance and uncheck `Bookmarks` (all the 3 settings checkboxes are unchecked in this step) 14. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` , `browsing history` and `bookmarks` toggles are disabled/unchecked 15. Enable alll the 3 switches under `Show autocomplete suggestions in address bar` main switch 16. Disable the main switch `Show autocomplete suggestions in address bar` 17. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `Show autocomplete suggestions in address bar` main switch is OFF step 2 | step 3 | step 4 | step 7 | step 8 | step 9 | step 10 | step 11 | step 12 | step 13 | step 14 | step 15 | step 16 | step 17 -------|--------|---------|--------|--------|--------|----------|---------|----------|---------|----------|---|---|-- 2 | 3 | 4 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17
Uni-verse commented 1 year ago

Verified on Samsung Galaxy Tab S7 using version(s):

Brave   1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision    109e984111c5152478bf49d266f4e19861c0b63e
OS  Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-08-10 at 11 30 27 AM Screenshot 2023-08-10 at 11 30 58 AM
Uni-verse commented 1 year ago

Verified on Samsung Galaxy S21 5G using version(s):

Brave   1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision    109e984111c5152478bf49d266f4e19861c0b63e
OS  Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-08-10 at 11 48 58 AM Screenshot 2023-08-10 at 11 49 16 AM
MadhaviSeelam commented 1 year ago

Verification PASSED using

Brave | 1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit)
-- | --
Revision | 109e984111c5152478bf49d266f4e19861c0b63e
OS | Windows 11 Version 22H2 (Build 22621.2134)
image
LaurenWags commented 1 year ago

Changed to QA/No and release-notes/exclude as this is superseded by https://github.com/brave/brave-browser/issues/32241