brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Display a helpful error message when the sync device limit is reached #32297

Open fmarier opened 1 year ago

fmarier commented 1 year ago

There is currently a server-enforced limit of 50 devices per sync chain. At the moment, joining a full chain will trigger a generic error.

We should display a more helpful error message that explains the problem.

fmarier commented 1 year ago

My suggestion:

This Sync chain is full and it's not possible to add more devices to it. Please remove any unused devices before trying to join this Sync chain.

rmcfadden3 commented 1 year ago

This Sync chain has reached its device limit. To add a new device, please first remove any unused devices.

or

This Sync chain has reached its device limit. To add a new device, please first remove any unused devices and then try syncing again.

fmarier commented 1 year ago

Thanks @rmcfadden3 . Let's go with the first option:

This Sync chain has reached its device limit. To add a new device, please first remove any unused devices.

bsclifton commented 2 months ago

Related https://github.com/brave/brave-browser/issues/27929