brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Block social sharing buttons as trackers by default #3241

Closed tildelowengrimm closed 4 years ago

tildelowengrimm commented 5 years ago

Long-term, we should replace social sharing buttons with inert placeholders which only communicate with the sites when you interact with them (#534). But until we implement that, we should err on the side of safety by blocking them outright.

Edit bbondy: I bumped this to P3 because I'm landing this in 0.63.x which allows users to turn off social buttons and embedded tweets: https://github.com/brave/brave-core/pull/1818

Redback812 commented 5 years ago

How about covering all social sharing from all or most social media sites, facebook is one problem however the numerous other sites like instagram, twitter, snapchat, linkden, google and etc. Give us the ability to cherry pick who we wish to allow or not from brave shield.

tildelowengrimm commented 5 years ago

@Redback812 That's the sort of thing that's in the long-term work of #534, not this short-term solution.

fmarier commented 5 years ago

I created a test page with all of the social widgets I could find.

Looking at the widgets that aren't blocked on my test page, we might be able to blacklist the following URL fragments:

to disable Like/Share buttons that use the iframe API.

Note that in practice that means we would have to remove the www.facebook.com exception on desktop and Android and replace them with more specific rules like:

When it comes to Twitter and the Facebook JS API, they all rely on the same JS resources (https://platform.twitter.com/widgets.js and https://connect.facebook.net/en_US/sdk.js respectively) and so we can't block the buttons without also blocking embedded content like videos or timelines.

fmarier commented 5 years ago

@tomlowenthal Do you think this is still worth doing, given it's not going to block all of the buttons?

fmarier commented 5 years ago

@bbondy suggests waiting until Steps 2/3 of #3475 are done since this new plan is being actively worked on.

diracdeltas commented 5 years ago

@tomlowenthal do you think this can be closed in favor of Steps 2 and 3 in https://github.com/brave/brave-browser/issues/3475? (which are partially done)

bbondy commented 5 years ago

Added an edit to comment 0:

Edit bbondy: I bumped this to P3 because I'm landing this in 0.63.x which allows users to turn off social buttons and embedded tweets: brave/brave-core#1818

ryanbr commented 5 years ago

Probably too problematic. A better option, specifically targeting facebook. Include an optional list for all facebook.com third-party elements.

https://github.com/ryanbr/fanboy-adblock/blob/master/fanboy-antifacebook.txt

In a similar vain to the recent Firefox facebook container feature, which could be easily done in a list.

pes10k commented 4 years ago

closing in ~favor of https://github.com/brave/brave-browser/issues/3241~ https://github.com/brave/brave-browser/issues/817