brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.72k stars 2.31k forks source link

hamburger menu display changed with C116 minor bump #32469

Open LaurenWags opened 1 year ago

LaurenWags commented 1 year ago

Description

With the C116 minor bump via https://github.com/brave/brave-browser/issues/32451, the hamburger menu display changed. There are no longer any spaces at the beginning of each line item, making the hamburger menu look a little squished.

Steps to Reproduce

  1. Be on 1.57.53
  2. Open hamburger menu

Actual result:

53

Expected result:

This is how it appears in 1.57.47 Chromium: 116.0.5845.96

47

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @rebron @mkarolin @kjozwiak

joejoejo commented 1 year ago

don't know how or if these relate but chrome did have some commits that were specific to the menus: https://chromium.googlesource.com/chromium/src/+/fd9a7a6e8d153d63cf65e1e8777cfa99902d7e52 https://chromium.googlesource.com/chromium/src/+/787fba762131e633d0482b00930672251be05615 and https://chromium.googlesource.com/chromium/src/+/49bc950a72bdcffd9e0745371d4083418697256a

rebron commented 1 year ago

Removing release blocking due to the nature of the security fixes in chromium 116.0.5845.110/.111

MadhaviSeelam commented 1 year ago

Reproduced the issue in Win 11 x64

image
kjozwiak commented 1 year ago

@rebron is the above still valid? Looks like the hamburger menu looks like the following right now on 1.60.x which is on Nightly. I know we also have https://github.com/brave/brave-browser/issues/32410 within 1.59.x.

image