search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.81k stars 2.33k forks source link

Playlist: use button elements for buttons #32486

Closed petemill closed 1 year ago

petemill commented 1 year ago

In the playlist sidebar, the buttons are not showing as interactive elements. This makes them impossible to use via non-mouse users, e.g. keyboard or screen readers. Using a

sangwoo108 commented 1 year ago

I think I remember @fallaciousreasoning suggested that before, but the button couldn't have custom size back then. If it still doesn't have that, let me solve that first when I start polishing. Recently, icons are changed so need to bump up leo, so it could be good chance to improve leo compoents!

fallaciousreasoning commented 1 year ago

Looking at it, I think we just want to be able to remove the padding - is that right @sangwoo?

edit: I just had a look - apparently the button already supports a custom padding with --leo-button-padding! I'm updating the storybook to include it because it was missing before https://github.com/brave/leo/pull/359

edit 2: just made a PR https://github.com/brave/brave-core/pull/19853 (sorry @sangwoo108)