brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.57k stars 2.28k forks source link

Add close function when selecting Brave Leo button in Speedreader #32610

Closed rebron closed 1 year ago

rebron commented 1 year ago

Description

Currently selecting the Brave Leo button in Speedreader opens up the Leo side panel. Upon clicking the Brave Leo button in Speedreader again, the sidepanel should be closed.

Also, update tooltip text to read Brave Leo instead of Brave AI

Steps to Reproduce

  1. Use 1.59.57 and higher.
  2. Go to a page that can be speed read such as https://www.sfgate.com/bayarea/article/where-to-see-super-blue-moon-bay-area-18337306.php
  3. Hover to see tooltip and select Leo button. Notice it only opens the Leo side panel but doesn't close it.
Screenshot 2023-08-29 at 9 29 33 PM

Actual result:

See STR

Expected result:

See Descriptio

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Related: https://github.com/brave/brave-browser/issues/29075 and https://github.com/brave/brave-browser/issues/31583

stephendonner commented 12 months ago

Verified PASSED using

Brave | 1.60.60 Chromium: 117.0.5938.92 (Official Build) nightly (64-bit)
-- | --
Revision | 9a4644344a53150ebad5406037a6463714787348
OS | Windows 10 Version 22H2 (Build 19045.3516)

Steps:

  1. installed 1.60.60
  2. launched Brave
  3. restarted (to pick up the Griffin seed)
  4. loaded https://www.sfgate.com/bayarea/article/target-closing-3-bay-area-stores-permanently-18390163.php in Speedreader mode
  5. clicked on the Brave Leo icon in the sidebar
  6. confirmed Brave Leo opened
  7. clicked on the Brave Leo icon on the top Speedreader toolbar

Confirmed it snapped the Brave Leo sidebar pane closed

Step 4 Step 5 Step 7, before click Step 7, after click
image image image image