search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.46k stars 2.26k forks source link

Expanded vertical tabs panel does not reliably collapse on mouseleave. #32755

Open mbuening opened 11 months ago

mbuening commented 11 months ago

Description

When having the Vertical Tabs panel to automatically expand/collapse it quite often does not collapse when mouse leaves panel area.

Steps to Reproduce

The error is difficult to reproduce reliably but occurs frequently. I think I found one way to reproduce and attached a video showing the error. Vertical tabs and the option "Expand vertical tabs panel on mouseover when collapsed" have to be enabled in the settings, of course. Tab hover mode is set to option "Card with preview".

  1. Click desktop left outside of Brave window so Brave is not the active application.
  2. Move mouse over vertical tab panel and click to open: Panel opens.
  3. Move mouse to the right outside of panel area: Panel does not collapse.

See attached screen recording.

Actual result:

Vertical tabs panel does not collapse when mouse leaves panel area.

Expected result:

Vertical tabs panel does collapse when mouse leaves panel area.

Reproduces how often:

Frequently.

Brave version (brave://version info)

Brave 1.57.57 Chromium: 116.0.5845.163 (Official Build) (x86_64)
Revision d85db1f5df3b20ffecf96ab3f0dc7fca1d536955
OS macOS Version 10.14.6 (Build 18G9323)
JavaScript V8 11.6.189.19
User agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --disable-domain-reliability --enable-dom-distiller --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path /Users/mb/Library/Application Support/BraveSoftware/Brave-Browser/Default
Linker lld
Active variations AllowCertainClientHintsStudy:EnabledBraveAdblockMobileNotificationsListDefault:EnabledBraveAds.AdServingStudy:DefaultAdNotificationsPerHour=10/MaximumAdNotificationsPerDay=100/MaximumInlineContentAdsPerHour=6/MaximumInlineContentAdsPerDay=20/AdServingVersion=2BraveAutoTranslateStudy:AutoTranslateDisabledBraveCleanupSessionCookiesOnSessionRestore:DisabledBraveDebounceStudy:EnabledBraveForgetFirstPartyStorage:DisabledBraveGoogleSignInPermissionStudy:DisabledBraveHttpsByDefaultRolloutStudy:EnabledBraveP3AConstellationReleaseRollout:EnabledBraveRewardsWebUiPanelStudy:EnabledBraveScreenFingerprintingBlockerStudy:EnabledCookieListDefaultStudy:EnabledCrossPlatformVPNStudy:EnabledDefault1pBlockingStudy:DisabledDisableReduceLanguage:EnabledEphemeralStorageStudy:EnabledFirstPartyEphemeralDomainBlockStudy:EnabledForceDisableBlinkFeatures:EnabledMacCoreLocationBackendStudy:EnabledPartitionBlinkMemoryCacheStudy:EnabledPartitionConnectionsByNetworkIsolationKeyStudy:EnabledPermissionLifetimeReleaseStudy:EnabledSpeedreaderReleaseStudy:EnabledUserActivityStudy:TriggersWhatsNewStudy:Enabled

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

https://github.com/brave/brave-browser/assets/100283377/9016b7e7-60e2-4e12-a00c-a4e6ce89ea1e

mbuening commented 11 months ago

BTW: Error does not occur in Brave Version 1.52.130. So it seems to be a regression error.

sangwoo108 commented 9 months ago

https://github.com/brave/brave-browser/issues/30607

Like an issue above, this might be be OS specific bug. On my Mac(Ventura), I can't reproduce this.

mbuening commented 9 months ago

30607

Like an issue above, this might be be OS specific bug. On my Mac(Ventura), I can't reproduce this.

This might very well be an macOS Mojave specific bug but still it used to work in 1.52.130. Since Mojave is not supported any more it might not be worth fixing. I think it would be nice if it worked in the latest Mojave installable version (1.58.xxx?) though.

urbenlegend commented 3 months ago

This isn't specific to Mac. I am also experiencing this issue in Arch Linux KDE. I have to click on something else in the vertical tabs list and then mouse out in order to get it to re-hide.