search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.31k forks source link

Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48. #32809

Closed mkarolin closed 1 year ago

mkarolin commented 1 year ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/117.0.5938.35..117.0.5938.48?pretty=fuller&n=10000

QA tests:

Additional checks:

kjozwiak commented 1 year ago

The above will need to be verified on 1.58.x once we get C117 merged into 1.58.x. However, it's possible we'll have a higher version at that point so the above will become QA/No. Adding QA/Blocked till C117 moves into 1.58.x.

kjozwiak commented 1 year ago

Quick overview of the work remaining re: affected areas due to C117 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/31768#issue-1814677324:

Platforms that still need to check/verify the affected areas due to C117 changes as per https://github.com/brave/brave-browser/issues/31768#issue-1814677324.

LaurenWags commented 1 year ago

Verified with

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 13.5.2 (Build 22G91)

Verified desktop affected areas from https://github.com/brave/brave-browser/issues/31768#issue-1814677324.

Private/Tor/Guest windows have correct colors - PASSED

### Confirmed Brave color schemes for: * normal {Dark, Light} * Private * Tor * Guest windows Normal, `Light` | Normal, `Dark` | Private | Tor | Guest ---------------|----------------|---------|-----|------- 1 | 2 | 3 | 4 | 5

Autocomplete in URL bar generally works as expected - PASSED

1. Confirm that the `Show autocomplete suggestions in address bar` switch is enabled by default under brave://settings/appearance 2. Open a new tab and enter the string `Buzz` in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list 3. Go to brave://settings/appearance and uncheck/disable the checkbox `Top sites` 4. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled 5. Open the buzzfeed.com in any tab 6. Keep the `Top sites` still disabled/unchecked 7. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the `Browsing History` list 8. Go to brave://settings/appearance and uncheck/disable the checkbox `Browsing History` and keep Top sites as it is in step 6 9. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` and `browsing history` toggles are disabled/unchecked 10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab 11. Keep the brave://settings/appearance setting as it is 12. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the `Bookmarks` list 13. Go to brave://settings/appearance and uncheck `Bookmarks` (all the 3 settings checkboxes are unchecked in this step) 14. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` , `browsing history` and `bookmarks` toggles are disabled/unchecked 15. Enable alll the 3 switches under `Show autocomplete suggestions in address bar` main switch 16. Disable the main switch `Show autocomplete suggestions in address bar` 17. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `Show autocomplete suggestions in address bar` main switch is OFF step 1 | step 2 | step 3 | step 4 | step 7 | step 8 | step 9 | step 10 | step 11 | step 12 | step 13 | step 14 | step 15 | step 16 | step 17 -------|--------|---------|--------|--------|--------|----------|---------|----------|---------|----------|---|---|--|------ 1 | 2 | 3 | 4 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 ### Confirmed autocomplete provided search suggestions when `Improve search suggestions` is set to `Enabled` / `On` brave://settings/search | improve search suggestions -------------|---------------- 1 | 2 ### Confirmed autocomplete did not provide search suggestions when `Improve search suggestions` is set to `Disabled` / `Off` brave://settings/search | improve search suggestions -------------|---------------- 3 | 4

Tab strip has expected colors and geometry - PASSED

### Horizontal `1.57.62` | `1.58.120` ----------|-------- 1 | 2 3 | 4 ### Vertical `1.57.62` | `1.58.120` ---------|---------- 5 | 6 7 | 8

Browsing data removal generally works - PASSED

### _Basic_ - `PASSED` `Clear browsing data` dialog | `Browsing history` | `Cookies and other site data` | `Cached images and files` --------|--------|----------|--------------- 1 | 2 | 3 | N/A ### _Advanced_ - `PASSED` `Clear browsing data` dialog | `Browsing history` | `Download history` | `Cookies and other site data` | `Passwords` | `Autofill data` ------------------------------|---------|----------|---------------------|-------------|------------ 1 | 2 | 3 | 4 | 5 | 6 ### _On exit_ - `PASSED` `Clear browsing data` dialog | `Browsing history` | `Download history` | `Cookies and other site data` | `Passwords` | `Autofill data` ------------------------------|---------|----------|---------------------|-------------|------------ 1 | 2 | 3 | 4 | 5 | 6

Page Info UI generally works (cookies subpage specifically) - PASSED

### Confirmed ability to view and manage cookies via the page-info dialog's submenus Site Information UI | Security | Site Settings | Manage cookies and site data | Cookies and site data | cleared data | reload prompt | logged out ----------|-----------|----------|----------|-----------|--------|--------|------- 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8
stephendonner commented 1 year ago

Verification PASSED using

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 11.7.9 (Build 20G1426)

Tab search looks and functions as expected - PASSED (*)

### Default-tab type `Show tab search button` enabled | `Show tab search button` disabled | open tabs | search -----------------------------------|------------------------------------|---------|---------- Screen Shot 2023-09-11 at 2 25 13 PM | Screen Shot 2023-09-11 at 2 25 21 PM | Screen Shot 2023-09-11 at 2 25 29 PM | Screen Shot 2023-09-11 at 2 25 34 PM ### Vertical-tab type `Show tab search button` enabled | `Show tab search button` disabled | open tabs | search -----------------------------------|------------------------------------|-------------------|--------------- Screen Shot 2023-09-11 at 2 07 21 PM | (*) logged https://github.com/brave/brave-browser/issues/32919 | Screen Shot 2023-09-11 at 2 12 19 PM | Screen Shot 2023-09-11 at 2 12 37 PM

Shields generally work correctly (cookies blocked) - PASSED

1. installled `1.58.120` 2. launched Brave 3. opened `brave://settings/shields` 4. confirmed `Trackers & ads blocking` was set to `Standard` 5. loaded `aol.com` 6. clicked on the `Shields` icon in the address bar 7. clicked on `Advanced controls` 8. confirmed the corresponding cookie-blocking options below `Block all cookies` - `PASSED` ### Confirmed all cookies were blocked example | example ---------|--------- Screen Shot 2023-09-11 at 12 31 35 PM | Screen Shot 2023-09-11 at 12 32 11 PM `Block cross-site cookies` - `PASSED` ### Confirmed all third-party cookies were blocked, but `aol.com` ones were allowed example | example ---------|--------- Screen Shot 2023-09-11 at 12 28 53 PM | Screen Shot 2023-09-11 at 12 29 25 PM `Allow all cookies` - `PASSED` ### Confirmed third-party (`yahoo.net`) cookies were additionally allowed example | example ---------|--------- Screen Shot 2023-09-11 at 12 37 17 PM | Screen Shot 2023-09-11 at 12 37 42 PM

HTTP -> HTTPS upgrading works as expected - PASSED

1. installed `1.58.120` 9. launched Brave 10. opened `brave://settings/shields` 11. confirmed `Upgrade connections to HTTPS` was `Enabled` by default 12. loaded `http://upgradable.arthuredelstein.net` 13. enabled `Show Full URLs` from the top-level `View` menu ### Confirmed I was automatically upgraded to `https://upgradable.arthuredelstein.net` from `http://upgradable.arthuredelstein.net` Also confirmed clicked through the warning interstitial on `http://insecure.arthuredelstein.net`, which loaded the site. Finally, confirmed `Not secure` warning in address bar for `http://http.badssl.com` example | example | example | example | example ---------|----------|---------|----------|--------- Screen Shot 2023-09-11 at 12 05 43 PM | Screen Shot 2023-09-11 at 12 08 02 PM | Screen Shot 2023-09-11 at 12 10 57 PM | Screen Shot 2023-09-11 at 12 11 01 PM | Screen Shot 2023-09-11 at 12 11 24 PM

Vertical tabs look and work as expected - PASSED

### Steps: 1. installed `1.58.120` 14. launched Brave 15. loaded a few tabs 16. context-clicked on a tab and chose `Use Vertical Tabs` 17. confirmed vertical-tab mode 18. context-clicked on a tab and confirmed context-menu items were tab-specific 19. confirmed default prefs in `brave://settings/appearance` 20. confirmed `Show title bar` and collapsed view 21. also confirmed `Dark` mode example | example | example | example | example | example ---------|---------|----------|----------|---------|--------- Screen Shot 2023-09-11 at 11 19 45 AM | Screen Shot 2023-09-11 at 11 19 53 AM | Screen Shot 2023-09-11 at 11 25 24 AM | Screen Shot 2023-09-11 at 11 31 32 AM | Screen Shot 2023-09-11 at 11 31 41 AM | Screen Shot 2023-09-11 at 11 40 28 AM ### Confirmed vertical tabs looked and worked as expected, in both `Light` and `Dark` modes example | example | example ---------|----------|--------- Screen Shot 2023-09-11 at 11 43 26 AM | Screen Shot 2023-09-11 at 11 44 52 AM | Screen Shot 2023-09-11 at 11 47 29 AM

Password Manager has expected Brave styling - PASSED

### Steps: 1. installed `1.58.120` 22. launched Brave 23. opened `brave://settings` 24. clicked on `Autofill and passwords` 25. clicked `Add` 26. added `fill.dev`test entry 27. clicked on entry to view it 28. confirmed I was prompted for my `Touch ID` 29. confirmed password details for `fill.dev` were revealed ### Confirmed Brave styling throughout Password Manager, in both `Dark` and `Light` modes ### _Dark_ default | `brave://password-manager/settings` | `Add new password` | `fill.dev` entry | `Touch ID` prompt | `fill.dev` details | inactivity timeout ---------|---------|-----------|-----------------|---------|---------|-------- Screen Shot 2023-09-11 at 10 32 03 AM | Screen Shot 2023-09-11 at 10 34 11 AM | Screen Shot 2023-09-11 at 10 36 34 AM | Screen Shot 2023-09-11 at 10 36 37 AM | Screen Shot 2023-09-11 at 10 37 13 AM | Screen Shot 2023-09-11 at 10 36 45 AM | Screen Shot 2023-09-11 at 10 42 34 AM ### _Light_ default | `brave://password-manager/settings` | `Add new password` | `fill.dev` entry | `Touch ID` prompt | `fill.dev` details | inactivity timeout ---------|---------|-----------|-----------------|---------|---------|-------- Screen Shot 2023-09-11 at 10 45 13 AM | Screen Shot 2023-09-11 at 10 47 00 AM | Screen Shot 2023-09-11 at 10 45 28 AM | Screen Shot 2023-09-11 at 10 44 44 AM | Screen Shot 2023-09-11 at 10 45 01 AM | Screen Shot 2023-09-11 at 10 45 05 AM | Screen Shot 2023-09-11 at 10 50 11 AM

Extensions WebUI has expected Brave styling & extensions can be installed - PASSED

### Steps: 1. installed `1.58.120` 30. launched Brave 31. opened `brave://extensions` 32. installed assorted extensions 33. disabled an extension 34. clicked `Details` on an extension 35. uninstalled an extension ### Confirmed Brave styling throughout `brave://extensions`, in both `Light` and `Dark` modes ### _Light_ example | example | example | example | example ---------|----------|---------|----------|--------- Screen Shot 2023-09-11 at 10 10 24 AM | Screen Shot 2023-09-11 at 10 13 39 AM | Screen Shot 2023-09-11 at 10 16 06 AM | Screen Shot 2023-09-11 at 10 16 54 AM | Screen Shot 2023-09-11 at 10 16 57 AM | Screen Shot 2023-09-11 at 10 17 03 AM ### _Dark_ example | example | example | example ----------|---------|---------|--------- Screen Shot 2023-09-11 at 10 20 17 AM | Screen Shot 2023-09-11 at 10 20 27 AM | Screen Shot 2023-09-11 at 10 20 36 AM | Screen Shot 2023-09-11 at 10 21 23 AM

Logged:

Uni-verse commented 1 year ago

Verified on Samsung Galaxy S21 using the following version(s):

Brave   1.58.120 Chromium: 117.0.5938.48 (Official Build) (32-bit) 
Revision    8b2e2785c90c076fc1413acb2c003e603eac02d3
OS  Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-09-11 at 2 11 22 PM Screenshot 2023-09-11 at 2 14 35 PM
MadhaviSeelam commented 1 year ago

Verification PASSED using

Brave   1.58.120 Chromium: 117.0.5938.48 (Official Build) (64-bit) 
Revision    8b2e2785c90c076fc1413acb2c003e603eac02d3
OS  Linux

Verified desktop affected areas from https://github.com/brave/brave-browser/issues/31768#issue-1814677324.

Private/Tor/Guest windows have correct colors - PASSED

### Confirmed Brave color schemes for: * normal {Dark, Light} * Private * Tor * Guest windows Normal, `Light` | Normal, `Dark` | Private | Tor | Guest ---------------|----------------|---------|-----|------- ![image](https://github.com/brave/brave-browser/assets/98358127/b5e65f8e-c252-42b3-8483-15a9cfb6e87d)|![image](https://github.com/brave/brave-browser/assets/98358127/a9d853e2-8c15-4879-a959-5c92bbb08d6c)|![image](https://github.com/brave/brave-browser/assets/98358127/0d2d0c89-de07-4219-88a3-473e3db75698)|![image](https://github.com/brave/brave-browser/assets/98358127/c203fd3f-54a1-4f7a-9294-cc75ce022538)|![image](https://github.com/brave/brave-browser/assets/98358127/2f8e6a63-2fd5-42e8-9fb6-6e218a85a6ba)

Autocomplete in URL bar generally works as expected - PASSED

1. Confirm that the `Show autocomplete suggestions in address bar` switch is enabled by default under brave://settings/appearance 2. Open a new tab and enter the string `Buzz` in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list 3. Go to brave://settings/appearance and uncheck/disable the checkbox `Top sites` 4. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled 5. Open the buzzfeed.com in any tab 6. Keep the `Top sites` still disabled/unchecked 7. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the `Browsing History` list 8. Go to brave://settings/appearance and uncheck/disable the checkbox `Browsing History` and keep Top sites as it is in step 6 9. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` and `browsing history` toggles are disabled/unchecked 10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab 11. Keep the brave://settings/appearance setting as it is 12. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the `Bookmarks` list 13. Go to brave://settings/appearance and uncheck `Bookmarks` (all the 3 settings checkboxes are unchecked in this step) 14. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` , `browsing history` and `bookmarks` toggles are disabled/unchecked 15. Enable alll the 3 switches under `Show autocomplete suggestions in address bar` main switch 16. Disable the main switch `Show autocomplete suggestions in address bar` 17. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `Show autocomplete suggestions in address bar` main switch is OFF step 1 | step 2 | step 3 | step 4 | step 7 | step 8 | step 9 | step 10 | step 11 | step 12 | step 13 | step 14 | step 15 | step 16 | step 17 -------|--------|---------|--------|--------|--------|----------|---------|----------|---------|----------|---|---|--|------ ![image](https://github.com/brave/brave-browser/assets/98358127/86a0f054-e63f-4a0a-bc4c-864db38391a7)|![image](https://github.com/brave/brave-browser/assets/98358127/69313016-97a5-4523-b0a8-31db7add99b6)|![image](https://github.com/brave/brave-browser/assets/98358127/ffd7fb5c-e60e-4e85-a633-0632b3e12e2f)|![image](https://github.com/brave/brave-browser/assets/98358127/41af3f52-5225-4f8e-82c7-b6d0d55a7c1a)|![image](https://github.com/brave/brave-browser/assets/98358127/03718948-11e1-4b97-a443-66d216cd3560)|![image](https://github.com/brave/brave-browser/assets/98358127/110ab122-46c4-4ff6-aa93-96114311d9e8)|![image](https://github.com/brave/brave-browser/assets/98358127/d936d946-83d3-4bdb-af96-7f540873af05)|![image](https://github.com/brave/brave-browser/assets/98358127/4b488f50-219a-44f7-add0-a3636fb7d5a1)|![image](https://github.com/brave/brave-browser/assets/98358127/79a6fcc0-5bff-45d3-83e9-8dc074718ea8)|![image](https://github.com/brave/brave-browser/assets/98358127/2b8c5600-27c0-46f0-b8e1-68c719e0a3a9)|![image](https://github.com/brave/brave-browser/assets/98358127/8bb87aec-a5c9-4edc-8247-f722fb81931f)|![image](https://github.com/brave/brave-browser/assets/98358127/e8d207af-7cb5-45ed-a926-8af33e3fcdab)|![image](https://github.com/brave/brave-browser/assets/98358127/779678c3-9c10-429f-a710-92f0881232a8)|![image](https://github.com/brave/brave-browser/assets/98358127/4c623a2c-2a37-441c-86d1-d94bbe30bb1f)|![image](https://github.com/brave/brave-browser/assets/98358127/7296f9cd-3eff-4f0b-a657-26f1857626a4) Confirmed autocomplete provided search suggestions when Improve search suggestions is set to Enabled / On brave://settings/search | improve search suggestions ---- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/4c7655b8-2d13-408e-9869-7526c42b952c)|![image](https://github.com/brave/brave-browser/assets/98358127/01d435ba-68c8-4b83-be92-662503567790) Confirmed autocomplete did not provide search suggestions when Improve search suggestions is set to Disabled / Off brave://settings/search | improve search suggestions ---- | --- ![image](https://github.com/brave/brave-browser/assets/98358127/ee837b0d-6de3-45ed-b0ac-bdd8f78c4bc7)|![image](https://github.com/brave/brave-browser/assets/98358127/2148a585-c202-4040-a540-8671390edf14)

Tab strip has expected colors and geometry - PASSED

### Horizontal `1.57.62` | `1.58.120` ----------|-------- ![image](https://github.com/brave/brave-browser/assets/98358127/f3e802e0-0241-4ca5-a322-a1d738e18e15)|![image](https://github.com/brave/brave-browser/assets/98358127/03f9e3eb-8f06-4421-97c2-22787a4c506c) ![image](https://github.com/brave/brave-browser/assets/98358127/6380bc48-ac45-4670-b6c3-e994289973f0)|![image](https://github.com/brave/brave-browser/assets/98358127/85210eb9-bc9a-4299-9d76-41968f51cc86) ### Vertical `1.57.62` | `1.58.120` ----------|-------- ![image](https://github.com/brave/brave-browser/assets/98358127/2418f6df-44b9-4822-90ff-be0e4cfcfe46)|![image](https://github.com/brave/brave-browser/assets/98358127/f717f3f7-158e-4709-adda-50ea4e17c99f) ![image](https://github.com/brave/brave-browser/assets/98358127/2596cb6a-2a67-44bd-8703-adcf02e8a677)|![image](https://github.com/brave/brave-browser/assets/98358127/25ca9716-bba4-40ef-9491-6da9f187c805)

Browsing data removal generally works - PASSED

`Clear browsing data` dialog | `Browsing history` | `Cookies and other site data` | `Cached images and files` --------|--------|----------|--------------- ![image](https://github.com/brave/brave-browser/assets/98358127/b7236b60-5878-494d-82bc-40ddc9443517)|![image](https://github.com/brave/brave-browser/assets/98358127/ac00285f-5865-4610-b020-c0e3820a4f27)|![image](https://github.com/brave/brave-browser/assets/98358127/33fa4745-215d-4c26-b977-dbfbc0d2139c)|N/A ### _Advanced_ - `PASSED` `Clear browsing data` dialog | `Browsing history` | `Download history` | `Cookies and other site data` | `Passwords` | `Autofill data` ------------------------------|---------|----------|---------------------|-------------|------------ ![image](https://github.com/brave/brave-browser/assets/98358127/5b225b82-67d4-4adc-bfa4-16983d43bc19)|![image](https://github.com/brave/brave-browser/assets/98358127/1b67b9d4-3545-4117-8136-18c724329d0e)|![image](https://github.com/brave/brave-browser/assets/98358127/a4a6685b-7062-49e1-ac9c-764dc61fc598)|![image](https://github.com/brave/brave-browser/assets/98358127/8f94ab1f-9273-48e9-97d3-75342cbbcb51)|![image](https://github.com/brave/brave-browser/assets/98358127/496a80d6-ac5c-470f-9c94-0f8db1f4e266)|![image](https://github.com/brave/brave-browser/assets/98358127/2a0f64e7-aa24-456b-b7e5-30ae97077880) ### _On exit_ - `PASSED` `Clear browsing data` dialog | `Browsing history` | `Download history` | `Cookies and other site data` | `Passwords` | `Autofill data` ------------------------------|---------|----------|---------------------|-------------|------------ ![image](https://github.com/brave/brave-browser/assets/98358127/971e5b29-2f49-42a7-ba1e-6875d9782aa1)|![image](https://github.com/brave/brave-browser/assets/98358127/8118b427-6b83-4607-8388-115f2834e0c9)|![image](https://github.com/brave/brave-browser/assets/98358127/06a75e73-7578-4ea5-bae0-b7c318c564ff)|![image](https://github.com/brave/brave-browser/assets/98358127/279b7fb8-394c-4b15-8877-4fdae9528a13)|![image](https://github.com/brave/brave-browser/assets/98358127/6fc6076c-ffb1-4e1b-9aea-ea598254421a)|![image](https://github.com/brave/brave-browser/assets/98358127/c5dd6a29-1da0-4b71-b11b-c64c54e70d37)

Page Info UI generally works (cookies subpage specifically) - PASSED

### Confirmed ability to view and manage cookies via the page-info dialog's submenus Site Information UI | Security | Site Settings | Manage cookies and site data | Cookies and site data | cleared data | reload prompt | logged out ----------|-----------|----------|----------|-----------|--------|--------|------- ![image](https://github.com/brave/brave-browser/assets/98358127/e994707d-ab44-4cd1-a2b1-5207723eff67)|![image](https://github.com/brave/brave-browser/assets/98358127/cd8ef12c-569e-4b45-b1cf-57caa502cf5f)|![image](https://github.com/brave/brave-browser/assets/98358127/72e04c9c-686b-472f-9a45-10fac7057d85)|![image](https://github.com/brave/brave-browser/assets/98358127/9ab4d6de-3c91-4fe6-a081-7f3c168ef106)|![image](https://github.com/brave/brave-browser/assets/98358127/bdbca775-c42e-4cb3-b798-2b52b7aef9a9)|![image](https://github.com/brave/brave-browser/assets/98358127/0e4078e5-6af7-4ec3-b374-34f8735bc27c)|![image](https://github.com/brave/brave-browser/assets/98358127/05df637b-ae7d-4061-abb0-155f92bd528f)|![image](https://github.com/brave/brave-browser/assets/98358127/18448089-d367-499d-8f69-55ee1d352c4a)

Tab search looks and functions as expected - (PASSED)

### Default-tab type `Show tab search button` enabled | `Show tab search button` disabled | open tabs | search -----------------------------------|------------------------------------|---------|---------- ![image](https://github.com/brave/brave-browser/assets/98358127/cc4d32e9-73ef-49bc-be4f-df93f6ed56e5)|![image](https://github.com/brave/brave-browser/assets/98358127/9235c47c-ec8f-4e9b-b340-168156718794)|![image](https://github.com/brave/brave-browser/assets/98358127/5c483c06-2c20-457e-81fb-256aaba03316)|![image](https://github.com/brave/brave-browser/assets/98358127/25bcc706-4b2e-43f2-a0c0-fb68bfcf36f9) ### Vertical-tab type `Show tab search button` enabled | `Show tab search button` disabled | open tabs | search -----------------------------------|------------------------------------|-------------------|--------------- ![image](https://github.com/brave/brave-browser/assets/98358127/5a7e8491-711f-41d9-ad42-572be2231212)|https://github.com/brave/brave-browser/issues/32919|![image](https://github.com/brave/brave-browser/assets/98358127/c50947ba-808a-43cb-90bf-a56e8897589f)|![image](https://github.com/brave/brave-browser/assets/98358127/7dbe90a9-2761-4e78-ade0-f1b91f08f111)

Shields generally work correctly (cookies blocked) - PASSED

1. installled `1.58.120` 2. launched Brave 3. opened `brave://settings/shields` 4. confirmed `Trackers & ads blocking` was set to `Standard` 5. selected `All` in `Block cookies` 6. loaded `nytimes.com` 7. clicked on the `Shields` icon in the address bar 8. clicked on `Advanced controls` 9. confirmed the corresponding cookie-blocking options below `Block all cookies` - `PASSED` ### Confirmed all cookies were blocked example | example | example ---------|---------|------- ![image](https://github.com/brave/brave-browser/assets/98358127/65a9758d-d9d1-42b6-8979-be0c46320627)|![image](https://github.com/brave/brave-browser/assets/98358127/b8e08e46-8b27-401d-978f-3f1e7887a9a2)|![image](https://github.com/brave/brave-browser/assets/98358127/b209b19b-b7bf-4fe1-bd63-c924eb1bca05) `Block cross-site cookies` - `PASSED` ### Confirmed all third-party cookies were blocked, but `aol.com` ones were allowed example | example | example ---------|---------|------- ![image](https://github.com/brave/brave-browser/assets/98358127/d4df0261-d858-49c8-ba49-24d745661f04)|![image](https://github.com/brave/brave-browser/assets/98358127/617d1925-97c4-4d24-bb4a-32d07fb91976)|![image](https://github.com/brave/brave-browser/assets/98358127/c845c3c0-a4c9-4b45-afa0-b83b4c92ad37) `Allow all cookies` - `PASSED` ### Confirmed third-party (`abcnewsgo.com`) cookies were additionally allowed example | example | example ---------|---------|------- ![image](https://github.com/brave/brave-browser/assets/98358127/ecc8cdc3-7f01-427f-be63-db06f7e85788)|![image](https://github.com/brave/brave-browser/assets/98358127/96dd3f3d-7e74-43ab-963a-4a234925cb25)|![image](https://github.com/brave/brave-browser/assets/98358127/bd079620-8b81-4a7c-b576-e4d148be3d74)

HTTP -> HTTPS upgrading works as expected - PASSED

1. installed `1.58.120` 9. launched Brave 10. opened `brave://settings/shields` 11. confirmed `Upgrade connections to HTTPS` was `Enabled` by default 12. loaded `http://upgradable.arthuredelstein.net` 13. enabled `Show Full URLs` from the top-level `View` menu ### Confirmed I was automatically upgraded to `https://upgradable.arthuredelstein.net` from `http://upgradable.arthuredelstein.net` Also confirmed clicked through the warning interstitial on `http://insecure.arthuredelstein.net`, which loaded the site. Finally, confirmed `Not secure` warning in address bar for `http://http.badssl.com` example | example | example | example ---------|----------|---------|---------- ![image](https://github.com/brave/brave-browser/assets/98358127/49f15177-0264-4804-92e3-5a232c679db1)|![image](https://github.com/brave/brave-browser/assets/98358127/d5aef8df-c89e-484f-9077-ce1f9aa26084)|![image](https://github.com/brave/brave-browser/assets/98358127/44a62cb6-b5c6-4a02-8a88-9fd60dc4172c)|![image](https://github.com/brave/brave-browser/assets/98358127/d5ba1533-c2a6-4011-b924-c17587975a41)

Vertical tabs look and work as expected - PASSED

### Steps: 1. installed `1.58.120` 2. launched Brave 3. loaded a few tabs 4. context-clicked on a tab and chose `Use Vertical Tabs` 5. confirmed vertical-tab mode 6. context-clicked on a tab and confirmed context-menu items were tab-specific 7. confirmed default prefs in `brave://settings/appearance` 8. confirmed `Show title bar` and collapsed view 9. also confirmed `Dark` mode example | example | example | example | example ---------|---------|----------|----------|--------- ![image](https://github.com/brave/brave-browser/assets/98358127/2b26a71b-9a6a-4aea-8b74-e5ce9ac4d962)|![image](https://github.com/brave/brave-browser/assets/98358127/ab9e1d73-d40e-4afa-ad81-19b83f4f9725)|![image](https://github.com/brave/brave-browser/assets/98358127/3fa0015f-90a0-4840-8b7d-514a7e72ca6f)|![image](https://github.com/brave/brave-browser/assets/98358127/c87378d8-767a-4adf-8935-54458fafee0a)|![image](https://github.com/brave/brave-browser/assets/98358127/2ec415a2-607f-4229-a79e-0ea349c1cbcf)

Password Manager has expected Brave styling - PASSED

### Steps: 1. installed `1.58.120` 22. launched Brave 23. opened `brave://settings` 24. clicked on `Autofill and passwords` 25. clicked `Add` 26. added `fill.dev`test entry 27. clicked on entry to view it 28. confirmed I was prompted for my `Touch ID` 29. confirmed password details for `fill.dev` were revealed ### Confirmed Brave styling throughout Password Manager, in both `Dark` and `Light` modes ### _Dark_ *** Didn't get Password expiry modal default | `brave://password-manager/settings` | `Add new password` | add new pw entry ---------|---------|-----------|----------------- ![image](https://github.com/brave/brave-browser/assets/98358127/d7f38df8-8d47-443f-8aee-dab213b59340)|![image](https://github.com/brave/brave-browser/assets/98358127/1b248b1c-a9fc-41ef-aed5-197da69d4a8a)|![image](https://github.com/brave/brave-browser/assets/98358127/8f232aa6-64b1-493c-8e28-0cfa0285f206)|![image](https://github.com/brave/brave-browser/assets/98358127/fd4ab415-ad50-4cbb-b7f4-e92f05eec22f) ###_Light_ - `Added password via website `save password modal` | brave://password-manager/settings | details --------|-----------|----------------- ![image](https://github.com/brave/brave-browser/assets/98358127/a858075e-d8a2-4354-8a47-6f61251396f6)|![image](https://github.com/brave/brave-browser/assets/98358127/675522ae-3f32-4bcd-8820-495f772d300b)|![image](https://github.com/brave/brave-browser/assets/98358127/6dcd890b-3c2f-4d5a-a7bd-bdd82e06ed1c)

Extensions WebUI has expected Brave styling & extensions can be installed - PASSED

### Steps: 1. installed `1.58.120` 30. launched Brave 31. opened `brave://extensions` 32. installed assorted extensions 33. disabled an extension 34. clicked `Details` on an extension 35. uninstalled an extension ### Confirmed Brave styling throughout `brave://extensions`, in both `Light` and `Dark` modes ### _Light_ example | example | example | example | example ---------|----------|---------|----------|--------- ![image](https://github.com/brave/brave-browser/assets/98358127/c1ecd73f-9e7e-48fa-92b5-e051a047b054)|![image](https://github.com/brave/brave-browser/assets/98358127/621a71e3-422a-450f-89dc-91a12b5a9457)|![image](https://github.com/brave/brave-browser/assets/98358127/c3434677-d716-4fb6-bd88-dcab6f470db3)|![image](https://github.com/brave/brave-browser/assets/98358127/a2895df4-d5ca-46f7-9dab-9735f1c055c0)|![image](https://github.com/brave/brave-browser/assets/98358127/b9b91f8f-b93f-43f7-ac7e-fccc196f73b9) example | example | example | example | example | example ---------|----------|---------|----------|---------|----------- ![image](https://github.com/brave/brave-browser/assets/98358127/d930352f-d807-48b6-9b8e-c932b9c263e7)|![image](https://github.com/brave/brave-browser/assets/98358127/c00db831-6076-4665-969c-67ba312e475e)|![image](https://github.com/brave/brave-browser/assets/98358127/72412602-7aef-4abc-9876-6f5ed2e08934)|![image](https://github.com/brave/brave-browser/assets/98358127/aa54117e-629d-4c0c-96eb-74f832f00b4a)|![image](https://github.com/brave/brave-browser/assets/98358127/abab528d-f83f-497a-a711-90f767618927)|![image](https://github.com/brave/brave-browser/assets/98358127/a7e0932c-fbe7-4a74-ae2c-d927112b2863)
kjozwiak commented 1 year ago

Labelling as QA/No & release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/32945.