brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

PDF File Type icon on Windows is pixelated #32835

Open Saikur0n opened 1 year ago

Saikur0n commented 1 year ago

Description

PDF File Type icon associated with brave browser on Windows 11 22H2 x64 is pixilated and too small if you set icon view in file explorer to medium.

Steps to Reproduce

  1. Set Brave browser as default PDF viewer app in windows default app settings.
  2. Set in file explorer icon view size to medium.
  3. Check icon that is pixilated

Actual result:

Icon of PDF file type associated with Brave browser is pixilated.

Expected result:

Icon should be clear and fit all icons sizes in file explorer as an example Microsoft Edge pdf file type icon does.

Reproduces how often:

Brave version (brave://version info)

1.57.62

Version/Channel Information:

Stable

Other Additional Information:

Miscellaneous Information:

rebron commented 1 year ago

@Saikur0n Can you provide a screenshot when you get a chance?

Saikur0n commented 1 year ago

@rebron Sure. Here it is. Compare it with Firefox icon. I think it would be better to implement icon as firefox did for pdf files. Screenshot 2023-09-10 231908 Screenshot 2023-09-10 232013

jonathansampson commented 1 month ago

Chromium recently made changes to their PDF icon configuration: https://github.com/chromium/chromium/commit/a6d8f06ca86341e008497192f7c0c90cf73113d8. @darkdh, I believe you were the last person to work on this feature. Do you think we could implement some of these changes to support a better, higher-resolution icon for PDF documents?