brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Update `Add to Brave` text on extensions web store #32841

Closed rebron closed 12 months ago

rebron commented 1 year ago

Description

At the chrome web store (preview and upcoming redesign), the Add to Brave button has regressed and shows Add to Chrome. Needs to show Add to Brave.

Steps to Reproduce

  1. Go to https://chromewebstore.google.com/detail/webchatgpt-chatgpt-with-i/lpfemeioodjbpieminkklglpmhlngfcn
  2. Notice Add to Chrome button
  3. Should say Add to Brave with our styling.

Actual result:

Screenshot 2023-09-07 at 9 56 11 AM

Expected result:

https://chrome.google.com/webstore/detail/webchatgpt-chatgpt-with-i/lpfemeioodjbpieminkklglpmhlngfcn Screenshot 2023-09-07 at 9 58 50 AM

Reproduces how often:

Easily.

Brave version (brave://version info)

chrome web store preview version

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

kjozwiak commented 12 months ago

The above requires 1.58.128 or higher for 1.58.x verification 👍

GeetaSarvadnya commented 12 months ago

Verification PASSED on

Brave | 1.58.128 Chromium: 117.0.5938.88 (Official Build) (64-bit)
-- | --
Revision | 171b8e11a776dc3f1472bc4f593caf36463b40c7
OS | Windows 10 Version 22H2 (Build 19045.3448)

Using STR from https://github.com/brave/brave-core/pull/20178#issuecomment-1724714905, visited https://chrome.google.com/webstore and selected to view the "Preview" of redesign. Compared 1.58.127 and 1.58.128 and confirmed that Brave was being used rather than Chrome as per the following:

1.58.127 1.58.128 1.58.128
image image image
LaurenWags commented 12 months ago

Verified with

Brave | 1.58.128 Chromium: 117.0.5938.88 (Official Build) (x86_64)
-- | --
Revision | 171b8e11a776dc3f1472bc4f593caf36463b40c7
OS | macOS Version 13.5.2 (Build 22G91)

Using STR from https://github.com/brave/brave-core/pull/20178#issuecomment-1724714905, visited https://chrome.google.com/webstore and selected to view the "Preview" of redesign. Compared 1.58.127 and 1.58.128 and confirmed that Brave was being used rather than Chrome as per the following:

1.58.127 1.58.128 1.58.128
0 prev1 prev2
LaurenWags commented 12 months ago

@rebron @zenparsing looks like when viewing the chrome store redesign via the "Preview" option, the "Add to Brave" button is pill shaped (see my screenshots above), not the rectangle with rounded corners as it was previously/in existing webstore (see @GeetaSarvadnya screenshots). Is this ok?

rebron commented 12 months ago

That's ok with the button shape. We just want the text to be updated.

btlechowski commented 12 months ago

Verified PASSED

Brave 1.58.128 Chromium: 117.0.5938.88 (Official Build) (64-bit)
Revision 171b8e11a776dc3f1472bc4f593caf36463b40c7
OS Linux

Verified test plan from the description

image image