search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.22k forks source link

Can’t reattach tab when using always collapsed vertical tabs #32932

Open ubalklen opened 10 months ago

ubalklen commented 10 months ago

Description

When using always collapsed vertical tabs (the ones that do not expand even if you mouse hover over them), it's possible to deattach tabs, but it's not possible to attach them back. This functionality works if tabs are not collapsed.

Steps to Reproduce

  1. Setup Brave to have collapsed vertical tabs that do not automatically expand.
  2. Deattach one tab by dragging it out.
  3. Try to reattach the tab by dragging it in back.

Actual result:

The tab will not be reattached, and some rendering issues happen in the detached tab (page stutters white).

Expected result:

The tab should be reattached to the main window.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.57.62 Chromium: 116.0.5845.180 (Official Build) (64-bit) Revision 77ae816289bb4557b7e04b3ff2e52d091ab68d66 OS Windows 10 Version 20H2 (Build 19042.2965)

Miscellaneous Information

https://github.com/brave/brave-browser/assets/42127323/8fdcf0cc-2dc6-4842-97e1-109a279ef162

ghost commented 10 months ago

For the drop to work you need to drop it in the place of the first tab, seems like it doesn't work anywhere else. So it still works, just not the way you would expect it to work.

https://github.com/brave/brave-browser/assets/122518587/5fb2b3be-5f6e-492c-9683-1c7096829fe6

So, this has to be eventually improved/fixed, so it tabs can be dropped anywhere, and it looks and feels more fluid and smooth.

@sangwoo108

thisisujjawalbhatia commented 6 months ago

hey @sangwoo108 I think the issue is not still resolved, I would Like to Help in this issue, can I try solving it?

sangwoo108 commented 6 months ago

Hi, @thisisujjawalbhatia . I'd be grateful if you could. I think tabstrip height is not fill the entire scrollable area height.

ghost commented 2 weeks ago

This is old bug is causing issues also with Close window when closing last tab, where if you don't re-attach the tabs perfectly, it will create invisible windows, so you can get dozens of invisible windows without knowing and the only way to bring them is by using Bring all tabs to this window.

I used Private windows because Private windows will show the Window count, but it happens on every type of window and when VT are set to minimized/expand on mouseover. This doesn't happen with other modes or HT since they just 'attach' the tab. So if this issue didn't exist, it wouldn't behave like that.

https://github.com/brave/brave-browser/assets/156715894/bf509f6f-14bc-4dbb-94b2-ffdcf5e67287