logging out on exit - Version 1.58.124 Chromium: 117.0.5938.62 (Official Build) (64-bit)

Climbingbow commented 1 year ago

Since yesterdays update 14/09 Version 1.58.124, I have experience issues of auto logging out on the closer of the browser. I have looked at the close or remove on exit tab and setting have remained unchanged from the previous version (see screen shot below)

steps to reproduce

open browser and log into desired site (email, youtube, etc)
Close the broswer and re open.
see that you have to log back into any of the sites visited

Actual result:

Expected result: To stay logged in on the site and have cookies kept the same as youtube is in the acceptions for logged cookies

Reproduces how often: everytime will happen every time for me

Brave version (brave://version info)

Version 1.58.124 Chromium: 117.0.5938.62 (Official Build) (64-bit)

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? not tried
Can you reproduce this issue with the nightly channel? not tried

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? no
Does the issue resolve itself when disabling Brave Rewards? no
Is the issue reproducible on the latest version of Chrome? no

namkeii commented 1 year ago

Which Operating System are you using? I had similar issues on Linux, turns out it was a problem with the gnome-keyring, somehow it wasn't able to tell which was default keyring (even when the default was properly set). I made another keyring, made it default, re-made the original keyring as default and deleted the new one. everything became fine.

Climbingbow commented 1 year ago

Which Operating System are you using? I had similar issues on Linux, turns out it was a problem with the gnome-keyring, somehow it wasn't able to tell which was default keyring (even when the default was properly set). I made another keyring, made it default, re-made the original keyring as default and deleted the new one. everything became fine.

im using win 11 22621.2283 - so dont think something similar would work for me

rebron commented 1 year ago

@Climbingbow Can you screenshot what prefs you have set in brave://settings/shields Specifically, do you have Forget me when I close this site turned on?

Climbingbow commented 1 year ago

@rebron hey, no forget me is not turned on ive also tried change should settings to see if that was the issue but no luck.

rebron commented 1 year ago

@Climbingbow It sounds like you're getting logged out of all sites but want us to specifically check on gmail and youtube? Also it looks like you have sync enabled. Is that right? I'm wondering if we have an issue with settings being synced/applied improperly from a different device.

MadhaviSeelam commented 1 year ago

@rebron Unable to reproduce the issue in Win 11 (Upgraded profile: Upgraded from 1.57.64 --> 1.58.124 New install: 1.58.124 Chromium: 117.0.5938.62

before closing the browser	relaunch the browser

Climbingbow commented 1 year ago

@rebron @MadhaviSeelam hey, i can record it on my PC to show you and its not related to sync i tried a fresh install without sync still didnt work the same as for your local storage i have done evything to use this info but still nothing

Climbingbow commented 1 year ago

@rebron okay so for some reason it has started to work keeping me logged in, but now it wont allow me to save my passwords to brave either from my mobile brave saves or the passwords linked to google chrome, sync is working an saying it has transfered my 100 plus passwords but now they just dont show up

Climbingbow commented 1 year ago

@rebron looks like the issue is linked to Chromium: 117.0.5938.62 as ive just done another fresh install after and it has gone back to [Version 1.57.64 Chromium: 116.0.5845.188 (Official Build) (64-bit) and is now working as normal, might be something to keep in mind.

rebron commented 1 year ago

@Climbingbow We're about to release an update to 1.58.127. https://github.com/brave/brave-browser/releases/tag/v1.58.127 Can you try installing that version. If you're running Windows, need to install the standalone version or BraveBrowserStandaloneSetup.exe

kjozwiak commented 1 year ago

@rebron looks like the issue is linked to Chromium: 117.0.5938.62 as ive just done another fresh install after and it has gone back to [Version 1.57.64 Chromium: 116.0.5845.188 (Official Build) (64-bit) and is now working as normal, might be something to keep in mind.

Posted all the standalone installers for Nightly, BETA & Release for x64, arm64 & x86 via https://www.reddit.com/r/brave_browser/comments/16j0ptr/comment/k0wug0d/?utm_source=share&utm_medium=web2x&context=3. Assuming you'll probably need the x64 build for the Release channel which you find/download via https://github.com/brave/brave-browser/releases/download/v1.58.127/BraveBrowserStandaloneSetup.exe. Should be able to install over your previous version. Shouldn't affect your profile/data.

Climbingbow commented 1 year ago

@rebron @kjozqiak - ive installed this update however appears to be the same issue as stated before it looks like it is linked to chromium 117.0.5938.88 as 116.xx etc worked as intended earlier after the revert of the chromium update but them automatically re updated to version 1.58.124 chromium 117.0.5938.88 and oven after updating to version [Version 1.58.127 Chromium: 117.0.5938.88 (Official Build) the issue is persisting, so i would attribute these issues to that version of chromium.

goodov commented 1 year ago

Please create a new profile in the browser and test if it works or not.

If not, please open brave://histograms/, wait for data to appear, press "Download" and attach full file here. It doesn't contain any private information.

~~Or you can search for "oscrypt" histograms and put found lines here (as a screenshot or just copy as a text)~~

Climbingbow commented 1 year ago

@goodov yeah tried it again with second profile, still no luch again looks like its to do with chromium 117.

histograms.txt

Climbingbow commented 1 year ago

@goodov update - it has now started happening with google chrome again (Chrome is up to date Version 117.0.5938.89 (Official Build) (64-bit)) it is linked directly to this build of chromium and the previous .88 . now im being auto logged out of emails and github its self but youtube stays logged in on this version so appears google logins are fine on chrome but not on brave.

goodov commented 1 year ago

@goodov yeah tried it again with second profile, still no luch again looks like its to do with chromium 117.

histograms.txt

There's an issue with Cookies database:

- Histogram: Cookie.LoadProblem recorded 2 samples, mean = 3.0 (flags = 0x41) [#]

0  ... 
3  --O                                                                       (2 = 100.0%) {0.0%}
4  ...

"3" means COOKIE_LOAD_PROBLEM_OPEN_DB

you can try to remove User Data\Default\Network\Cookies. This should force browser to recreate the Cookies database.

Climbingbow commented 1 year ago

@goodov unfortunately has not worked as you can see below in the picture i removed them restarted an its still persisting -

goodov commented 1 year ago

@goodov unfortunately has not worked as you can see below in the picture i removed them restarted an its still persisting -

Well Default is the default profile. It could be that you are using another profile path. Open brave://version and look into Profile Path: line. It should point the exact directory that's currently in use.

Climbingbow commented 1 year ago

@goodov it is the only version in use and the only path in use.

Climbingbow commented 1 year ago

@goodov i even just uninstalled deleted all broswer info from local app data an reinstalled, same issue it is because of the new chromium version.

Climbingbow commented 1 year ago

@goodov regardless of which version i use past 116 of chromium the histogram is always showing cookie issues

Climbingbow commented 1 year ago

@goodov as you can see below i reinstalled the previous version before 117, and no issues it stays logged into everything an synce works and no cookie issues

Climbingbow commented 1 year ago

@goodov until this issue is fixed or you return to 116. im just uninstalling and going back to chrome, thanks for the hlp but its not worth the hassle.

Climbingbow commented 1 year ago

@goodov the issue between chromium an cookies seems to be linked to WINRE files and being able to create a back up so it's a very small amount of people that will encounter this issues

teodor-a commented 11 months ago

I will just add that I experienced this issue as well but disabling kde-wallet and installing gnome-keyring seems to have fixed it.

sudoshindo commented 8 months ago

I will just add that I experienced this issue as well but disabling kde-wallet and installing gnome-keyring seems to have fixed it.

Do you get that annoying keyring popup every time you open Brave? I'm on Fedora, gnome-keyring is already installed, but I told brave to use the flag --password-store=basic to hide that window. I really want to fix this logout problem without enabling that popup again.

sudoshindo commented 8 months ago

Leaving a comment here just in case someone out there is having the exact same problem I did.

When I install Brave, I always edit the desktop entry by applying this change:

Exec=/usr/bin/brave-browser-stable --password-store=basic %U

This stops the keyring dialog from popping up whenever I open Brave. If you're not familiar, the keyring popup is an annoyance that is common among Linux users that use Chromium-based browsers like Brave or Vivaldi.

When I get a Brave update, the desktop entry gets reset and the --password-store=basic flag is removed.

I don't know the exact technical details behind this, but I think this "breaks" Brave's ability to store or read cookies.

I wasted a lot of time looking for answers on the subreddit and on the forum. The answer finally hit me when I decided to check my brave-browser.desktop file and I noticed that --password-store=basic was removed. When I added it back, my logins were being preserved again.

EDIT:

See my other comment for additional information.

goodov commented 8 months ago

Leaving a comment here just in case someone out there is having the exact same problem I did.

When I install Brave, I always edit the desktop entry by applying this change:

Exec=/usr/bin/brave-browser-stable --password-store=basic %U

This stops the keyring dialog from popping up whenever I open Brave. If you're not familiar, the keyring popup is an annoyance that is common among Linux users that use Chromium-based browsers like Brave or Vivaldi.

When I get a Brave update, the desktop entry gets reset and the --password-store=basic flag is removed.

I don't know the exact technical details behind this, but I think this "breaks" Brave's ability to store or read cookies.

I wasted a lot of time looking for answers on the subreddit and on the forum. The answer finally hit me when I decided to check my brave-browser.desktop file and I noticed that --password-store=basic was removed. When I added it back, my logins were being preserved again.

cc @mherrmann @wknapik for possible Brave update improvements on Linux. cc @fmarier for possible password storage/oscrypt improvements on Linux.

sudoshindo commented 8 months ago

I would like to add that the distro I am on is Fedora. But that's probably irrelevant since the distro isn't the one packaging it. @goodov thank you for calling attention to my comment.

sudoshindo commented 8 months ago

Below is the full content of my brave-browser.desktop file.

One of my setup scripts has a line in it that modifies this file.

line from my script

sudo sed -i -e 's|-stable|-stable --password-store=basic|g' /usr/share/applications/brave-browser.desktop

brave-browser.desktop

[Desktop Entry]
Version=1.0
Name=Brave Web Browser
# Only KDE 4 seems to use GenericName, so we reuse the KDE strings.
# From Ubuntu's language-pack-kde-XX-base packages, version 9.04-20090413.
GenericName=Web Browser
GenericName[ar]=متصفح الشبكة
GenericName[bg]=Уеб браузър
GenericName[ca]=Navegador web
GenericName[cs]=WWW prohlížeč
GenericName[da]=Browser
GenericName[de]=Web-Browser
GenericName[el]=Περιηγητής ιστού
GenericName[en_GB]=Web Browser
GenericName[es]=Navegador web
GenericName[et]=Veebibrauser
GenericName[fi]=WWW-selain
GenericName[fr]=Navigateur Web
GenericName[gu]=વેબ બ્રાઉઝર
GenericName[he]=דפדפן אינטרנט
GenericName[hi]=वेब ब्राउज़र
GenericName[hu]=Webböngésző
GenericName[it]=Browser Web
GenericName[ja]=ウェブブラウザ
GenericName[kn]=ಜಾಲ ವೀಕ್ಷಕ
GenericName[ko]=웹 브라우저
GenericName[lt]=Žiniatinklio naršyklė
GenericName[lv]=Tīmekļa pārlūks
GenericName[ml]=വെബ് ബ്രൌസര്‍
GenericName[mr]=वेब ब्राऊजर
GenericName[nb]=Nettleser
GenericName[nl]=Webbrowser
GenericName[pl]=Przeglądarka WWW
GenericName[pt]=Navegador Web
GenericName[pt_BR]=Navegador da Internet
GenericName[ro]=Navigator de Internet
GenericName[ru]=Веб-браузер
GenericName[sl]=Spletni brskalnik
GenericName[sv]=Webbläsare
GenericName[ta]=இணைய உலாவி
GenericName[th]=เว็บเบราว์เซอร์
GenericName[tr]=Web Tarayıcı
GenericName[uk]=Навігатор Тенет
GenericName[zh_CN]=网页浏览器
GenericName[zh_HK]=網頁瀏覽器
GenericName[zh_TW]=網頁瀏覽器
# Not translated in KDE, from Epiphany 2.26.1-0ubuntu1.
GenericName[bn]=ওয়েব ব্রাউজার
GenericName[fil]=Web Browser
GenericName[hr]=Web preglednik
GenericName[id]=Browser Web
GenericName[or]=ଓ୍ବେବ ବ୍ରାଉଜର
GenericName[sk]=WWW prehliadač
GenericName[sr]=Интернет прегледник
GenericName[te]=మహాతల అన్వేషి
GenericName[vi]=Bộ duyệt Web
# Gnome and KDE 3 uses Comment.
Comment=Access the Internet
Comment[ar]=الدخول إلى الإنترنت
Comment[bg]=Достъп до интернет
Comment[bn]=ইন্টারনেটটি অ্যাক্সেস করুন
Comment[ca]=Accedeix a Internet
Comment[cs]=Přístup k internetu
Comment[da]=Få adgang til internettet
Comment[de]=Internetzugriff
Comment[el]=Πρόσβαση στο Διαδίκτυο
Comment[en_GB]=Access the Internet
Comment[es]=Accede a Internet.
Comment[et]=Pääs Internetti
Comment[fi]=Käytä internetiä
Comment[fil]=I-access ang Internet
Comment[fr]=Accéder à Internet
Comment[gu]=ઇંટરનેટ ઍક્સેસ કરો
Comment[he]=גישה אל האינטרנט
Comment[hi]=इंटरनेट तक पहुंच स्थापित करें
Comment[hr]=Pristup Internetu
Comment[hu]=Internetelérés
Comment[id]=Akses Internet
Comment[it]=Accesso a Internet
Comment[ja]=インターネットにアクセス
Comment[kn]=ಇಂಟರ್ನೆಟ್ ಅನ್ನು ಪ್ರವೇಶಿಸಿ
Comment[ko]=인터넷 연결
Comment[lt]=Interneto prieiga
Comment[lv]=Piekļūt internetam
Comment[ml]=ഇന്റര്‍‌നെറ്റ് ആക്‌സസ് ചെയ്യുക
Comment[mr]=इंटरनेटमध्ये प्रवेश करा
Comment[nb]=Gå til Internett
Comment[nl]=Verbinding maken met internet
Comment[or]=ଇଣ୍ଟର୍ନେଟ୍ ପ୍ରବେଶ କରନ୍ତୁ
Comment[pl]=Skorzystaj z internetu
Comment[pt]=Aceder à Internet
Comment[pt_BR]=Acessar a internet
Comment[ro]=Accesaţi Internetul
Comment[ru]=Доступ в Интернет
Comment[sk]=Prístup do siete Internet
Comment[sl]=Dostop do interneta
Comment[sr]=Приступите Интернету
Comment[sv]=Gå ut på Internet
Comment[ta]=இணையத்தை அணுகுதல்
Comment[te]=ఇంటర్నెట్‌ను ఆక్సెస్ చెయ్యండి
Comment[th]=เข้าถึงอินเทอร์เน็ต
Comment[tr]=İnternet'e erişin
Comment[uk]=Доступ до Інтернету
Comment[vi]=Truy cập Internet
Comment[zh_CN]=访问互联网
Comment[zh_HK]=連線到網際網路
Comment[zh_TW]=連線到網際網路
Exec=/usr/bin/brave-browser-stable --password-store=basic %U
StartupNotify=true
Terminal=false
Icon=brave-browser
Type=Application
Categories=Network;WebBrowser;
MimeType=application/pdf;application/rdf+xml;application/rss+xml;application/xhtml+xml;application/xhtml_xml;application/xml;image/gif;image/jpeg;image/png;image/webp;text/html;text/xml;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ipfs;x-scheme-handler/ipns;
Actions=new-window;new-private-window;

[Desktop Action new-window]
Name=New Window
Name[am]=አዲስ መስኮት
Name[ar]=نافذة جديدة
Name[bg]=Нов прозорец
Name[bn]=নতুন উইন্ডো
Name[ca]=Finestra nova
Name[cs]=Nové okno
Name[da]=Nyt vindue
Name[de]=Neues Fenster
Name[el]=Νέο Παράθυρο
Name[en_GB]=New Window
Name[es]=Nueva ventana
Name[et]=Uus aken
Name[fa]=پنجره جدید
Name[fi]=Uusi ikkuna
Name[fil]=New Window
Name[fr]=Nouvelle fenêtre
Name[gu]=નવી વિંડો
Name[hi]=नई विंडो
Name[hr]=Novi prozor
Name[hu]=Új ablak
Name[id]=Jendela Baru
Name[it]=Nuova finestra
Name[iw]=חלון חדש
Name[ja]=新規ウインドウ
Name[kn]=ಹೊಸ ವಿಂಡೊ
Name[ko]=새 창
Name[lt]=Naujas langas
Name[lv]=Jauns logs
Name[ml]=പുതിയ വിന്‍ഡോ
Name[mr]=नवीन विंडो
Name[nl]=Nieuw venster
Name[no]=Nytt vindu
Name[pl]=Nowe okno
Name[pt]=Nova janela
Name[pt_BR]=Nova janela
Name[ro]=Fereastră nouă
Name[ru]=Новое окно
Name[sk]=Nové okno
Name[sl]=Novo okno
Name[sr]=Нови прозор
Name[sv]=Nytt fönster
Name[sw]=Dirisha Jipya
Name[ta]=புதிய சாளரம்
Name[te]=క్రొత్త విండో
Name[th]=หน้าต่างใหม่
Name[tr]=Yeni Pencere
Name[uk]=Нове вікно
Name[vi]=Cửa sổ Mới
Name[zh_CN]=新建窗口
Name[zh_TW]=開新視窗
Exec=/usr/bin/brave-browser-stable --password-store=basic

[Desktop Action new-private-window]
Name=New Incognito Window
Name[ar]=نافذة جديدة للتصفح المتخفي
Name[bg]=Нов прозорец „инкогнито“
Name[bn]=নতুন ছদ্মবেশী উইন্ডো
Name[ca]=Finestra d'incògnit nova
Name[cs]=Nové anonymní okno
Name[da]=Nyt inkognitovindue
Name[de]=Neues Inkognito-Fenster
Name[el]=Νέο παράθυρο για ανώνυμη περιήγηση
Name[en_GB]=New Incognito window
Name[es]=Nueva ventana de incógnito
Name[et]=Uus inkognito aken
Name[fa]=پنجره جدید حالت ناشناس
Name[fi]=Uusi incognito-ikkuna
Name[fil]=Bagong Incognito window
Name[fr]=Nouvelle fenêtre de navigation privée
Name[gu]=નવી છુપી વિંડો
Name[hi]=नई गुप्त विंडो
Name[hr]=Novi anoniman prozor
Name[hu]=Új Inkognitóablak
Name[id]=Jendela Penyamaran baru
Name[it]=Nuova finestra di navigazione in incognito
Name[iw]=חלון חדש לגלישה בסתר
Name[ja]=新しいシークレット ウィンドウ
Name[kn]=ಹೊಸ ಅಜ್ಞಾತ ವಿಂಡೋ
Name[ko]=새 시크릿 창
Name[lt]=Naujas inkognito langas
Name[lv]=Jauns inkognito režīma logs
Name[ml]=പുതിയ വേഷ പ്രച്ഛന്ന വിന്‍ഡോ
Name[mr]=नवीन गुप्त विंडो
Name[nl]=Nieuw incognitovenster
Name[no]=Nytt inkognitovindu
Name[pl]=Nowe okno incognito
Name[pt]=Nova janela de navegação anónima
Name[pt_BR]=Nova janela anônima
Name[ro]=Fereastră nouă incognito
Name[ru]=Новое окно в режиме инкогнито
Name[sk]=Nové okno inkognito
Name[sl]=Novo okno brez beleženja zgodovine
Name[sr]=Нови прозор за прегледање без архивирања
Name[sv]=Nytt inkognitofönster
Name[ta]=புதிய மறைநிலைச் சாளரம்
Name[te]=క్రొత్త అజ్ఞాత విండో
Name[th]=หน้าต่างใหม่ที่ไม่ระบุตัวตน
Name[tr]=Yeni Gizli pencere
Name[uk]=Нове вікно в режимі анонімного перегляду
Name[vi]=Cửa sổ ẩn danh mới
Name[zh_CN]=新建隐身窗口
Name[zh_TW]=新增無痕式視窗
Exec=/usr/bin/brave-browser-stable --password-store=basic --incognito

sudoshindo commented 2 months ago

@goodov @rebron @fmarier updates?

brave / brave-browser