Manual test run on macOS (arm64) for Tor 0.4.8.6 - Release #1

GeetaSarvadnya commented 1 year ago

Ventura 13.x

Tor Client Updater

[x] For development go-update-server. Run brave-browser with --user-data-dir=component-dev --use-dev-goupdater-url (These flags are only available in v1.7.x). Once the crx is pushed to production run without these flags.
[x] Navigate to brave://components and verify Tor Client Updater (OS) is updated successfully.
[x] Open New Private Window with Tor and confirm that it starts without any errors.
- [x] Navigate to check.torproject.org and verify that tor is working successfully.
- [x] Navigate to brave.com and http://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ to check if the sites work correctly.
[x] Load brave.com and mail.protonmail.com in a regular Window/Tab and ensure that clicking the Tor button in the URL bar correctly launches a Tor window and opens the appropriate .onion website.

MacOS

[x] Navigate to /Users/<user>/Library/Application Support/BraveSoftware/Brave-Browser-<channel>/cldoidikboihgcjfkhdeidbpclkineef/<version>
[x] Run codesign -vvvv tor-<version-tor>-darwin-brave-<version-brave> to confirm codesign is valid
[x] For MacOS Catalina (10.15+) - Run spctl -a -vv -t install tor-<version-tor>-darwin-brave-<version-brave> to verify that the binary is notarized.

Ventura 13.5.2

Tor Client Updater

[x] For development go-update-server. Run brave-browser with --user-data-dir=component-dev --use-dev-goupdater-url (These flags are only available in v1.7.x). Once the crx is pushed to production run without these flags.
[x] Navigate to brave://components and verify Tor Client Updater (OS) is updated successfully.
[x] Open New Private Window with Tor and confirm that it starts without any errors.
- [x] Navigate to check.torproject.org and verify that tor is working successfully.
- [x] Navigate to brave.com and http://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ to check if the sites work correctly.
[x] Load brave.com and mail.protonmail.com in a regular Window/Tab and ensure that clicking the Tor button in the URL bar correctly launches a Tor window and opens the appropriate .onion website.

MacOS

[x] Navigate to /Users/<user>/Library/Application Support/BraveSoftware/Brave-Browser-<channel>/cldoidikboihgcjfkhdeidbpclkineef/<version>
[x] Run codesign -vvvv tor-<version-tor>-darwin-brave-<version-brave> to confirm codesign is valid
[x] For MacOS Catalina (10.15+) - Run spctl -a -vv -t install tor-<version-tor>-darwin-brave-<version-brave> to verify that the binary is notarized.

LaurenWags commented 1 year ago

Verified on macOS 13.x Ventura with

Brave | 1.58.127 Chromium: 117.0.5938.88 (Official Build) (arm64)
-- | --
Revision | ed4ee11d4f6add8e0885cfab17943837d3d426c1
OS | macOS Version 13.5.2 (Build 22G91)

Confirmed that the correct Tor component was being downloaded via --use-dev-goupdater-url:

Confirmed that the Tor component was started when launching Tor and ensured Tor 0.4.8.6 was being used. Compared against torproject.org/download/tor dashboard.

Sep 19 11:14:53.997 [notice] Tor 0.4.8.6 running on Darwin with Libevent 2.1.12-stable, OpenSSL 1.1.1w, Zlib 1.3, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.

Confirmed that you can open the following domains in a Tor window without issues:

brave.com
https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
check.torproject.org (ensured that hard refreshing gets a new circuit/IP)

Confirmed the following sites opened via “Open in Tor” button from normal window and navigated to .onion URL in a Tor window:

Confirmed that codesign is valid:

laurenwags@Laurens-M1 1.0.67 % codesign -vvv tor-0.4.8.6-darwin-brave-0 
tor-0.4.8.6-darwin-brave-0: valid on disk
tor-0.4.8.6-darwin-brave-0: satisfies its Designated Requirement

Confirmed that the binary is notarized:

laurenwags@Laurens-M1 1.0.67 % spctl -a -vv -t install tor-0.4.8.6-darwin-brave-0 
tor-0.4.8.6-darwin-brave-0: accepted
source=Notarized Developer ID
origin=Developer ID Application: Brave Software, Inc. (KL8N8XSYF4)

stephendonner commented 1 year ago

Verification `PASSED` using

Brave | 1.58.127 Chromium: 117.0.5938.88 (Official Build) (arm64)
-- | --
Revision | ed4ee11d4f6add8e0885cfab17943837d3d426c1
OS | macOS Version 13.5.2 (Build 22G91)

Confirmed the correct Tor component was being downloaded via --use-dev-goupdater-url

Confirmed that the Tor component was started when launching Tor and ensured Tor 0.4.8.6 was being used:

Sep 19 11:29:00.329 [notice] Tor 0.4.8.6 running on Darwin with Libevent 2.1.12-stable, OpenSSL 1.1.1w, Zlib 1.3, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.

Confirmed against torproject.org/download/tor

Confirmed you can open the following domains in a Tor window without issues:

brave.com
search.brave.com
check.torproject.org (ensured that hard-refreshing gets a new circuit/IP)

Confirmed the following sites opened via Open in Tor button from normal window and navigated to .onion URL in a Tor window:

Confirmed that codesign is valid:

stephendonner@Stephens-MBP-3 MacOS % codesign -vvv /Users/stephendonner/Library/Application\ Support/BraveSoftware/Brave-Browser/cldoidikboihgcjfkhdeidbpclkineef/1.0.67/tor-0.4.8.6-darwin-brave-0
/Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/cldoidikboihgcjfkhdeidbpclkineef/1.0.67/tor-0.4.8.6-darwin-brave-0: valid on disk
/Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/cldoidikboihgcjfkhdeidbpclkineef/1.0.67/tor-0.4.8.6-darwin-brave-0: satisfies its Designated Requirement

Confirmed that the binary is notarized:

stephendonner@Stephens-MBP-3 MacOS % spctl -a -vv -t install /Users/stephendonner/Library/Application\ Support/BraveSoftware/Brave-Browser/cldoidikboihgcjfkhdeidbpclkineef/1.0.67/tor-0.4.8.6-darwin-brave-0
/Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/cldoidikboihgcjfkhdeidbpclkineef/1.0.67/tor-0.4.8.6-darwin-brave-0: accepted
source=Notarized Developer ID
origin=Developer ID Application: Brave Software, Inc. (KL8N8XSYF4)

brave / brave-browser