C118 - brave://version has different font

LaurenWags commented 1 year ago

Description

C118 brave://version has a different font than previous version with C117

Mentioned via https://bravesoftware.slack.com/archives/CU5UXM3EC/p1695654321593069?thread_ts=1695467144.813629&cid=CU5UXM3EC

Steps to Reproduce

Visit brave://version
Look at font

Actual result:

1.60.x wth C118 vs 1.58 with C117

Expected result:

same font as 1.60.x with C117

Reproduces how often:

easily

Brave version (brave://version info)

1.60.47 with C118 from https://bravesoftware.slack.com/archives/CU5UXM3EC/p1695467161279059?thread_ts=1695467144.813629&cid=CU5UXM3EC

Version/Channel Information:

Can you reproduce this issue with the current release? n/a
Can you reproduce this issue with the beta channel? n/a
Can you reproduce this issue with the nightly channel? only with PR build so far

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @emerick

MadhaviSeelam commented 1 year ago

Not reproducible in Win 11 x64

1.60.47	1.58.131

LaurenWags commented 12 months ago

Noticed that under brave://settings/fonts, the Fixed-width font is different between C118 and C117. Seems related to this?

1.58.x with C117	1.59.x with C118

cc @emerick @rebron

ref: https://bravesoftware.slack.com/archives/CKNHM4RTK/p1696343828168429

rebron commented 12 months ago

cc: @aguscruiz @jenn-rhim @bradleyrichter reference in Chrome https://source.chromium.org/chromium/chromium/src/+/47c2f9b983ba64c50ab44a638b1ccef12398d61e

aguscruiz commented 12 months ago

Weird they changed to Menlo seeing that it's not even used a system default anymore in favor of SF Mono (And other Windows counterparts)

From Wikipedia: Menlo was replaced as the system monospaced font in Mac OS X 10.11 El Capitan in September 2015, with a new Apple-made monospaced font called SF Mono, a monospaced variant of the San Francisco family of fonts that Apple has created as part of its corporate identity. It is not installed as a user-accessible typeface by default, although it is included with and used by Terminal or Xcode.

https://en.wikipedia.org/wiki/Menlo_(typeface)

brave / brave-browser