twitch tipping scenarios not currently considered

LaurenWags commented 5 years ago

Description

There are a couple of tipping scenarios for twitch that may not be acting in the desired manner. We may want to consider handling these scenarios.

Scenario 1: If you navigate to a channel (such as https://www.twitch.tv/neoness007) and you see that the channel is “hosting” another streamer (ex. shanksy), the panel shows neoness007 publisher info, but your a-c table records the person being hosted (in this case, shanksy). Per discussion in slack this is currently expected. However, this feels odd though because if you went to tip, you’d be tipping neoness007, not shanksy who is currently streaming. @jasonrsadler provided this info: This was one caveat with a channel hosting another: The panel would show the channel but ac would record who was being hosted (if different) when coming in from processMedia.

Scenario 2: Similar to scenario 1 - if you navigate to twitch.tv home page, panel shows twitch.tv, but your a-c table will show the info for the publisher currently streaming. so if you went to tip from twitch.tv home page, you’d be tipping twitch, not the pub who is streaming.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

Does the issue resolve itself when disabling Brave Shields? n/a
Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

jonathansampson commented 5 years ago

Another scenario involving Twitch's new Squad Mode streaming. A few suggestions:

Tip the primary window (clicking a secondary stream makes it the primary)
Split a tip up between all streamers (Could result in unnaturally small amounts of BAT)
Tip panel shows streamers icons, and lets you choose which one(s) should receive the tip.

NejcZdovc commented 5 years ago

for simplicity I would go with first one (based on url)

jonathansampson commented 5 years ago

@NejcZdovc That works, but it's worth noting that the URL doesn't change even if you choose a different streamer to focus on.

brave / brave-browser