search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

Brave VPN is in an unconnected state in an upgrade profile #33271

Open GeetaSarvadnya opened 1 year ago

GeetaSarvadnya commented 1 year ago

Description

Found while testing https://github.com/brave/brave-browser/issues/32280 Brave VPN is in an unconnected state in an upgrade profile

Steps to Reproduce

  1. Clean profile 1.58.116
  2. Enable Brave VPN (via staging using account.bravesoftware.com)
  3. Brave VPN is in connected state in 1.58.116
  4. Install 1.59.101 on top of 1.58.x
  5. Open brave://settings/help and click on Relaunch button
  6. Confirmed that brave is updated to 1.59.101
  7. Brave VPN is NOT in connected state in 1.59.101

Important: If we auto upgrade the profile to 1.59.x the issue is NOT reproducible, the issue is reproducible only when we install any specific 1.59.x version on top of 1.58.x

Actual result:

Brave VPN is in an unconnected state in an upgrade profile

1.58,116 1.59.101
image (1) image

Expected result:

Brave VPN should be in a connected state in an upgrade profile

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.59.101 Chromium: 117.0.5938.92 (Official Build) beta (64-bit)
Revision 81840f55490b042e3c7a75e0cba633580ed5a1b6
OS Windows 11 Version 22H2 (Build 22621.2283)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc: @brave/qa-team @stephendonner @MadhaviSeelam @spylogsster

GeetaSarvadnya commented 1 year ago

cc: @bsclifton @simonhong

spylogsster commented 1 year ago

We need to stop vpn and re-register the vpn service if wireguard is in use at the time of upgrade. We discussed this with @bsclifton and preferred that the installer should throw an error if vpn is connected. We want to give the user the option to manually disable vpn before upgrading.