Upgrade from Chromium 118 to Chromium 119

[emerick]

Upgrade from Chromium 118 to Chromium 119

https://chromium.googlesource.com/chromium/src/+log/118.0.5993.21..119.0.6020.3/?pretty=fuller&n=10000

QA tests: This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Full sync regression test, specifically history sync
• Default search engine and and Brave Search
• Brave VPN
• brave://settings in general, but also brave://settings/cookies specifically
• Vertical tabs
• File downloads
• Autocomplete
• URL bar functionality, icons, etc.
• Tab search button

Please see/run through https://github.com/brave/brave-core/pull/20329#issue-1917760373 for the Sync cases that @AlexeyBarabash provided.

iOS Affected areas:

• No major changes to call out here.

Android Affected areas:

• NTP layout (double there is no regression on NTP)
• Search engines (make sure it is properly set for private tabs)
• Brave shields and privacy settings (double check now regression in this section)
• Web search (double check it works as intended)
• Only open links in current tab group (double check it still works as intended)
• Brave search promo (double check there is no regression in showing it)
• Sync (double check it generally works)

Please see/run through https://github.com/brave/brave-core/pull/20329#issue-1917760373 for the Sync cases that @AlexeyBarabash provided.

[hffvld]

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B2.230922.010 release-keys]
Brave build: 1.61.47 
Chromium: 119.0.6045.33 (Official Build) canary (64-bit) 
Revision: 63aeef007c8d6fa051b21b4c8cdc9667fb16b389

Filled issue #33882 which is a C119 related issue.

1	2	3
1	2	3
1	2	3
1	2	3
1	2	3
1	2	3
1	2	3
1	2	3
1	2	3

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.61.50 Chromium: 119.0.6045.33 (Official Build) nightly (64-bit)
-- | --
Revision | af3c0e1d93ee4b2e9b98a4e4cf3e7fb2a85442ee
OS | Windows 10 Version 22H2 (Build 19045.3570)

• Encountered https://github.com/brave/brave-browser/issues/24381
• Encountered https://github.com/brave/brave-browser/issues/33886
• Logged https://github.com/brave/brave-browser/issues/33907
• Logged https://github.com/brave/brave-browser/issues/33947

Default search engine and and Brave Search_PASSED

### IN (India) locale

Clean Profile - PASSED

* ensured that `Brave` was selected as the default for both Normal/Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was selected as the default via `brave://settings/searchEngines` **`Example`** | **`Example`** | **`Example`** ---------------|-----------------|---------------  |  | 

Updated Profile (Google/Google - default SE) - PASSED

* installed `1.48.x` * ensured that `Google` was the default SE selected under `brave://settings/search` for Normal Windows * changed `Brave` to `Google` for default SE for Private Windows * updated to `1.61.x` and ensured that `Google` is still the default SE in both Normal and Private windows SE * ensured that it wasn't replaced by `Brave` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows **`1.48.164 Chromium: 110.0.5481.100`** | **`1.61.50 Chromium: 119.0.6045.33`** --------------------------------------------|----------------------------------------------  | 

Updated Profile (Startpage/DDG - modified SE) - PASSED

* installed `1.48.x` * Selected `Startpage` as the default SE selected under `brave://settings/search` for Normal Windows * Change `Brave` to `DDG` as the default SE for Private Windows * updated to `1.61.x` and ensured that previously selected SE is still the default for both Normal and Private windows * Normal Windows = `Startpage` and Private Windows = `DDG` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was the first engine via the list under `brave://settings/searchEngines` **`1.48.164 Chromium: 110.0.5481.100`** | **`1.61.50 Chromium: 119.0.6045.33`** --------------------------------------------|----------------------------------------------  | 

### FI (Finland) locale

Clean Profile - PASSED

* ensured that `Google` was selected as the default for Normal windows and `Brave` was selected as the default for Private windows via `brave://settings/search` * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Google` was selected as the default via `brave://settings/searchEngines` and `Brave` was listed first **`Example`** | **`Example`** | **`Example`** | **`Example`** | **`Example`** ---------------|-----------------|---------------|---------------|---------------  |  |  |  | 

Updated Profile (Google/Google - default SE) - PASSED

* installed `1.48.x` * ensured that `Google` was the default SE selected under `brave://settings/search` for normal windows * changed default SE for Private windows from `Brave` to `Google` * updated to `1.61.x` and ensured that `Google` is still the default SE in both Normal and Private window SE * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Normal` windows * ensured that `Brave` was the first engine via the drop down list under `brave://settings/search` for `Private` windows * ensured that `Brave` was the first engine via the list under `brave://settings/searchEngines` **`1.48.164 Chromium: 110.0.5481.100`** | **`1.61.50 Chromium: 119.0.6045.33`** --------------------------------------------|----------------------------------------------  | 

Brave VPN_PASSED

1. Clean profile `1.61.50` 2. Open brave://settings/system 3. Confirmed `Use wireguard protocol in Brave VPN` toggle is enabled by default 4. Purchased and connected a vpn via account.bravesoftware.com 5. Confirmed Brave VPN Wireguard is connected successfully - Confirmed that the `BraveVpnBeta Wireguard` service is running in Processes tab in task manager - Confirmed `brave_vpn_wireguard_service.exe` running under Details tab in task manager 6. Confirmed that VPN region can be switched to othe regions successfully 7. Confirmed that `ipleak.net` displays the correct IP for the switched VPN region 8. Confirmed that VPN can be disconnected and re-connected without any issues Example | Example | Example | Example | Example | Example | Example ----------|-----------|----------|----------|------------|----------|------------  |  |  |  |  |  | 

brave://settings in general, but also brave://settings/cookies specifically_PASSED

- Confirmed that brave://settings testing is covered in `Settings comparison` section **_Update the cookies setting_** 1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A 2. Go to global shield settings and change the cookies setting to `Block all` 3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero `0` 4. Open brave://settings/cookies and ensure that the `Block cookies` settings is enabled due to step 2 5. Go to brave://settings/cookies and select `Allow all cookies` 6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is `some value` 9. Go to global shield settings and ensure that the cookies setting is set to `Disabled` due to step 5 Case 1: 1. Clean profile `1.61.50 - CR 119` 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block cross site cookies` to `Block all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are reatined Case 2: 1. Continuation of case 1 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Block all cookies` to `Allow all cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are reatined Case 3: 1. Continuation of case 2 2. Open a site 3. Click on the site shield settings 4. Change the trackers and ad blocking settings from `Allow all cookies` to `Block cross site cookies` 5. Restart the browser 6. Open the site shield settings, confirmed updated cookies settings are reatined

Vertical tabs_PASSED

**_Change the default theme and enable vertical tabs:_** - Change the theme via brave://settings/appearance and enable vertical tabs - Confirmed that Brave didn't crash - Changed various themes and ensured brave didn't crash  **_General testing on Vertical tabs :_** - Confirmed that `Use vertical tabs` settings is added in `Tabs` section under brave://settings/appearance - Confirmed that tabs orientation changed to vertical when user toggle the `Use vertical tabs` settings via brave://settings/appearance - Verified that sites can be added to vertical tab by clicking on the `+ New tab` or `Ctrl+T` - Right click on any site added in the vertical tab shows the site `context menu` options - Verified that `reading list` and `vertical tabs` cab be enabled at the same time - Right click on any site and select `Add tab to reading list` context menu option and ensured site can be added to the reading list - Right click on any site and select `Add a tab to new group` and ensured that the selected site can be added to new tab group - Right click on the sites in vertical tab and select `Add a tab to new group` and then created tab (e.g `News` which I have created in my testing) group and ensured that sites got added to the tab group `News` - Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown - Right click on any site in vertical tab and select `Move tab to another window` and ensured that tab is opened in an new window - When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine - Right click on any site in vertical tab and select `Reload` context menu option and ensured site gets reloaded/refreshed - Right click on any site in vertical tab and select `Duplicate` context menu option and ensured duplicate tab got added to the tab group - Right click on any site in vertical tab and select `Pin` context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured `Unpin` option is shown - Ensured that pinned site can be unpinned by clicking on the `Unpin` option - Right click on any YT site in vertical tab and select `mute` context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode. - Ensured that YT videos can be unmuted by clicking on the `Unmute` option - Ensured that `Close`, `Close other tabs`, `Close tabs to the right` and `Reopen closed tabs` works as expected - Ensured that the tab `Bookmarls all` context menu works as expected - Ensured that tabs can be drag and drop in an vertical tab - Ensured that vertical tab cab be collapsed/expanded, when `vertical tabs` is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example --|---|--|--|--|--|--|--|--|--|--|--|--|--|--|--|--|--|--  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  `Toggle "Use Vertical tabs" settings ON/OFF` - Confirmed that `Use Vertical tabs` toggle ON/OFF works as expected - Confirmed that once the `Use Vertical tabs` toggle is OFF, tabs are shown in horizontal view - Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost - Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost Example | Example | Example ---------|------------|---------  |  |  `Show title bar` - Confirmed that title bar is shown when the `Show title bar` toggle is turned ON - Confirmed that title bar is NOT shown when the `Show title bar` toggle is turned OFF Example | Example | Example | Example ----------|-----------|----------|---------  |  |  |  `Float on mouseover` and `Tab hover mode` - Confirmed that `Float on mouseover` settings is enabled by default under brave://settings/appearance - When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode - Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings `Float on mouseover` is unchecked - Confirmed that `Card` Tab hover mode settings works as expected on vertical tabs - Confirmed that `Card with preview` Tab hover mode settings works as expected on vertical tabs - Confirmed that `Tooltip` Tab hover mode settings works as expected on vertical tabs  `Show tab search button` - Confirmed that `Show tab search button` settings works as expected with Vertical tabs enable - Confirmed that able to search particula tabs using search tab option 

File downloads_PASSED

- Confirmed download functionality works as expected - Confirmed the progress-meter color is "blurple" and matches the download button - Confirmed toolbar download button style is as expected - Confirmed that a tiny popup is auto opened when download completes - Confirmed that `Shown in folder` opens up the download file path - Confirmed that a file can be downloaded via PT and TOR tabs as well Example | Example | Example | Example ----------|-----------|-----------|---------  |  |  | 

Autocomplete_PASSED

1. Confirm that the `Show autocomplete suggestions in address bar` switch is enabled by default under brave://settings/appearance 2. Confirm that autocomplete suggestion checkboxes `Top sites`, `Browsing Hostory`, `Bookmarks` and `Leo AI Assistant` are enabled by default 3. Open a new tab and enter the string `Buzz` in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list 4. Go to brave://settings/appearance and uncheck/disable the checkbox `Top sites` 5. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled 6. Open the buzzfeed.com in any tab 7. Keep the `Top sites` still disabled/unchecked 10. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 6 and autocomplete suggestion is picked up from the `Browsing History` list 11. Go to brave://settings/appearance and uncheck/disable the checkbox `Browsing History` and keep Top sites as it is in step 7 12. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` and `browsing history` toggles are disabled/unchecked 13. Bookmark the site buzzfeed.com which is already opened in step 6 and close the tab 14. Keep the brave://settings/appearance setting as it is 15. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the `Bookmarks` list 16. Go to brave://settings/appearance and uncheck `Bookmarks` (all the 3 settings checkboxes are unchecked in this step) 17. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `top sites` , `browsing history` and `bookmarks` toggles are disabled/unchecked 18. Confirm that only `Ask Leo` option is shown in the autocomplete suggestion 19. Enter the search string "What is WHO?" and select Ask leo suggetion and hit enter and click on "Accept and begin" 20. Confirm that Brave AI provides the correct answer for the question "What is WHO?" 21. Go to brave://settings/appearance setting and disable "Leo AI Assistant" checkbox 22. Confirm that all the checkboxes are unchecked in this step 23. Open a new tab and seach with string "Buzz" 24. Confirmed that no seach suggestions display for the seach string as all the autocomplete suggestion checkboxes are disabled 25. Enable alll the 4 switches under `Show autocomplete suggestions in address bar` main switch 26. Disable the main switch `Show autocomplete suggestions in address bar` 27. Open a new tab and enter the string `Buzz` in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as `Show autocomplete suggestions in address bar` main switch is OFF Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example --|--|--|--|--|--|--|--|--|--|--|--|--|--  |  |  |  |  |  |  |  |  |  |  |  |  | 

URL bar functionality, icons, etc_PASSED

- Confirmed that info bar color looks as expected in light theme - Confirmed that info bar color looks as expected in Dark theme - Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected - Confirmed that the icons in the URL bar works as expected Light theme | Dark theme --------------|---------------  | 

Tab search button_PASSED

`Show tab search button` - Confirmed that `Show tab search button` settings works as expected with Horitonal tabs orientation - Confirmed that able to search particula tabs using search tab option Example | Example ----------|----------  | 

---

Settings comparison

Settings comparison_PASSED

- Add/Edit bookmarks settings popup modal is inherited from CR119, this dialog may be reverted via https://github.com/brave/brave-browser/issues/33886, please refer slack thread for more info https://bravesoftware.slack.com/archives/CU5UXM3EC/p1698216653317629?thread_ts=1697655851.387759&cid=CU5UXM3EC  - Updated the brave://settings/appearance section titles for better grouping via https://github.com/brave/brave-browser/issues/33128

[Uni-verse]

Verified on Samsung Galaxy Tab S7 using version:

Brave   1.61.51 Chromium: 119.0.6045.33 (Official Build) canary (64-bit) 
Revision    aa3f8a13e51b43e6a9110371d923d87c95342164
OS  Android 13; Build/TP1A.220624.014; 33; REL

NTP Layout

Default | Opt in Card | News Enabled, back to top | NTP without SI | disabling SI -|-|-|-|-  |  |  |  |  Disabling bg img | Without bg img | NTP without stats | Disabling stats via settings | Disabling all NTP elements in settings -|-|-|-|-  |  |  |  |  | 

Search Engines + Web Search

Example | Example | Example | Example -|-|-|-  |  |  | 

Brave Shields and Privacy

Example | Example | Example -|-|-  |  | 

Tab Groups

- Ensured only opening links in current tab group works and has not regressed. - Ensured setting is shown by default with enabled state 

Sync

- Ensured sync chain flow is working - Ensured bookmarks are synced - Ensured open tabs is synced - Ensured passwords are synced - Ensured password PIN is working - Ensured deleting sync chain is successful Example | Example | Example -|-|-  |  | 

[kjozwiak]

The above requires 1.60.105 or higher for 1.60.x verification 👍

[kjozwiak]

Labelling as QA/No & release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/33940 👍