brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

Upgrade from Chromium 119 to Chromium 120. #33471

Closed mkarolin closed 9 months ago

mkarolin commented 11 months ago

Upgrade from Chromium 119 to Chromium 120

https://chromium.googlesource.com/chromium/src/+log/119.0.6045.7..120.0.6048.1/?pretty=fuller&n=10000

QA tests: This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

iOS Affected areas: TBD

Android Affected areas:

GeetaSarvadnya commented 9 months ago

Verification PASSED on

Brave | 1.62.86 Chromium: 120.0.6099.35 (Official Build) nightly (64-bit)
-- | --
Revision | f248c65a74007536fb36959f92fc01fcb752e5fc
OS | Windows 10 Version 22H2 (Build 19045.3693)
Tabs bar context menus look correctly (on a tab and on empty space)_PASSED - Confirmed that Tabs bar context menus are shown correctly - Confirmed that Tabs bar context menus works fine Example | Example ----------|---------- ![image](https://github.com/brave/brave-browser/assets/38657976/36546a12-8b66-4178-bb6f-cc1ba35547a6) | ![image](https://github.com/brave/brave-browser/assets/38657976/f1d65494-39af-4fc2-b2e9-1bddc34f1a94)
Side panel UI looks/functions correctly._PASSED - Confirmed that the icons are aligned properly on the sidebar - Confirmed the icon's border padding on both sides is even - Confirmed the click on each icon functions correctly. **Power Bookmarks** - Confirmed that imported bookmarks are shown under the sidepanel - Confirmed that bookmarks folder structure remained same in power bookmarks - Confirmed that bookmarks can be opened in new tab/window/private window without any issues - Confirmed that the bookmarks folders or bookmarks can be edited/renamed - Confirmed that bookmarks or bookmarks folders can be moved into another bookmarks folders works as expected - Confirmed that bookmarks can be delete without any issues - Confirmed that imported bookmarks can be opened without any issues In most of the places we are using chrome UI or controls/buttons instead of brave branded controls. Thread for more info https://bravesoftware.slack.com/archives/C7VLGSR55/p1701342885296929?thread_ts=1701121933.276189&cid=C7VLGSR55
Sync works_PASSED - Verified the sync functionality in general it works fine without any issues - When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices - Confirmed the bookmarks syched across all the devices in a sync chain - Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain - When 2 devices are in a sync chain, remove a device resets the sync chain - Confirmed that bookmarks, passwords, extensions, hostory, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Magnet URLs work_PASSED - Confirmed that magnet links opens up the WebTorren file - Confirmed that WebTorren file can be downloaded - Confirmed that magnet links doesn't open in PT/TOR windows
Interstitial pages_Inprogress_PASSED **Case 1:** 1. Clean profile `1.62.90` 2. Open ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR in a new tab 3. Confirmed that the Interstitial page opens up 4. Click on the `Use a Brave local IPFS node` 5. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/ 6. Click on `Use a public gateway` 7. Confirm that the IPFS page is opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/ Example | Example ----------|---------- ![image (2)](https://github.com/brave/brave-browser/assets/38657976/3ef86387-cae7-4898-b5b8-6a2d8dc5afce) | ![image](https://github.com/brave/brave-browser/assets/38657976/ba6ace67-a01e-48b5-b9aa-9caaa00cfce3) **Case 2:** Verified the test plan from https://github.com/brave/brave-core/pull/6782#test-plan ![IPFS](https://github.com/brave/brave-browser/assets/38657976/77bb5e5b-a461-4658-a21c-d4aea215ca0d) **Case 3:** Request OTR Followed the test plan from https://github.com/brave/brave-browser/issues/28750#issuecomment-1569339984 ### Steps: 1. installed `1.62.x 2. set `brave://flags/#brave-request-otr-tab` to `Enabled` 3. visited a request-OTR enrolled site: `loveisrespect.org` 4. confirmed that the “would you like OTR mode” interstitial appears 5. clicked `Proceed Off-The-Record` to go into OTR mode 6. confirmed that the requested page appears, and that there is an info bar at the top of the page describing how to leave OTR mode 7. opened dev tools went into the console and ran this code: `window.localStorage.braveQATest = true` 8. closed the OTR’ed site 9. confirmed that the OTR’ed site was not included in your browsing history 10. revisited `loveisrespect.org`, this time declining OTR mode 11. opened the dev tools console and ran this in the console: `console.log(window.localStorage.braveQATest)` ### Confirmed that `undefined` was returned Example | Example | Example | Example | Example | Example | Example | Example | Example ----------|-----------|-----------|----------|----------|-----------|-----------|-----------|----------- ![image](https://github.com/brave/brave-browser/assets/38657976/b80d6cdb-8af0-4bcb-bf71-ab6f67458c1a) | ![image](https://github.com/brave/brave-browser/assets/38657976/fd900c81-6222-4a36-b656-6c3b5fc4b943) | ![image](https://github.com/brave/brave-browser/assets/38657976/e947cc8b-3260-4be9-b3be-1fcd81c6f4a0) | ![image](https://github.com/brave/brave-browser/assets/38657976/b0e117fb-5052-4ade-8d8a-445a5236d539) | ![image](https://github.com/brave/brave-browser/assets/38657976/ccef3889-f7cc-483e-b471-d765675cf2a7) | ![image](https://github.com/brave/brave-browser/assets/38657976/40b9eb7a-50fe-4453-be24-a67a9acedc23) | ![image](https://github.com/brave/brave-browser/assets/38657976/0c7d7b63-891f-409d-b37f-c4c1e0f5f174) | ![image](https://github.com/brave/brave-browser/assets/38657976/f1c18bfe-1250-4f69-936e-c51bacf4fecf) | ![image](https://github.com/brave/brave-browser/assets/38657976/39a079c1-2637-4b52-a138-fc944077dd60) **Case 4:** Shields domain block interstitial - Verified the test plan from https://github.com/brave/brave-browser/issues/14134#issuecomment-800624427 - Confirmed that interstitial-page warning message is shown when shields are set to "Aggressive" ad blocking mode 101com.com | 00px.net | zzhc.vnet.cn | 101order.com ---------------|-----------|---------------|---------------- ![image](https://github.com/brave/brave-browser/assets/38657976/059f28a8-8c64-47c4-9fd7-a5bb9c4a81dd) | ![image](https://github.com/brave/brave-browser/assets/38657976/e96871a5-7623-41f0-8a8f-521cc29e12a9) | ![image](https://github.com/brave/brave-browser/assets/38657976/4eb166ea-19fc-44c0-a99e-06ea7f6cabc6) | ![image](https://github.com/brave/brave-browser/assets/38657976/c435ac00-681f-4a3c-a029-ac6407731593)

Settings comparison

- New settings `On-device site data` cookies settings is added as part of CR120, bot sure whether to retain this settings in brave or not - thread for more details https://bravesoftware.slack.com/archives/C7VLGSR55/p1701180529136849?thread_ts=1701121933.276189&cid=C7VLGSR55 ![image](https://github.com/brave/brave-browser/assets/38657976/7e9456e5-3f64-4d78-983d-504a528c68bd) - Settings `Show images on tab hover preview cards` is inherited from chrome - Logged https://github.com/brave/brave-browser/issues/34608

Components updater

- No new components are added as part of CR 120 - Components are updates successfully without any error **`1.60.118 Chromium: 119.0.6045.163`** | **`1.62.87 Chromium: 120.0.6099.35`** -- | -- ![image](https://github.com/brave/brave-browser/assets/38657976/feabd2e1-6729-457b-ac91-d18c9cdb21d4) | ![image](https://github.com/brave/brave-browser/assets/38657976/f698f5e8-556b-45de-a122-d7a3c5e0db5c)
GeetaSarvadnya commented 9 months ago

@srirambv The desktop affected area item Decentralized DNS (See test plan in https://github.com/brave/brave-browser/issues/24990#issuecomment-1296701139) is related to wallet could you verify the same on CR120 build? Thanks!

srirambv commented 9 months ago

Verification passed on

Brave 1.62.90 Chromium: 120.0.6099.35 (Official Build) nightly (64-bit)
Revision 276c6d1745bff39888cedcc6aa54e9c5c35e764e
OS Linux

https://github.com/brave/brave-browser/assets/17010094/616a7ba2-2966-4f75-8aaa-5de2f1e53cbb

Uni-verse commented 9 months ago

Verified on Samsung Galaxy Tab S7 using the following version:

Brave   1.62.86 Chromium: 120.0.6099.35 (Official Build) canary (32-bit) 
Revision    f248c65a74007536fb36959f92fc01fcb752e5fc
OS  Android 13; Build/TP1A.220624.014; 33; REL
Send to device - Confirmed `send to devices` is displayed in the share menu when joining sync chain Encountered: https://github.com/brave/brave-browser/issues/34636 C119 | C120 -|- ![Screenshot 2023-11-30 at 5 53 53 PM](https://github.com/brave/brave-browser/assets/17885425/46b6b6b1-4986-4c7f-a4f5-12e791782bcb) | ![Screenshot 2023-11-30 at 6 01 42 PM](https://github.com/brave/brave-browser/assets/17885425/74bc58f0-7b8b-4a2e-84e0-4a0acd393cbc)
Brave Shields and privacy settings - Ensured Brave shields and privacy settings have not regressed - Ensured users can set per site settings in Brave Shields - Ensured ads are blocked and users can disable shields - Ensured global settings effect webpages C119 | C120 -|- ![Screenshot 2023-11-30 at 6 31 48 PM](https://github.com/brave/brave-browser/assets/17885425/cc698277-cd96-44b7-81cf-573b14659c47) | ![Screenshot 2023-11-30 at 6 38 13 PM](https://github.com/brave/brave-browser/assets/17885425/48848a9a-7828-4268-9c27-7feeb81b9bbd)
Main app menu UI - Ensured main app menu has not regressed C119 | C120 -|- ![Screenshot 2023-11-30 at 6 20 50 PM](https://github.com/brave/brave-browser/assets/17885425/29e4fbc9-d919-41f9-badf-f2b5c79b2f6a) | ![Screenshot 2023-11-30 at 6 26 56 PM](https://github.com/brave/brave-browser/assets/17885425/89080dd5-504e-4302-8fd4-2b7756a2ecca) ![Screenshot 2023-11-30 at 6 35 52 PM](https://github.com/brave/brave-browser/assets/17885425/f88bf961-23c4-4fea-a38d-fb2e6469eeb6) | ![Screenshot 2023-11-30 at 6 36 33 PM](https://github.com/brave/brave-browser/assets/17885425/8ccca5c6-8de1-406a-8164-2e446cdb7c79)
Sync - Ensured sync works on fresh and upgraded profile - Ensured starting sync chain and adding multiple devices works - Ensured joining with phrase and scanning works - Ensured data is synced Example | Example -|- ![Screenshot 2023-11-30 at 6 05 59 PM](https://github.com/brave/brave-browser/assets/17885425/06e76ee4-0064-4897-a71c-ea463177e785) | ![Screenshot 2023-11-30 at 6 06 21 PM](https://github.com/brave/brave-browser/assets/17885425/f0ee8052-9c64-4eb9-801a-b2251017dc4b)
Home button - Ensured default home page is set to `Brave's homepage` - Ensured setting custom url for homepage will take user when they tap the home button in the toolbar - Ensured that users can set homepage back to `Brave's homepage` - Ensured homepage settings are retained on upgraded profile Home set to `Yahoo.com` (Private) | Home set to `Yahoo.com` | Default | Home set to brave homepage -|-|-|- ![Screenshot 2023-11-30 at 6 28 15 PM](https://github.com/brave/brave-browser/assets/17885425/97a50fda-fe45-40ab-b8c4-48390cf64014) | ![Screenshot 2023-11-30 at 6 28 24 PM](https://github.com/brave/brave-browser/assets/17885425/f09499ca-ba8f-43e8-95db-6972508b4f7e) | ![Screenshot 2023-11-30 at 6 28 33 PM](https://github.com/brave/brave-browser/assets/17885425/548e489c-6066-4860-a8e9-6d2d29fc14a9) | ![Screenshot 2023-11-30 at 6 29 33 PM](https://github.com/brave/brave-browser/assets/17885425/36349a6f-ecf0-49d9-a723-9628ac98b6be)
Top toolbar - Ensured top toolbar functionality has not regressed on Tablet.
hffvld commented 9 months ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 U1B2.230922.013 release-keys
Brave build: 1.63.2 
Chromium: 120.0.6099.35 (Official Build) canary (64-bit) 

Send tab to other device (double check it works as intended) - Verified that `Send to devices` is shown only when `Sync` is ON, and at least 2 devices in the sync chain - Observe Brave crash when trying to share the tab https://github.com/brave/brave-browser/issues/34636 |1|2| |:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/5884cea5-f167-4a5e-8774-f7add89b71ae) | ![2](https://github.com/brave/brave-browser/assets/128532965/1401cae8-52d3-4320-b5bf-c52dd915a697) | | ![1](https://github.com/brave/brave-browser/assets/128532965/26161379-e32b-4b2d-92d7-7f5b2f3fc78f) | ![2](https://github.com/brave/brave-browser/assets/128532965/71d0296f-cdb9-494d-a941-a509a6518268) |
Brave shields and privacy settings (double check no regression in this section) - Verified that `Brave Shields & privacy` settings are working. Checked some settings like Block trackers & ads`, `Upgrade connections to HTTPS`, `Clear data on exit`, `Block cookie consent notices` and `Lock Private tabs when you leave Brave` |1|2|3| |:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/37b9b77d-58ec-4480-800e-d7c46c9dec8b) | ![2](https://github.com/brave/brave-browser/assets/128532965/473c5f3d-21fa-40f5-8eb7-0904dcefa8b0) | ![3](https://github.com/brave/brave-browser/assets/128532965/8dfdb03c-a261-4da5-a3da-620a6a3d3ff3) | | ![1](https://github.com/brave/brave-browser/assets/128532965/7e7de512-56e7-4d5c-a5bb-64cc3336f171) | ![2](https://github.com/brave/brave-browser/assets/128532965/bed1de4d-7a7a-4e08-9972-2a7995c76b4f) | ![3](https://github.com/brave/brave-browser/assets/128532965/bdd828ed-55f0-4ae1-970c-e0bcba00a726) |
Main app menu UI (double check there is no regression) - Verified that the `main app menu` UI is fine - Verified that sub-menus are working fine as well - Verified that enabling and disabling toggle switches is working |1|2|3| |:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/65b0b1f2-8ccd-48d5-b5f7-340e04e2d378) | ![2](https://github.com/brave/brave-browser/assets/128532965/213bc40f-8b5f-4d2e-8091-4f44bc622412) | ![3](https://github.com/brave/brave-browser/assets/128532965/d71672de-fced-403d-b1b1-7853bb47f0e0) | | ![1](https://github.com/brave/brave-browser/assets/128532965/af296e2c-9589-4943-a749-7457eba60a41) | ![2](https://github.com/brave/brave-browser/assets/128532965/e810ba75-a55f-4d8e-9e89-bb57286749d7) | ![3](https://github.com/brave/brave-browser/assets/128532965/7de86ef0-cd1f-4cd9-a537-244fce0612f9) |
Sync (double check it generally works) - Verified that the `Sync` between multiple devices (Android, iOS and MacOS) is working fine |1|2| |:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/473d44dd-4a28-4e3d-b99e-b7c6dcfba725) | ![2](https://github.com/brave/brave-browser/assets/128532965/223cdb8e-e021-4ba7-a1f1-47d3053ada78) | | ![3](https://github.com/brave/brave-browser/assets/128532965/82780fb3-ab23-4ae4-b35e-0ea1d7d84864) | ![4](https://github.com/brave/brave-browser/assets/128532965/6af8fec8-4dab-4365-9da8-69e437495390) | https://github.com/brave/brave-browser/assets/128532965/af7a1fff-2e73-474f-983a-eb6c499a306d
Home button (double check it works as expected) - Verified that the `Home button` looks and works fine |1|2|3| |:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/dd4e0c24-0038-4ca4-a073-cdedd873397e) | ![2](https://github.com/brave/brave-browser/assets/128532965/fe0a4508-f5e6-4a61-885a-1431c697433e) | ![3](https://github.com/brave/brave-browser/assets/128532965/05f40259-3503-4647-b7df-5e99da04a08d) |
Top toolbar (double check there are no excessive items) - Verified that the `Top toolbar` UI and functionality work fine |1|2|3| |:-:|:-:|:-:| | ![1](https://github.com/brave/brave-browser/assets/128532965/c49c12cc-610c-4da9-b030-e9a6de12c4c9) | ![2](https://github.com/brave/brave-browser/assets/128532965/8fe78a7d-ce51-40eb-82dd-1c606f6e52c6) | ![3](https://github.com/brave/brave-browser/assets/128532965/498c4534-78df-4008-9e6f-d1525b69941e) | | ![1](https://github.com/brave/brave-browser/assets/128532965/261cfaa3-7805-4e10-9c6e-3589d3bc4d3a) | ![2](https://github.com/brave/brave-browser/assets/128532965/9d43d839-75a1-4659-8081-fd5d35c068d9) | ![3](https://github.com/brave/brave-browser/assets/128532965/75244e6e-a0c3-4c59-99b5-9a0b6e4720b5) |
kjozwiak commented 9 months ago

Labelling as QA/No & release-notes/exclude in favour of https://github.com/brave/brave-browser/issues/34648.