search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.67k stars 2.31k forks source link

YouTube: Pre-roll ads, ads on page, and video "overlay" ads not blocked #3348

Closed Brave-Matt closed 3 years ago

Brave-Matt commented 5 years ago

Description

Seeing several reports recently about YouTube ads not being blocked. This seems to vary between but not be limited to:

Diagnosing the issue is difficult given that I'm unable to reproduce this on my end when testing (using macOS and windows 7/10). Would be good to know if there is any specific or pertinent information to collect from users that would help highlight what the issue is (cc @lukemulks) - So far I've been collecting Brave version, OS info, and URLs to the videos where ads are displayed.

Steps to Reproduce

  1. Visit YT and stream video content (I imagine this would be easiest to produce when streaming videos with a high view count - more likely to be monetized).

Actual result:

Ads are displayed on page and in video.

Expected result:

Ads should be blocked.

Reproduces how often:

Users experiencing this issue report that this behavior is consistent for them.

Brave version (brave://version info)

Release channel v0.59.35 Beta v0.60.23 Dev v0.61.16

Website problems only:

Additional Information

User reports - will add more to the thread as I come across them:

ryanbr commented 4 years ago

@UndercoverNL @melMass @Kalense @Sov3rain

Youtube has recently been testing ads on various regions. It's affecting all adblocking software (uBO and Adguard), some more than others.

As a test, can someone test Brave Beta, Site-ads/trackers = Aggressive in Shields on youtube. and re-test these youtube ads? We have had some reports that Brave beta currently is less affected at the moment.

https://brave.com/download-beta/

cold-briu commented 4 years ago

Same bug here I'm using 1.8.90 Chromium: 81.0.4044.129 (Official Build) (64-bits) On high sierra

UndercoverNL commented 4 years ago

@UndercoverNL @melMass @Kalense @Sov3rain

Youtube has recently been testing ads on various regions. It's affecting all adblocking software (uBO and Adguard), some more than others.

As a test, can someone test Brave Beta, Site-ads/trackers = Aggressive in Shields on youtube. and re-test these youtube ads? We have had some reports that Brave beta currently is less affected at the moment.

https://brave.com/download-beta/

It seems that the Brave beta does work! Not sure but I have already been able to watch more than 10 videos without any prerole ads

noircir commented 4 years ago

The ads in Youtube started appearing in my Brave since April, 2020. After 2 months of quiet suffering, (and switching to Firefox which at least allows you to "skip ads") I decided to check on Github issues. Et voilà, after installing Brave beta (the answer above) no ads!

ryanbr commented 4 years ago

We have an upcoming fix (hopefully to be rolled out next week), which should help with most of these ads. To be more uBO-like in blocking.

Google/Youtube have been testing their anti-adblock. And adblock extensions are still having issues, Some uBO users are still reporting ads. https://old.reddit.com/r/uBlockOrigin/comments/hchfuc/youtube_ads/

AlvisonHunterArnuero commented 4 years ago

New fixes coming soon, those are great news, guys!

Hopefully we are able to get rid of those annoying everlasting YouTube Ads once and for all. YT should give the user the chance of skipping all of them or place them in a container with a close button, that way once we close it, we won't be bothered with more ads anymore. It is not easy to be watching a JavaScript tutorial for example, and get invaded by an ad in the middle of a function explanation, it sucks!

Many thanks for the work and efforts doing for the upcoming fixes, you guys rock! Brave mode ON!

GewoonJaap commented 4 years ago

image image

Getting ads sometimes on YouTube (Netherlands): Versie 1.10.97 Chromium: 83.0.4103.116 (Officiële Versie) (64-bit)

radocisar commented 4 years ago

1) Pre-roll 2) Windows 10.0.18363 Build 18363 3) No 4) No 5) Default 6) No

superspreader commented 4 years ago

I am experiencing the issue as well. Here's some details:

Thank you for your work.

almindor commented 4 years ago

Same as others:

Pre-roll ads only Arch Linux updated to latest Extensions: Disabled all to ensure Connected directly No custom/extra filters in Brave adblock

A248 commented 4 years ago

For those searching the web and coming here, I had a similar issue. Started happening today - yesterday, there were no ads.

Disabling the Google Translate extension solved the issue.

almindor commented 4 years ago

For those searching the web and coming here, I had a similar issue. Started happening today - yesterday, there were no ads.

Disabling the Google Translate extension solved the issue.

I don't have google translate even installed...

canvero commented 4 years ago

I've been seeing pre-roll ads on YT in Brave since yesterday, never before.

  1. only pre-roll as far as i'm aware (skippable)
  2. Ubuntu 18.04.4
  3. No extensions
  4. No VPN
  5. Default Shields
  6. No additional filters in brave://adblock

Brave Version 1.10.93 Chromium: 83.0.4103.106 (Official Build) (64-bit) Location:Netherlands

Perhaps this info helps. Thank you for looking into this. Edit: tried Brave beta, no ads there!

Xtortion commented 4 years ago

Ads are showing here as well on YouTube again with Shield enabled.

No extensions, No VPN, Default Shield

Version: 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Location: The Netherlands

darkin1 commented 4 years ago

Same here

No extensions, No VPN, Default Shield

Wersja 1.9.68 Chromium: 81.0.4044.138 (Official Build) unknown (64-bit) Location: Poland

gabrielacorona commented 4 years ago

I've been seeing pre-roll ads on youtube using Brave. It started this week but I didn't seem to have this problem before.

only pre-roll as far as i'm aware (skippable) MacOS 10.14.6 No VPN Default Shields No additional filters in brave://adblock Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Location: Mexico

If it's needed I can reproduce the issue since I will switch to beta. Thank you for looking into this

ezranbayantemur commented 4 years ago

Same here. I'm gonna hang myself because of YouTube Premium ads.

micahn commented 4 years ago

Been dealing with this for about 2 weeks now with 2 of my machines. i found that it is based on my login. logging out or using a private brave window i do not see any ads.

PC1: pre-roll - skippable. have not noticed any in video ads Windows 10 - 1909 18363 no VPN all brave settings default. Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Location USA

PC2: originally i had non-skippable pre-roll ads. however as of yesterday i have not had any ads with this machine. unsure if it's fixed or im just getting lucky. posting just for more info. Ubuntu 20.04 no VPN all brave settings default. Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit) Location USA

stendarr commented 4 years ago

Pre-roll skippable ads for the past few days, currently on version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit). The OS is Debian testing, the shield settings are: scripts allowed, cross site cookies blocked, cross site trackers blocked, and fingerprinting blocked - all other settings are default.

Definitely gonna use Firefox with an ad blocker extension from now on.

ryanbr commented 4 years ago

If you're seeing ads,

  1. Make sure, (manually update Brave Ad Block Updater and Subresource Filter Rules in brave://components/
  2. In, Site-settings -> Clear Data for youtube.com, and re-login.
  3. Try opening youtube in private mode, and re-test.

Tested with https://www.youtube.com/watch?v=erQ_9yEz0ls (Mr Beasts, I Bought The World's Largest Firework ($600,000). Get 2 Ads in Chrome, Brave went straight to the video.

Brave on the Left. Chrome on the right. comparison

ryanbr commented 4 years ago

We have an additional fix in Brave Beta. which will be due out next week.

Sh4d0wHunt3rX commented 4 years ago

I experience pre roll ads on many videos on Brave. I hope the fix will release to main Brave browser soon.

antonok-edm commented 3 years ago

This is resolved thanks to work from @ryanbr and others in the filter list community.

severus-tux commented 3 years ago

This is resolved thanks to work from @ryanbr and others in the filter list community.

Nope. I am seeing YouTube ads on my iPad running iOS 14. Both preroll ads and banners. I’ll add more screenshots if I encounter them again.

EAADCA5D-FBA4-47EB-A01D-2633B6ED2B17

ryanbr commented 3 years ago

@severus-tux note that Brave IOS doesn't have cosmetic filtering yet

Follow https://github.com/brave/brave-ios/issues/2683

nithinkodadhavadee commented 3 years ago

Okay fine, this thing is occurring quite frequently. I didn't get any ads in between the video. It wasn't the banners. I get a video ad at the beginning or the end of the video. I'm not sure if this was a thing back in 2019, multiple ads in a video, as far as I remember it was just one ad in the video back then. I don't get this ad every time, I got it two times and am not getting any in that video. one ad just pops up here and there like four or five a day and I noticed it yesterday and today. It is a different video every time.

Screenshot_20210515_050240

Screenshot_20210515_051149

I use this Version 1.22.70 Chromium: 89.0.4389.105 (Official Build) (64-bit) on an Arch Linux.

I've tried a lot but couldn't reproduce this, it just happens.

In some videos, I used to get a blank white screen with a skip button. but haven't seen that in quite a while.

What I need from the users trying to help debug the issue:

  • Test in private mode with no extensions enabled, with only Sheilds enabled,
  • Clear Youtube cookies first in the options, then visit the problematic youtube site.
  • A Screenshot of the shields window open and the shields cross-site trackers being listed., showing the ad in the background. Like so: https://imgur.com/a/Ms9BT5Q (I have no ad showing in my case, because I can't replicate it)
  • Go into Shields / Cross-site trackers.
  1. Ctrl-A (Select all Cross-site trackers)
  2. Crtl-C (Copy to Clipboard)
  3. Ctrl-V (Paste) into pastebin.com,

Like so: https://pastebin.com/18EAphvt (For Privacy, trim each line leaving the first 50-60 chars of each line or so)

@ryanbr There are more than 700 lines when I try to copy-paste the whole list of all the trackers blocked, and I'm not sure what I can share among those and what I can't.

should I open this issue?

ryanbr commented 3 years ago

youtube has implemented a new method of serving ads, we're still investigating this. @nithinkodadhavadee

nithinkodadhavadee commented 3 years ago

anything that I can help you guys with?

Vista2003 commented 3 years ago

Okay fine, this thing is occurring quite frequently. I didn't get any ads in between the video. It wasn't the banners. I get a video ad at the beginning or the end of the video. I'm not sure if this was a thing back in 2019, multiple ads in a video, as far as I remember it was just one ad in the video back then. I don't get this ad every time, I got it two times and am not getting any in that video. one ad just pops up here and there like four or five a day and I noticed it yesterday and today. It is a different video every time.

Screenshot_20210515_050240

Screenshot_20210515_051149

I use this Version 1.22.70 Chromium: 89.0.4389.105 (Official Build) (64-bit) on an Arch Linux.

I've tried a lot but couldn't reproduce this, it just happens.

In some videos, I used to get a blank white screen with a skip button. but haven't seen that in quite a while.

What I need from the users trying to help debug the issue:

  • Test in private mode with no extensions enabled, with only Sheilds enabled,
  • Clear Youtube cookies first in the options, then visit the problematic youtube site.
  • A Screenshot of the shields window open and the shields cross-site trackers being listed., showing the ad in the background. Like so: https://imgur.com/a/Ms9BT5Q (I have no ad showing in my case, because I can't replicate it)
  • Go into Shields / Cross-site trackers.
  1. Ctrl-A (Select all Cross-site trackers)
  2. Crtl-C (Copy to Clipboard)
  3. Ctrl-V (Paste) into pastebin.com,

Like so: https://pastebin.com/18EAphvt (For Privacy, trim each line leaving the first 50-60 chars of each line or so)

@ryanbr There are more than 700 lines when I try to copy-paste the whole list of all the trackers blocked, and I'm not sure what I can share among those and what I can't.

should I open this issue?

If it's reappearing again, I would open a new ticket. Regarding what happened in 2019, ads would only play at the start and sometimes I would get an ad above suggested videos.

In the meantime, after flagging it as a workaround to this problem, use Ublock Origin along side Brave.

stefanolomo commented 1 year ago

Hi just had the same problem. Cleaning the cache and removing google docs extension seems to fix it. For some reason and somehow it looks like google is detecting adblocker via extensions