search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.84k stars 2.33k forks source link

Support mobile view in sidebar #33533

Open simonhong opened 1 year ago

simonhong commented 1 year ago

Goal: Implement mobile view panel in sidebar under feature flags that disabled by default.

MobileViewSidePanelManager will manage mobile view sidebar item's side panel coordinator. This manager monitors mobile view sidebar item add/remove events and create/destory its side panel coordinator.

TODOs

scwall commented 6 months ago

Hi, do you have any idea when this option will be available? We want to migrate from edge to another browser where I work (for reasons of siphoning data from edge ...) however this feature is much used by various administrative services for its speed.

rebron commented 6 months ago

Hi @scwall We're still working through the design as we have split view to account for with sidebar mobile view. Split view is accessible here to test in Nightly brave://flags/#brave-split-view.

Would love to hear more about your use case re: sidebar browsing.

Seddu commented 6 months ago

Yeah, i’m eager too. One step closer for me to ditch Vivaldi.

livejamie commented 5 months ago

Hi @scwall We're still working through the design as we have split view to account for with sidebar mobile view. Split view is accessible here to test in Nightly brave://flags/#brave-split-view.

Would love to hear more about your use case re: sidebar browsing.

It's convenient to open certain tools in the sidebar view. For example, opening up a shopping cart on certain websites, opening up perplexity/chatgpt to help you write an answer or do research, opening up a calendar/agenda while taking notes, and opening up a note-taking application or a to-do list app.

You can get a lot of the same functionality that you would typically have to install an extension for.

livejamie commented 5 months ago

The split view functionality in Nightly is nice and should remain a separate feature, but I want every bookmark I place in the sidebar to open in a small overlay.

You can look at how Edge and Vivaldi handle this feature. Here are two GIFs showing an example journey from both.

WindowTop_sQ0fJYtnu4 WindowTop_VimIkyxdKk

You can see how treating them as tiny bookmark/launcher icons that open full-screen prevents the main reason why people use this feature.

livejamie commented 5 months ago

Please note that this is the first time I've heard of this feature mentioning "Mobile" functionality. I'm not sure if Edge or Vivaldi do anything to send a mobile user agent. I'm pretty sure it's just a regular browser window. There's nothing "mobile" about it.

lazymonkey2 commented 5 months ago

vivaldi and edge offer the option to view the regular site or mobile one. This is because viewing a regular site in the sidebar makes it unusable, since the sidebar is too small. Instead a mobile site can fit easily in the sidebar.

livejamie commented 5 months ago

vivaldi and edge offer the option to view the regular site or mobile one. This is because viewing a regular site in the sidebar makes it unusable, since the sidebar is too small. Instead a mobile site can fit easily in the sidebar.

Ah you're right, it does look like they have a toggle for it to be the desktop or mobile version of the site when I right click the icon.