brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.77k stars 2.32k forks source link

`Brave VPN` system-tray icon no longer shows accurate `Connected` status #33585

Open stephendonner opened 1 year ago

stephendonner commented 1 year ago

Description

Brave VPN system-tray icon no longer shows accurate Connected status

Steps to Reproduce

  1. installed 1.60.87
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN (via the VPN button on the browser toolbar)
  4. click on the "hamburger" menu
  5. click on the Brave VPN -> Show tray icon menu option
  6. look at the system-tray icon for Brave VPN
  7. connect / disconnect from Brave VPN
  8. check to see if the system-tray status icon reflects the status changes

Actual result:

The Brave VPN system-tray icon only (for me) shows the Connecting... (blurple-colored) icon (https://github.com/brave/brave-browser/issues/32535), not the green (Connected) icon.

https://github.com/brave/brave-browser/assets/387249/e26da2d6-2ae5-491d-b477-c24bd244fcfd

Expected result:

The Brave VPN system-tray icon should show the green Connected icon

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.60.87 Chromium: 118.0.5993.70 (Official Build) beta (64-bit)
-- | --
Revision | 854c1e600054dfca6842cebaf729f100f4b0f066
OS | Windows 10 Version 22H2 (Build 19045.3570)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

@bsclifton @rebron @simonhong @MadhaviSeelam @GeetaSarvadnya

bsclifton commented 6 months ago

@stephendonner this should be fixed now - after @simonhong 's recent rework with IKEv2/WireGuard. For example, see https://github.com/brave/brave-core/pull/21934

Can you please retest?

stephendonner commented 6 months ago

@stephendonner this should be fixed now - after @simonhong 's recent rework with IKEv2/WireGuard. For example, see brave/brave-core#21934

Can you please retest?

Great; sure thing. Will try to do so today 👍