brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Vertical Tabs: tab highlights when selecting multiple tabs are too subtle #33604

Open Brave-Matt opened 11 months ago

Brave-Matt commented 11 months ago

Description

When vertical tabs are enabled, selecting multiple tabs (via Shift + Click) works but the tab highlights (showing which additional tabs are selected), while there, is not obvious. The tab highlights are too subtle and it can be hard to see what you've selected. It is particularly hard to tell when using the Light theme — it is a bit more apparent when dark theme is enabled.

No additional tabs selected:

image

All four tabs selected (light):

image

All four tabs selected (dark):

image

Brave version (brave://version info)

v1.60.88+

Version/Channel Information:

Miscellaneous Information:

Other users reporting the same issue: https://community.brave.com/t/visual-bug-with-multiple-tabs-selected-when-vertical-tabs-enabled/507521/4

It would be good to include this in color/theme update that is going out: https://github.com/brave/brave-browser/issues/31644

cc @rebron

Coffeeling commented 11 months ago

This is a regression as far as I can tell: For a while there was no effect at all on Beta branch at least. See #33012 (the beta has gotten these subtle multiselection effects from Nightly now)

I don't remember there being any issues with nonexistent or very subtle multiple tab selection effects at first, this is pretty new.