Remove grandfathered state

[Miyayes]

Description

All non-connected users should be in the 2.5 non-connected state. No more support for grandfathered state, so we can remove the code.

[LaurenWags]

Verified with

Brave | 1.66.95 Chromium: 124.0.6367.91 (Official Build) beta (x86_64)
-- | --
Revision | e1f8e3c95a12986231bc8226b78a951233e7c026
OS | macOS Version 13.6.6 (Build 22G630)

Unconnected State - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards 3. Confirmed in the "unconnected" state Example | Example | Example --- | --- | --- | | 4. Confirmed panel shows number of verified creators visited 5. Confirmed able to view ads and modify ad settings Example | Example | Example --- | --- | --- | | ``` [54193:259:0430/095918.217497:VERBOSE1:notification_ad_serving.cc(138)] Maximum notification ads per hour changed to 2 ``` 6. Confirmed with ads cashed in with the server for the next month, no ad banner displays (per `/parameters` endpoint "unverified" rewards are "processing"): ``` [ RESPONSE ] > URL: https://api.rewards.bravesoftware.com/v1/parameters > Result: Success > HTTP Code: 200 > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.233944,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","SG","GB","CA"],"block":[]},"solana":{"allow":[],"block":["KP","ES"]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"processing","gemini":"processing","payoutDate":"","solana":"processing","unverified":"processing","uphold":"processing","zebpay":""},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"tosVersion":1,"vbatDeadline":"2023-10-31T00:00:00Z","vbatExpired":true} ``` Example | Example | Example | Example --- | --- | --- | --- | | |

Connected State - PASSED

Covers: - connecting to custodian/self custody - completing a tip (Uphold/Gemini/bitFlyer) - completing a monthly tip (Uphold/Gemini/bitFlyer) - completing an auto contribution (Uphold/Gemini)

Uphold - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Confirm balance displays as expected Example | Example | Example --- | --- | --- | | 5. Confirm able to do a one time tip Example | Example | Example --- | --- | --- | | 6. Confirm able to set up a monthly tip (a one time tip is sent immediately, and then a recurring tip is scheduled for following month) Example | Example | Example --- | --- | --- | | 7. Populate Auto Contribution list if not already populated 8. Close browser 9. Advance computer clock one month 10. Relaunch 11. Confirm Auto Contribution and Monthly Contribution are completed as expected. Confirmed next monthly tip is scheduled as expected. Auto Contribution: Example | Example | Example --- | --- | --- | | Monthly Contribution: Example | Example | Example --- | --- | --- | |

Gemini - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Confirm balance displays as expected Example | Example | Example --- | --- | --- | | 5. Confirm able to do a one time tip Example | Example | Example --- | --- | --- | | 6. Confirm able to set up a monthly tip (a one time tip is sent immediately, and then a recurring tip is scheduled for following month) Example | Example | Example --- | --- | --- | | 7. Populate Auto Contribution list if not already populated 8. Close browser 9. Note, my AC and monthly tip are going to contribute on different days. As such, I'm going to trigger the AC first (since that has a date of "May 31") then the monthly tip (which has a date of "June 1"). Advance computer clock to AC date (late in the day to trigger AC). 10. Relaunch 11. Confirm Auto Contribution goes through as expected. Auto Contribution: Example | Example | Example --- | --- | --- | | 12. Close browser again. 13. Advance computer clock to next day. 14. Relaunch and confirm Monthly Contribution is completed as expected. Confirmed next monthly tip is scheduled as expected. Monthly Contribution: Example | Example | Example --- | --- | --- | |

ZebPay - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Confirm balance displays as expected Example | Example | Example --- | --- | --- | |

bitFlyer - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Confirm balance displays as expected Example | Example | Example --- | --- | --- | | 5. Confirm able to do a one time tip Example | Example | Example --- | --- | --- | | 6. Confirm able to set up a monthly tip (a one time tip is sent immediately, and then a recurring tip is scheduled for following month) Example | Example | Example --- | --- | --- | | 7. Close browser 8. Advance computer clock to Monthly Contribution date (late in the day to trigger AC). 9. Relaunch 10. Confirm Monthly Contribution is completed as expected. Confirmed next monthly tip is scheduled as expected. Monthly Contribution: Example | Example | Example | Example --- | --- | --- | --- | | |

Self Custody - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to self-custody 3. Confirm in connected state Example | Example --- | --- | 4. Confirm balance displays as expected Example | Example | Example --- | --- | --- | |

Disconnected State - PASSED

Uphold - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Navigate to custodian and remove/revoke integration 5. Confirm the browser is in the "Disconnected" state Example | Example | Example --- | --- | --- | | 7. Confirm browser reflects "Disconnected" state Example | Example | Example --- | --- | --- | | 8. Confirm able to reconnect 9. Confirm browser reflects connected state Example | Example | Example --- | --- | --- | |

Gemini - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Navigate to custodian and remove/revoke integration 5. Confirm the browser is in the "Disconnected" state Example | Example | Example --- | --- | --- | | 7. Confirm browser reflects "Disconnected" state Example | Example | Example --- | --- | --- | | 8. Confirm able to reconnect 9. Confirm browser reflects connected state Example | Example | Example --- | --- | --- | |

ZebPay - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Wait for connection to expire. 5. Confirm the browser is in the "Disconnected" state Example | Example | Example --- | --- | --- | | 7. Confirm browser reflects "Disconnected" state Example | Example | Example --- | --- | --- | | 8. Confirm able to reconnect 9. Confirm browser reflects connected state Example | Example | Example --- | --- | --- | |

bitFlyer - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state Example | Example --- | --- | 4. Wait 7 minutes, tip a site. 5. Confirm the browser is in the "Disconnected" state Example | Example | Example --- | --- | --- | | 7. Confirm browser reflects "Disconnected" state Example | Example | Example --- | --- | --- | | 8. Confirm able to reconnect 9. Confirm browser reflects connected state Example | Example | Example --- | --- | --- | |

Reset Rewards - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Confirm in connected state, note paymentID Example | Example --- | --- | 4. Navigate to brave://rewards and reset rewards 5. Confirm UI is returned to pre-connected state Example | Example --- | --- | 6. Join Rewards again 7. Connect to a different custodian 8. Confirm in connected state and a different paymentID is being used Example | Example --- | --- |

Errors - PASSED

1. Clean install of 1.66.x, close and relaunch to pull griffin seed 2. Join Rewards, connect to custodian 3. Use Charles Proxy to simulate some error conditions to confirm error messages still display as expected Uphold - Flagged: ``` [ REQUEST ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/b416fbe3-a85f-5eca-a901-7b5b33db8988/claim > Method: POST > Content: {"signedLinkingRequest":"eyJib........... [881:259:0506/145414.482190:VERBOSE1:url_loader.cc(111)] [ RESPONSE ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/b416fbe3-a85f-5eca-a901-7b5b33db8988/claim > Result: Failure > HTTP Code: 400 > Body: {"code":400,"message":"error linking wallet: unable to link - unusual activity: unusual activity"} [881:259:0506/145414.482765:INFO:post_connect.cc(79)] Flagged wallet [881:259:0506/145414.483504:INFO:connect_external_wallet.cc(111)] Failed to connect uphold wallet ``` Gemini - KYC Required: ``` [ REQUEST ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/33f0d1ff-dc6e-5603-8075-baeffc1088fe/claim > Method: POST > Content: {"linking_info":"eyJ0eX........ [ RESPONSE ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/gemini/33f0d1ff-dc6e-5603-8075-baeffc1088fe/claim > Result: Failure > HTTP Code: 404 > Body: {"geoCountry":"US"} [1413:259:0506/153405.816020:INFO:post_connect.cc(114)] KYC required [1413:259:0506/153405.816919:INFO:connect_external_wallet.cc(111)] Failed to connect gemini wallet ``` bitFlyer - Generic error: ``` [ REQUEST ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/bitflyer/771ce004-41db-5d94-94aa-e3476f6c7de8/claim > Method: POST > Content: {"linkingInfo":"eyJhb......... [ RESPONSE ] > URL: https://grant.rewards.bravesoftware.com/v3/wallet/bitflyer/771ce004-41db-5d94-94aa-e3476f6c7de8/claim > Result: Failure > HTTP Code: 500 > Body: {"geoCountry":"JP"} [2131:259:0506/164625.277840:INFO:post_connect.cc(120)] Unexpected error [2131:259:0506/164625.278751:INFO:connect_external_wallet.cc(111)] Failed to connect bitflyer wallet ```