search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.54k stars 2.27k forks source link

NTP Top sites/favorites platform parity (aka Favorites V1) #33845

Open anthonypkeane opened 10 months ago

anthonypkeane commented 10 months ago

Description

More info: https://bravesoftware.slack.com/archives/C02GELCD6BC/p1696121788822279

The scope of this issue is for V1 - detailed below. Subsequent versions should have a new GH issue.

Design: https://www.figma.com/file/MUhkPocM62cSGYkZ6CXVpT/Top-Sites---Cross-Platform-Suggestions?type=design&node-id=70%3A14712&mode=design&t=t2sESREz26fPX2cc-1 (Not complete, needs work for V1)

For v1, display a setting for either Favorites or Top Sites

Under DISPLAY > New Tab Page (potentially rename to Home Page) add the following Keep the screen and setting as-is bar

Under Widgets Show Top Sites (On/Off) Show Favorites (On/Off) (Greyed out unless Top Sites is off) --> Double check UX on this with Devs and Design

UI for adding Favorites Need Design Help

timchilds commented 9 months ago

Some extra details re: the functionality we should focus on for V1 MVP.

  1. Users can switch between Top Sites / Favorites in the NTP widget (new functionality).

  2. Users can add Favorites (to a top-level "Favorites" folder in bookmarks).

    • via the main menu when on a site (extend existing functionality).
    • via the widget (new functionality).

  3. Users can remove Favorites.

    • via a top-level "Favorites" folder in bookmarks (extend existing functionality).
    • via the widget (new functionality).

  4. Users can edit Favorites.

    • via a top-level "Favorites" folder in bookmarks (extend existing functionality).
    • via the widget (new functionality).

  5. Users can move Bookmarks in to Favorites.

    • via any bookmarks folder in bookmarks (extend existing functionality).

  6. Users can move Favorites in to Bookmarks.

    • via a top-level "Favorites" folder in bookmarks (extend existing functionality).

  7. The Favorites folder need to be localizable, as in the UK it will be spelt Favourites.

Try to re-use at much of the bookmarks functionality as possible for add, edit, remove Favorites.

cc @anthonypkeane @deeppandya

DarrenSem commented 6 months ago

[ reminder to self and others: this is duplicate of a now-closed issue -- #17217 ]

anthonypkeane commented 2 months ago

More info here: https://bravesoftware.slack.com/archives/C20HMJ62H/p1720819090470769?thread_ts=1720817152.902359&cid=C20HMJ62H

t0ma5 commented 2 months ago

I was looking for information about this basic standard feature, I have found feature requests from dating back to 2021 and still nothing, why? So strange! Looking forward for this to finally become reality in the next update. Thanks in advance :)