[Android] Brave Player for youtube - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.63k stars 2.3k forks source link

[Android] Brave Player for youtube #33887

Open deeppandya opened 11 months ago

deeppandya commented 11 months ago

We need to have the selectors to decide when to show the UI changes for the users. For more context : https://bravesoftware.slack.com/archives/C062581P71R/p1698175658960699

UI tasks

[ ] when the user visits youtube for the first time, we need to show the dialog (https://www.figma.com/file/4tLGBHZNP8dL0vvphXpsd3/Brave-Player-for-YouTube?type=design&node-id=35-11529&mode=design&t=w3yTRfrBoHAyQxg2-0)
[ ] whenever user visits youtube , we need to show Brave Player button in the url bar.
[ ] when the user taps on Brave Player , for the first time, we need to show the popover https://www.figma.com/file/4tLGBHZNP8dL0vvphXpsd3/Brave-Player-for-YouTube?type=design&node-id=107-12255&mode=design&t=97gHVyfNV74hR1rl-0

Peacock365 commented 11 months ago

So, are you planning to do an overlay? Like for example, when you watch a video via MPV, only in the browser? Or playing YouTube videos via Invidious? Will this 1:1 replace the current video stream on YouTube? Because if you can't fight the anti-adblock of YouTube conventionally, it might also be a good idea to just fast-forward through the ads like this extension does it: https://chrome.google.com/webstore/detail/fadblock-friendly-adblock/mdadjjfmjhfcibgfhfjbaiiljpllkbfc But yes, the player is a good idea as well.