search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.85k stars 2.33k forks source link

Session windows #34

Open bbondy opened 6 years ago

bbondy commented 6 years ago

Repurpose multi user support for session windows.

bbondy commented 6 years ago

Moved to backlog.

bsclifton commented 6 years ago

If we integrate session tabs with regular tabs, we should check out https://github.com/brave/browser-laptop/issues/7783 for feedback about how to make the experience better than browser-laptop

Issue https://github.com/brave/browser-laptop/issues/5643 from browser-laptop suggests giving a common color to session tabs (browser-laptop already shows the session number)

Issue https://github.com/brave/browser-laptop/issues/10539 suggests giving a session tab (or window) a name

bsclifton commented 6 years ago

Per https://github.com/brave/browser-laptop/issues/13094, there should be specific shortcuts for opening session tabs / windows

bsclifton commented 6 years ago

Per https://github.com/brave/browser-laptop/issues/7417, users should be able to choose a session (numbered or named? depends on what we decide) when bookmarking a site

bsclifton commented 6 years ago

Per https://github.com/brave/browser-laptop/issues/788, users should be able to choose a session (numbered or named?) when opening a link via context menu (ex: open link in new session tab X)

kelna commented 6 years ago

I just moved to this new Chrome-based production version from the Muon-based one and I sadly noticed that session tabs are gone. This was one of the best productivity features of Brave and the one because of which I sticked to Brave in spite of the many bugs and glitches. The Chrome-based is very shiny and promising but session tabs would be an important feature to implement IMO. Thanks for the great work!

webserviceXXL commented 6 years ago

I agree the sessions tabs feature is a truly USP of Brave.

But have in mind that session tabs and session windows are a totally different thing. I saw that the Issues https://github.com/brave/browser-laptop/issues/10539 was closed because of this Issue and I just want to be sure, that all got the difference. Please don't mix them.

Sessions windows are already possible with many other browsers like Chrome. You have different users for different windows. In this case all the settings (bookmarks, add ons, ...) are separated. So if you want to use a plugin with both sessions you have to install that twice.

With sessions tabs, just the session information are separated. Bookmarks, add ons and so on will be the same. So it's much easier to handle different accounts in the same environment. A good example is Firefox. Search for the "firefox multi account container". They work like a charm. They are colored, the can have custom names, and also the UI settings up the container ist quite nice.

Really looking forward for a feature like this in Brave.

@bsclifton Is there something I can support you with?

BTW: @kelna The sessions tabs are working with the chromium version. I use 0.25.2 on a Mac and the sessions tabs are working fine.

kelna commented 5 years ago

BTW: @kelna The sessions tabs are working with the chromium version. I use 0.25.2 on a Mac and the sessions tabs are working fine.

I use 0.56 on Windows and there is no session tab feature.

tildelowengrimm commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

NumDeP commented 5 years ago

Mate you're a buzzkill. I'd been waiting for it to appear almost identically the way it was in Muon for quite some time now and I was just about to suggest Brave implement something similar to the coloured square on the top left of ://apps permanently integrated in the far left of the tab bar, not within the tab as it shows here -

screenshot_20181204_182712

There was an in-depth discussion about this in another issue (can't find it) about just simply enhancing this feature from a UI standpoint to make it more easy for users because it took little to get accustomed to but once you utilised it long enough, it became handy and a very useful feature.

Watching a Cat VT in S1 Tab, a Dog VT in S2, a Rabbit VT in S3 tab and a VT relating to all the other three Sessions in a Tor-Tab without any kind of tracking and other benefits a separate session brings, all within one window was/is a killer USP. Please don't kill it.

We don't want much of Chromium/Chrome's UI/UX.

knaku commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

I'm sad to hear that. It's actually one of, or maybe even the main reason I use brave as a main browser for everyday media consumption, and to keep social media a bit more separated. At least that was the intention. I guess I kind of fall outside the main portion of the userbase, still though, it was good while it lasted.

Edit: I keep them pinned, so that kind of solves the confusion part.

patrickbeam commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

That's really sad to hear. My primary use case for Brave was the session tabs. To be honest its the first decent innovative feature I had seen in any browser in the last couple of years. Hopefully this is something that will be re-considered over time? Maybe session windows will solve the problem, looking forward to seeing that feature in action.

michaelhayes-dev commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

I agree with these other comments that I am sad to see session tabs go. They were one of the primary reasons I swapped to Brave in the first place. I very much appreciated the ability to sandbox sites (for example, have personal email in one session and social media in another) and yet have both tabs side-by-side to navigate between them quickly and seamlessly. Disappointing news, but hopefully session windows will work in a similar manner.

eljuno commented 5 years ago

+1 from Community and +1 from me https://community.brave.com/t/please-reinstate-some-of-the-features-that-were-used-in-brave-muon/39463?u=eljuno

markemus commented 5 years ago

I'm also really missing the session tabs, and I'm going to have to figure out what to do instead starting tomorrow. This change has really messed with my whole workflow. Session windows won't cut it- session tabs were an amazing feature and I'm really disappointed that you guys are getting rid of your best feature. This is a really bad idea.

domyn commented 5 years ago

Also +1 from me, Session tabs is the only thing that is keeping me from upgrading from Muon-based version, I even downgraded on my work PC because I left Chrome mainly because of the session tabs.

webserviceXXL commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

@tomlowenthal Could it be that we still talkin' about different things? This is already implemented* and isn't using the pur profile feature of chrome. You already can have different sessions tabs in the same window. But "just" not as smooth as for example in Firefox.

sessiontabs

* At least in Brave Desktop for Mac:

Brave: 0.25.2 
V8: 6.9.427.23 
Muon: 8.1.8 
OS Release: 18.2.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Brave Sync: v1.4.2 
libchromiumcontent: 69.0.3497.100
eljuno commented 5 years ago

@webserviceXXL,

Session tabs is available on the Brave (muon; 0.25.x). But not available on the new Brave Browser (brave-core; 0.57.x and higher).

The repo for old Brave (muon) is "browser-laptop". While this repo is for the new brave-core. 🙂

webserviceXXL commented 5 years ago

@eljuno Good to know, thanks!

tz commented 5 years ago

This was one of my favorite brave features. I hope it will be reintroduced. If the old interface was confusing I'm sure a new one can be designed.

eljuno commented 5 years ago

+1s from Community https://community.brave.com/t/please-bring-back-session-tabs/40613?u=eljuno

I will really miss these for multiple logins on the same sites.

https://community.brave.com/t/features-from-old-brave/40574?u=eljuno

jimwillingham commented 5 years ago

We have not implemented session windows or tabs (but we still have the Chromium "profiles" feature). We plan to implement session windows. We don't plan to implement session tabs or any other behavior where tabs in the same window have different contexts. There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

Multi-session tabs is one of the main reasons I started using Brave. It was a brilliant innovation, and one of the best parts of it. If I'd known that your main focus in life is making it be as much as possible like every other browser in the known universe that caters to the least common denominator mouthbreather who can't figure out which freakin' tab he's using, I wouldn't have bothered, and you could save yourself a lot of time and effort by just rebranding Microsoft Edge with a Brave logo and call it a day.

siric commented 5 years ago

There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

You could add a setting to enable/disable "session tabs", and set it's default to off. Session tabs is an incredibly useful feature and fits well with Brave's stance on privacy.

btlechowski commented 5 years ago

+1 from community https://community.brave.com/t/please-restore-session-tab-functionality-to-the-new-brave/41642

markemus commented 5 years ago

There's simply too much risk of confusion or error with mixed tab contexts — even for experienced users.

You could add a setting to enable/disable "session tabs", and set it's default to off. Session tabs is an incredibly useful feature and fits well with Brave's stance on privacy.

Who says it has to be a security feature anyway? It's just a feature that helps you keep logins separate. Maybe you guys thought of it that way originally, but it turns out you accidentally invented something useful instead. And clearly there is a huge demand for it.

audip commented 5 years ago

Session tabs was one of the best features of brave browser. I urge the development team to bring it back for the community which wants and loves it.

SethACooper commented 5 years ago

Please bring back session tabs. It is one of the most, if not the most valuable features for many users like me.

bridiver commented 5 years ago

We want to bring session tabs back, but it's much more complicated to implement on top of chromium. The initial implementation will probably be session windows (due to some internal chromium details) and we hope to eventually bring back session tabs. There were a lot of upsides to the switch to chromium, but unfortunately this was one of the few downsides.

SethACooper commented 5 years ago

It's great to hear that maybe it will be back. Thanks!

On Sun, Jan 13, 2019, 8:30 AM Brian Johnson <notifications@github.com wrote:

We want to bring session tabs back, but it's much more complicated to implement on top of chromium. The initial implementation will probably be session windows (due to some internal chromium details) and we hope to eventually bring back session tabs. There were a lot of upsides to the switch to chromium, but unfortunately this was one of the few downsides.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/34#issuecomment-453829919, or mute the thread https://github.com/notifications/unsubscribe-auth/AGsLGZFj5wGiUayk80k3k4hgEU72zHh8ks5vCzTvgaJpZM4Q24rk .

ghost commented 5 years ago

I just reinstalled my computer and discovered Session Tabs are gone. This was one of the primary reasons I use Brave, maybe the best feature to deal with Googles mess and multiple accounts.

Please prioritize this high on the list. Thank you.

wkuckro commented 5 years ago

@bridiver good to hear the tradeoff, but this was a stand-out feature for Brave which separated it from the browser crowd. Speed is important, but not at the lack of features people seem to really enjoy. The sooner this can come back, the sooner users will evangelize the use of this browser.

iamonkara commented 5 years ago

Please bring back Session-Tabs and I am ready to use Brave else I am happy with Firefox even though it is slower.

kervinpierre commented 5 years ago

I installed brave specifically for session tabs.

Now it's back to chrome.

Does any other browser have this feature?

webserviceXXL commented 5 years ago

@kervinpierre Mozilla is doing a very good job here with their official add-on Multi-Account Containers https://github.com/mozilla/multi-account-containers#readme

echosa commented 5 years ago

I would also like to see session tabs brought back. Firefox's containers are by far the main reason I use it as my default browser. I understand that this sort of thing is difficult to build on top of chromium and that, in the mean time, session windows are the compromise.

While certainly not ideal, I think I could live with this if session windows have the same abilities that Firefox's containers do in terms of assigning URLs to a session/container. For example: I have my email web client set to always open in my Personal container. I have my work accounts set to always open in my Work container. Etc. So, if I click on a link in Slack, Discord, or anywhere, when Firefox loads the page, it's automatically loaded in the right container. If Brave can implement that so that when I click on links to www.work-site.com they automatically open in my Work session windows and when I click on www.my-email.com they automatically open in my Personal session, I think that would be a good enough trade-off/compromise for me.

caspertone2003 commented 5 years ago

@bridiver

We want to bring session tabs back, but it's much more complicated to implement on top of chromium. The initial implementation will probably be session windows (due to some internal chromium details) and we hope to eventually bring back session tabs. There were a lot of upsides to the switch to chromium, but unfortunately this was one of the few downsides.

Can you add session tabs to the roadmap? Currently there is no reference to this feature https://github.com/brave/brave-browser/wiki/roadmap

DevopsDood commented 5 years ago

This was a very useful feature I miss

satchnut commented 5 years ago

All the protections and blocking in the world means little if the single greatest anti-tracking method remains outside the feature-set. Please bring this back! Firefox needs some competition again.

mikedoth commented 5 years ago

Going back to Firefox until this is added back in. I use this constantly for development and privacy.

bbondy commented 5 years ago

@mikedoth would the profile feature on the top right work for you ? You can use different profiles at the same time.

iamonkara commented 5 years ago

I have abandoned Brave for Firefox, even though it was fastest of all, for multiple reasons.

A) session windows and B) KeePassXC extension for password manager doesn't work C) this one is not Brave's fault but there is no extension in Chrome store to "activate last focussed tab" .

I think the biggest mistake Brave did was use Chromium as the base, even Edge is on the same bandwagon which creates a monopoly of Chromium.... bad for the future

On Fri, Apr 26, 2019, 8:26 PM Brian R. Bondy notifications@github.com wrote:

@mikedoth https://github.com/mikedoth would the profile feature on the top right work for you ? You can use different profiles at the same time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/34#issuecomment-487243460, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZDXBKSPO4CWNEWSA27RJDPSOTSZANCNFSM4EG3RLSA .

aow207 commented 5 years ago

I'll have to ditch Brave for Firefox until session tabs are back. I used the old version for as long as it was available until I was forced to update to the Chromium one.

caspertone2003 commented 5 years ago

I have abandoned Brave for Firefox, even though it was fastest of all, for multiple reasons. A) session windows and B) KeePassXC extension for password manager doesn't work C) this one is not Brave's fault but there is no extension in Chrome store to "activate last focussed tab" . I think the biggest mistake Brave did was use Chromium as the base, even Edge is on the same bandwagon which creates a monopoly of Chromium.... bad for the future …

Multi session containers! Great feature that should be considered by Brave team. Even the name "container" is a very good choice.

caspertone2003 commented 5 years ago

I'll have to ditch Brave for Firefox until session tabs are back. I used the old version for as long as it was available until I was forced to update to the Chromium one.

@aow207 Same here. But I resourced to use brave-portable https://github.com/portapps/brave-portable/releases/tag/0.25.302-44

xznhj8129 commented 5 years ago

Multi-session containers are one of the most important privacy features a browser can have today, Brave really needs to pick a page from Firefox here, and quick.

echeoquehaii commented 5 years ago

Multi-session containers are one of the most important privacy features a browser can have today, Brave really needs to pick a page from Firefox here, and quick.

Cannot agree more!

rosierazorex commented 5 years ago

Making some noise about this too! Really want this feature back. As far as I can tell there is no real ETA?

caspertone2003 commented 5 years ago

Please support https://github.com/brave/brave-browser/issues/4749

As per @Pedro7 good indication, Please don't post comments saying 'me too', subscribe to the bug only or thumbs up the initial comment. See bellow. I would close this thread but have no powers...

Segment0895 commented 5 years ago

Please don't post comments saying 'me too', subscribe to the bug only or thumbs up the initial comment.

Why? Because the developers can't afford the time to read all oneliners saying 'me too' and it will be far easier to just set up an ignore filter for the emails regarding bug reports.

Thank you in Advance

caspertone2003 commented 5 years ago

Last news:

4749 has been closed by @rebron

Statement is "We're not going to do a session tabs implementation do to UE/UX confusion."

So, forget session tabs in Brave ;-(

Only thing is to express disatisfaction in https://github.com/brave/brave-browser/issues/4749 using thumbs down.