brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.34k forks source link

Importing passwords from `Google Chrome` doesn't work on macOS and Linux #34046

Open stephendonner opened 1 year ago

stephendonner commented 1 year ago

Description

Importing passwords from Google Chrome doesn't work on macOS

Steps to Reproduce

  1. install the latest release version of Google Chrome (119.0.6045.105)
  2. launch it
  3. load a few websites which require logins
  4. log in to them
  5. save their passwords
  6. ensure they show up in chrome://password-manager/passwords
  7. shut down Google Chrome
  8. install Brave 1.62.18
  9. launch Brave
  10. invoke Import Bookmarks and Settings... from any entrypoint
  11. chose the Chrome Person 1 (or respective) profile
  12. click Import Profile(s)
  13. leave all the import-type options checked (Browsing history, Favorites/Bookmarks, and Saved passwords
  14. click Import
  15. click on brave://settings/autofill
  16. click on Password Manager

Actual result:

brave://settings/autofill loads but there are no imported saved passwords from Google Chrome

example example example example example example
Screen Shot 2023-11-01 at 12 10 55 PM Screen Shot 2023-11-01 at 12 11 02 PM Screen Shot 2023-11-01 at 12 11 08 PM Screen Shot 2023-11-01 at 12 11 16 PM Screen Shot 2023-11-01 at 12 12 02 PM Screen Shot 2023-11-01 at 12 12 31 PM

Expected result:

All of your Google Chrome-saved passwords should be successful

Reproduces how often:

100%

Sadly, this happens even in 1.48.x (and maybe earlier - this missed issue is on me)

Brave version (brave://version info)

Brave | 1.62.18 Chromium: 119.0.6045.105 (Official Build) nightly (x86_64)
-- | --
Revision | 73d9be8be823d9814339b22bde6589f10453b6b2
OS | macOS Version 11.7.10 (Build 20G1427)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @bsclifton @simonhong @sangwoo108 @rebron @brave/qa-team

LaurenWags commented 1 month ago

Reproduces on Linux as well

Brave | 1.71.113 Chromium: 130.0.6723.58 (Official Build) (64-bit)
-- | --
Revision | 3ee74228044546a84c661332ddb441a7a68108fa
OS | Linux

and

Brave | 1.70.126 Chromium: 129.0.6668.100 (Official Build) (64-bit)
-- | --
Revision | 35f34f21e597f5f30e9e206b0354cc137df1f2a3
OS | Linux