User must see a pop-up message that asks to choose a folder location when exporting bookmarks

hffvld commented 1 year ago

Description

A user must see a pop-up message that asks to choose a folder location when exporting bookmarks.

Steps to reproduce

Launch Brave
Three-dot menu > Bookmarks
Three-dot menu > Export bookmarks > Observe

Actual result

When exporting bookmarks, the user sees only the message saying Bookmarks exported successfully, but not offered to choose a location where to save the bookmarks.

https://github.com/brave/brave-browser/assets/128532965/2a3ce86b-d986-406c-bb51-38ccf98df4f4

Expected result

A user must see a pop-up message that asks to choose a folder location when exporting bookmarks.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? YES
Can you reproduce this issue with the current Play Store Beta version? YES
Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): Any
Android version: Any

Brave version

Brave build: 1.60.110
Chromium: 119.0.6045.105 (Official Build) (64-bit)
Revision: 0bb6e7a81aed340b5a9e8b752c1cf92768257c40

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

deeppandya commented 1 year ago

@hffvld can you verify this issue on latest nightly ?

hffvld commented 1 year ago

Hi @deeppandya

I checked with the latest Nightly build and I see a new pop-up message with Close and Open folder buttons and the message Bookmarks exported to /storage/emulated/0/Download/bookmarks.html. Then I can tap Open folder and choose the Files app to see/manage that file.

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B2.230922.010 release-keys]
Brave build: 1.62.21 
Chromium: 119.0.6045.105 (Official Build) canary (64-bit)

1	2

https://github.com/brave/brave-browser/assets/128532965/ff065bc7-dab2-462e-82fa-12347d9eed8e

brave / brave-browser