search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.77k stars 2.32k forks source link

Enabling all content filters results in extreme startup time on pc with limited power #34114

Open Kacper-Kondracki opened 11 months ago

Kacper-Kondracki commented 11 months ago

Description

Normally, brave startup is fast, but when enabling all available filters, on my machine (Ryzen 3 5300U (4cores/8threads))j startup time increase to around 5 seconds. I would really like to have filters enabled for every language, but the startup delay forces me to make compromise and reduce number of enabled filters

Steps to Reproduce

  1. Enable all available content filters in settings
  2. Restart Brave

Actual result:

Slow startup on pc with limited power

Expected result:

Quick startup, like when using only filters enabled by default

Reproduces how often:

Easily on weaker machines, Hard on powerful pc (startup time increase is not noticable)

Brave version (brave://version info)

Brave 1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit) Revision 0bb6e7a81aed340b5a9e8b752c1cf92768257c40

Version/Channel Information:

Marko-98 commented 11 months ago

@Kacper-Kondracki I don't think that can be fixed. It's completely normal for the browser to slow down after subscribing to a lot of filters. Because it has to load, well, if not millions of rules in a large number of filters.

I'm not sure why would you want to be subscribed to all filters anyway.

Kacper-Kondracki commented 11 months ago

I see this is still open https://github.com/brave/brave-browser/issues/27161 If I'm right, this should really improve startup time overall.

Even when comparing startup time without any filters and with only these filters + one regional image Startup delay difference can be feelable (less than second longer, although it is fairly acceptable)

Also adblock could be non-blocking, when Brave is just launched with new tab page.