brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.56k stars 2.28k forks source link

Brave News/Manage Subscriptions icon is displayed on mail.google.com #34227

Open LaurenWags opened 10 months ago

LaurenWags commented 10 months ago

Description

mail.google.com is showing the Brave News/Manage Subscriptions icon in the URL bar but there's no feed when I click on the icon. If there's no feed to subscribe to, the icon shouldn't be displayed.

Doesn't reproduce in 1.59.x, but does in 1.60.x, 1.61.x, 1.62.x

Steps to Reproduce

  1. Clean profile
  2. Close/relaunch to pull griffin
  3. Navigate to mail.google.com and login
  4. Open NTP and enable Brave News
  5. Go back to mail.google.com and refresh the page
  6. See Brave News/Manage Subscriptions icon in URL bar
  7. Click on it, empty feed displays (similar to issue reported with https://github.com/brave/brave-browser/issues/33365)
  8. Click elsewhere to dismiss the list
  9. Click on the icon again, no feed displayed in the list this time

Actual result:

Example Example Example
1 2 3

Expected result:

no icon since there are no feeds to subscribe to

Reproduces how often:

easily

Brave version (brave://version info)

1.60.114, 1.61.67

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Possibly caused by some of the Brave News work that landed in 1.60.x - https://github.com/brave/brave-browser/issues?q=is%3Aissue+milestone%3A%221.60.x+-+Release%22+label%3Afeature%2Fbrave-news+is%3Aclosed

MadhaviSeelam commented 10 months ago

Reproduced the issue in Win 11 as well.

Brave | 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)
-- | --
Revision | 99a34933fc6a44fdfe52dea41341927bbce3549a
OS | Windows 11 Version 22H2 (Build 22621.2428)
stephendonner commented 10 months ago

cc @fallaciousreasoning