brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.91k stars 2.34k forks source link

Disabling global HTTPS Everywhere setting does not disable HTTPSEverywhere #3424

Open jumde opened 5 years ago

jumde commented 5 years ago

Description

Global HTTPS Everywhere switch should disable HTTPS upgrades even if the per-site switch is enabled.

Steps to Reproduce

  1. Navigate to brave://setttings and disable HTTPS Everywhere
  2. Open twitter.com and check the stats on brave://newtab
  3. The count increases

Actual result:

Global switch does not disable HTTPSEverywhere

Expected result:

HTTPSEverywhere should be disabled

Reproduces how often:

Easily

Brave version (brave://version info)

0.63.0 Chromium: 73.0.3683.39 (Developer Build) (64-bit)

tildelowengrimm commented 5 years ago

Do the other global Shields settings work as intended?

Johann999 commented 3 years ago

Please correct this issue, This issue is now older than 2 years,

Man thanks.

bsclifton commented 3 years ago

+1 from @github-account1111 via https://github.com/brave/brave-browser/issues/3424

Description

image HTTP-only sites don't work even when Upgrade connections to HTTPS is disabled in settings. The Dashboard ignores the settings (still has the option enabled) and even disabling from the Dashboard doesn't stop the connection from getting upgraded.

Steps to Reproduce

  1. Disable Upgrade connections to HTTPS in brave://settings
  2. Go to an HTTP-only site (e.g. https://www.dslreports.com/speedtest?httpsok=0)

Actual result:

Site's not working.

Expected result:

Site's working

Johann999 commented 3 years ago

HTTPS Everywhere ist obsolete. https://www.golem.de/news/eff-https-everywhere-wird-nicht-mehr-gebraucht-2109-159883.html

Please remove it.

Johann999 commented 2 years ago

Please correct this issue, This issue is now older than 2 years,

Many thanks.

Johann999 commented 2 years ago

Please correct this issue, This issue is now older than 3 years,

Many thanks.