search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.31k forks source link

[ads] Optimize epsilon greedy bandit arms initialization to only initialize if the feature is enabled #34414

Closed tmancey closed 11 months ago

btlechowski commented 10 months ago

Verified with

Brave 1.62.107 Chromium: 120.0.6099.115 (Official Build) beta (64-bit)
Revision 67a3b21572338a0660bb25a5855da0f1e9372a39
OS Linux

EpsilonGreedyBandit enabled and notification ads enabled

``` [11603:11603:1218/191601.555400:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for architecture segment [11603:11603:1218/191601.556209:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for arts & entertainment segment [11603:11603:1218/191601.556293:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for automotive segment [11603:11603:1218/191601.556343:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for business segment [11603:11603:1218/191601.556420:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for careers segment [11603:11603:1218/191601.556468:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for cell phones segment [11603:11603:1218/191601.556542:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for crypto segment [11603:11603:1218/191601.556592:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for education segment [11603:11603:1218/191601.556664:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for family & parenting segment [11603:11603:1218/191601.556713:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for fashion segment [11603:11603:1218/191601.557162:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for folklore segment [11603:11603:1218/191601.557320:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for food & drink segment [11603:11603:1218/191601.557406:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for gaming segment [11603:11603:1218/191601.557457:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for health & fitness segment [11603:11603:1218/191601.557533:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for history segment [11603:11603:1218/191601.557583:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for hobbies & interests segment [11603:11603:1218/191601.557660:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for home segment [11603:11603:1218/191601.557710:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for law segment [11603:11603:1218/191601.557786:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for military segment [11603:11603:1218/191601.557835:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for personal finance segment [11603:11603:1218/191601.557929:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for pets segment [11603:11603:1218/191601.557978:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for real estate segment [11603:11603:1218/191601.558054:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for science segment [11603:11603:1218/191601.558104:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for sports segment [11603:11603:1218/191601.558180:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for technology & computing segment [11603:11603:1218/191601.558230:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for travel segment [11603:11603:1218/191601.558306:VERBOSE2:epsilon_greedy_bandit_processor.cc(56)] Epsilon greedy bandit arm was added for weather segment [11603:11603:1218/191601.558539:VERBOSE1:epsilon_greedy_bandit_processor.cc(175)] Successfully initialized epsilon greedy bandit arms ```

EpsilonGreedyBandit enabled and Brave News inline ads enabled

Verified EpsilonGreedyBandit is not initialized

EpsilonGreedyBandit disabled and notification ads enabled

Verified EpsilonGreedyBandit is not initialized