search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Vertical tabs bar inner border issue #34450

Open andrewberty opened 12 months ago

andrewberty commented 12 months ago

Description

Vertical tab bar has white inner border. Always rendered while collapsed, Flicker rendering depending on width while expanded

Steps to Reproduce

  1. Enable vertical tabs
  2. Disable show title bar
  3. Disable expand on mouse hover

Actual result:

https://github.com/brave/brave-browser/assets/95014217/d95023e7-4744-4ab6-a599-84daab56cc07

Brave version (brave://version info)

Brave | 1.60.118 Chromium: 119.0.6045.163 (Official Build) (64-bit) Revision | b0599b790dbdfe28428202afe2b54758a044ccfc OS | Windows 11 Version 23H2 (Build 22631.2715)

is-this-c commented 8 months ago

This glitchy white line definitely exists with vertical tab scroll bar enabled. This issue seems similar to #30764 and #35321.

It seems to have existed for a while at least in some form. @sangwoo108 Your contributions to vertical tabs are great. But would you be able to fix this issue? This line is jarring. I think that it should be removed completely. Further, if vertical tab scroll bar background color is changed to vertical tab side bar background color, I think that it would look more minimal and very pleasing like Edge's.

sangwoo108 commented 8 months ago

Thanks for pinging me. It's time for me to have a new Win11 machine 😄

sangwoo108 commented 7 months ago

Hello, everyone. I found that this isn't happening on Nightly. @zenparsing I'm not sure but did we fix this recently? I'm curious if we're going to uplift the fix

andrewberty commented 7 months ago

Hello @sangwoo108, I tried nightly just now and unfortunately it's the same to me

explorer_GyTmtXl4Qi

sangwoo108 commented 7 months ago

Thanks @endrew. Could you share your DPI? like 150% 175% from the display settings.

andrewberty commented 7 months ago

Wow, interesting. I think that's it. That border only appears at 125% 175% 225% but doesn't appear at 100% 150% 200%

sangwoo108 commented 7 months ago

Yeah odd number usually affects that Thanks for checking. I'll take a look soonish