search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.55k stars 2.28k forks source link

Can't package extension crx file with `--pack-extension` #34544

Closed simonhong closed 8 months ago

simonhong commented 9 months ago

It's upstream issue - https://bugs.chromium.org/p/chromium/issues/detail?id=1498558 This regression affects our several CI jobs such as NTP SI publish(https://bravesoftware.slack.com/archives/CG08GKTFS/p1701061771648879)

@linhkikuchi set older version brave to that CI job and it worked.

cc @bsclifton @rebron

simonhong commented 9 months ago

Fix is merged to upstream master - https://chromium-review.googlesource.com/c/chromium/src/+/5072730

bsclifton commented 8 months ago

Looks like this fix was targeting M120 - are we good to close @simonhong?

simonhong commented 8 months ago

Yes! confirmed that --pack-extension switch works well with stable.