Closed fallaciousreasoning closed 11 months ago
@LaurenWags @rebron going to label this one as release-notes/include
until we get a issue that includes the spec/Figma and a test plan for 1.62.x
as one currently doesn't exist. When we get one created, we can use that one as the main issue for verification/release notes.
The above requires 1.62.101
or higher for 1.62.x
verification 👍
thanks @kjozwiak - going to mark this one QA/Blocked
until we get a test plan for the feature overall as well (as you requested via https://bravesoftware.slack.com/archives/C7VLGSR55/p1702087288983779)
@kjozwiak @LaurenWags sorry about the delay with the test plan - I've updated the issue to include some test steps. Please let me know if you need any more detail.
PASSED
usingBrave | 1.62.112 Chromium: 120.0.6099.115 (Official Build) beta (x86_64)
-- | --
Revision | ae1e179b9884b2de2f4ba0bdea7da3beaad93ffa
OS | macOS Version 11.7.10 (Build 20G1427)
and
Brave | 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (x86_64)
-- | --
Revision | 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS | macOS Version 14.3 (Build 23D5033f)
es_ES
- PASSED
PASSED
Customize
dialog - PASSED
PASSED
PASSED
Customize
dialog - PASSED
PASSED
PASSED
PASSED
PASSED
PASSED
Verification PASSED
using
Brave | 1.62.112 Chromium: 120.0.6099.115 (Official Build) beta (64-bit)
-- | --
Revision | ae1e179b9884b2de2f4ba0bdea7da3beaad93ffa
OS | Windows 11 Version 22H2 (Build 22621.2861)
and
Brave | 1.62.123 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | 680382264ff6ae655b3bba25e80567452f38fbee
OS | Windows 11 Version 22H2 (Build 22621.2861)
PASSED
PASSED
Brave News Enabled via Turn on News
card (Light theme) - PASSED
Brave News Enabled via Customize
Dashboard (Dark Theme) - PASSED
FAILED
Open news articles in a New tab
as a default - PASSED
Open news articles in Current tab
- PASSED
Open news articles in Current tab - Scroll position
- FAILED
Current feed view - FAILED
Lazy Loading - PASSED
PASSED
PASSED
Sidebar UI - PASSED
My Feed - PASSED
Following - FAILED
Channel Feeds - PASSED
Publisher Feeds - PASSED
PASSED
PASSED
Verified with
Brave | 1.62.135 Chromium: 120.0.6099.199 (Official Build) beta (64-bit) |
---|---|
Revision | c66fd7306403245e6c370da9f287f69a5cf46a10 |
OS | Linux |
Test Plan
News
button should scroll down into the feedCustomize
button when viewing the feed should open theCustomize
dialogRefresh
button should refresh the current feedWhat the feed should contain
Lazy Loading
When scrolling down, more and more articles should be loaded. In individual publisher feeds, there are often only a few articles (10 - 20), so the easiest place to test this is the
For You
feed.If you navigate to an article after scrolling down the feed a long way, it should bring you back to the same place you were at.
Sidebar
The sidebar should contain all the publishers and channels you're following. The default selected view should be
My Feed
. The last selected feed should be remembered across page loads.My Feed
The default view. Should contain articles from Publishers/Channels you follow plus a few additional suggestions we think you might like.
Following
Similar to
My Feed
but without "Discover" articles (articles from sources/channels you aren't following). Shouldn't include topic cards.Channel Feeds
Similar to the default, but only articles from the channel should be picked (and there shouldn't be topic/channel cards).
Publisher Feeds
Should contain hero cards, article cards and advertisements. Only articles from the publisher should be included.