search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.95k stars 2.35k forks source link

Internal pages showing `chrome://`. They should always show `brave://` #34983

Open Miyayes opened 11 months ago

Miyayes commented 11 months ago

Description

Example screenshot below. Note how it says chrome://. It should say brave://.

IMG_0082

bsclifton commented 11 months ago

@syedali237 feel free to work on the issue - this is likely a complex one (getting into a regression w/ schema in Chromium). You're welcome to share findings or a pull request at any time. Thanks!

Miyayes commented 10 months ago

This is not just a Rewards issue; this is a larger issue on Android. @szilardszaloki May be able to help with this too.

Miyayes commented 6 months ago

image

cc: @deeppandya

Miyayes commented 6 months ago

@brave/android If anyone can help pick this up.

Miyayes commented 5 months ago

@deeppandya Try tests like:

  1. Connect custodial account from unsupported region for that custodian
  2. Use Charles Proxy, per Lauren (Geeta can help too)
LaurenWags commented 4 months ago

Sent @deeppandya some example rules to trigger errors from https://github.com/brave/brave-browser/issues/34983#issue-2050757708 and https://github.com/brave/brave-browser/issues/34983#issuecomment-2093984164. Hope those help!