search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Expose the first party list in iOS #35210

Closed cuba closed 5 months ago

cuba commented 8 months ago

Description

We don't use the first party list in iOS yet. We need to make this list available to iOS.

Test plan

Note: This is essentially adding a hidden filter list that is always enabled which can be found here: https://github.com/brave/adblock-lists/blob/master/brave-lists/brave-firstparty.txt.

So we can test some of the items in this list such as ||acala-bridge.com^

  1. Ensure shields are enabled
  2. Go to https://acala-bridge.com/
  3. Ensure this site is blocked
LaurenWags commented 4 months ago

@cuba could you provide a test plan for this for the various OSes? If this doesn't need to be tested on Desktop and Android we can also remove the OS/Desktop and OS/Android labels. Labeling as QA/Blocked until we have this info. Thanks!

bsclifton commented 4 months ago

@LaurenWags details added above 😄👍

LaurenWags commented 4 months ago

Thanks @cuba @bsclifton - removed QA/Blocked so this can get verified on iOS 👍🏻

hffvld commented 4 months ago

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66 (107)
BraveCore: 1.66.107 (125.0.6422.41)

STEPS:

  1. Follow the steps from https://github.com/brave/brave-browser/issues/35210#issue-2072900978
  2. Verify

ACTUAL RESULTS:

1 2
1 2

https://github.com/brave/brave-browser/assets/128532965/6c29873b-7078-4bea-ad83-a4940bfc8c2a