Some of the followed channels are auto unfollowed upon upgrade

MadhaviSeelam commented 10 months ago

Description

This issue perhaps is related to https://github.com/brave/brave-browser/issues/34950. Some of the followed channels in 1.61.x are auto unfollowed upon upgrade to 1.62.x.

Steps to Reproduce

Installed 1.61.114
Launch Brave
Click Customize >> Brave news
Unfollow Top Sources
Follow all of the channels (30 channels), including Celebrity News Education, Lifestyle & Weather
Upgrade to 1.62.135 (Brave-Beta)
launch Brave
click Customize >> Brave News
verified sidebar as well
Actual result:

Celebrity News migrated as Celebrities but was unfollowed Education was unfollowed Lifestyle was unfollowed Weather was unfollowed Brave news sidebar do not list above channels either

1.61.x example	example

1.62.x example	example

Expected result:

All of the followed channels prior to upgrade should be listed in the Brave news sidebar and Brave news dialog.

Reproduces how often:

Brave version (brave://version info)

Brave | 1.62.135 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
-- | --
Revision | c66fd7306403245e6c370da9f287f69a5cf46a10
OS | Windows 11 Version 22H2 (Build 22621.3007)

Version/Channel Information:

Can you reproduce this issue with the current release? N/A
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel?No

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @LorenzoMinto cc: @brave/qa-team @rebron

LorenzoMinto commented 10 months ago

@MadhaviSeelam what locale are you using? If it's en_US, then those channels are not served there (i.e. no en_US publishers fall in those channels). Not sure why they were unfollowed but it might be related @fallaciousreasoning.

Ideally we shouldn't even show those channels since they are empty in that locale, but that requires figuring out the localisation aspect first (we'll keep this part of the issue for after release).

MadhaviSeelam commented 10 months ago

@LorenzoMinto my default locale en_US

fallaciousreasoning commented 10 months ago

Interesting - I just subscribed to those four channels in Brave news (latest nightly) and restarted. They all disappeared.

I think this is probably a locale bug (maybe we shouldn't be showing those channels to the user).

Same behavior is present in 1.61.x (probably been around since we added the locales stuff). Good find @MadhaviSeelam!

LorenzoMinto commented 10 months ago

If it's something we can easily fix we shouldn't be showing channels that do not appear in the user's locale, as those channels will appear empty. That would also solve this issue. Wdyt @fallaciousreasoning?

fallaciousreasoning commented 10 months ago

It's not a super complicated fix (but not trivial either), but I'd prefer to let things settle for a couple of days before release, if we can?

brave / brave-browser