brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.89k stars 2.34k forks source link

add a way to view Brave News sources that were manually hidden and the ability to unhide them #35268

Open LaurenWags opened 10 months ago

LaurenWags commented 10 months ago

Description

Currently there's no way to "unhide" or show any sources that were hidden via the 3 dots menu. If there's a way to hide, it would probably be good to have a way to "unhide" as well as view what sources were hidden. The "hide" feature isn't available in v1.

Rewards has a similar feature (removing sites from the auto contribution list) as well as a way to view removed sites as well as re-allow them).

Steps to Reproduce

  1. Have a news feed with top sources followed
  2. Click on the 3 dots menu for a news card and hide content from that source

Actual result:

No way to see what sources were hidden or re-instate content from a hidden source

Expected result:

Some way to view hidden sources or allow the sources to be visible again. Maybe could put a "View hidden sources" link in the area below to allow this? The link would only have to be visible when sources have been hidden, if no sources hidden, no link should display.

Screenshot 2024-01-11 at 11 49 18 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.62.137 Chromium: 120.0.6099.217 (Official Build) beta (x86_64)
-- | --
Revision | 92c88bc64f4e5c37e60774394436493726ad7d63
OS | macOS Version 13.6.3 (Build 22G436)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc @brave/qa-team @fallaciousreasoning @LorenzoMinto

fallaciousreasoning commented 10 months ago

Good idea!

So Publishers can be in one of three states:

  1. Subscribed (will be shown in the feed)
  2. Unset (will be shown in channels the Publisher is part of)
  3. Hidden (will not show up in feeds, channels or discover cards)

Clicking subscribe/unsubscribe in the UI toggles the Publishers between Subscribed and Unset, and hiding a source sets it to hidden.

At the moment, if you subscribe and unsubscribe to the source in the UI it'll show up in channels again (though not intuitive at all).

This is actually exactly the same as we do in the Feed V1 (screenshot from 1.61) image

LorenzoMinto commented 10 months ago

We are planning a section of the settings to manage these kind of things 👍 It's in the goals for Q1