brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
18k stars 2.36k forks source link

Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75. #35382

Closed mkarolin closed 10 months ago

mkarolin commented 10 months ago

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/121.0.6167.57..121.0.6167.75?pretty=fuller&n=10000

QA tests:

Additional checks:

kjozwiak commented 10 months ago

Adding QA/Blocked as the above will be uplifted into 1.62.x via https://github.com/brave/brave-core/pull/21593. We'll run through the above once it lands in 1.62.x.

kjozwiak commented 10 months ago

The above requires 1.62.148 or higher for 1.62.x verification 👍

kjozwiak commented 10 months ago

Quick overview of the work remaining re: affected areas due to C121 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via https://github.com/brave/brave-browser/issues/34702#issue-2024835128:

Platforms that still need to check/verify the affected areas due to C119 changes as per https://github.com/brave/brave-browser/issues/34702#issue-2024835128:

GeetaSarvadnya commented 10 months ago

Verification PASSED on

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (64-bit)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | Windows 10 Version 22H2 (Build 19045.3930)

image

LaurenWags commented 10 months ago

Verified cases below, to be continued with https://github.com/brave/brave-browser/issues/35493#issuecomment-1906089398.

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 13.6.3 (Build 22G436)

Encountered https://github.com/brave/brave-browser/issues/35495 while testing (not specific to Chromium 121).

Verifying desktop affected areas from https://github.com/brave/brave-browser/issues/34702#issue-2024835128:

Tab strip looks correct (vertical and horizontal) - PASSED **_Horizontal Tabs_** - Confirm that the tab strip looks good in a `Card hover mode` - Confirm that the tab strip looks good in a `Card` mode` - Confirm that the tab strip looks good in a `Tooltip` mode _`Card hover mode`_ 1 _`Card with Preview hover mode`_ 2 _`Tooltip hover mode`_ 3 **_Vertical Tabs_** - Confirm that the tab strip looks good in a `Card hover mode` - Confirm that the tab strip looks good in a `Card` mode` - Confirm that the tab strip looks good in a `Tooltip` mode _`Card hover mode`_ 1 _`Card with Preview hover mode`_ 2 _`Tooltip hover mode`_ 3
Check that channel name is displayed correctly in brave://version (Nightly, Beta, Release) - PASSED - Confirmed that channel name looks correct in nightly, beta, and release builds via brave://version/ - Confirmed that channel name looks correct in nightly, beta, and release builds via brave://settings/help Example | Example ----------|--------- 1 | 2 3 | 4 5 | 6
Tor Use Bridges setting works - PASSED 1. Clean profile 1.62.x RC 2. Open brave://settings/privacy 3. Make sure `Select a built-in bridge` is selected and `obfs4` is populated in the dropdown 4. Click on `Apply changes` 5. Ensured that the following domains opened in a Tor window without issues: - brave.com - duckduckgo.com - https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/ - check.torproject.org (ensured that hard refreshing gets a new circuit/IP) Use bridges | Example | Example | Example | Example | Example ----------|-----------|-----------|-----------|---------|-------- 1 | 2 | 3 | 4 | 5 | 6 6. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL: - brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ - nytimes.com --> https://www.nytimesn7cgmftshazwhfgzm37qxb44r64ytbb2dj3x62d2lljsciiyd.onion/ Example | Example ----------|--------- 1 | 2 Example | Example ----------|--------- 5 | 6 7. Close the TOR window and disable `Use Bridges` settings and click on `Apply Changes` Example | Example ----------|--------- Screenshot 2024-01-22 at 1 34 15 PM | Screenshot 2024-01-22 at 1 34 29 PM 8. Repeat the steps 5 and 6 and ensure that the TOR network is connected successfully Example | Example | Example | Example | Example ----------|-----------|-----------|---------|-------- 1 | 2 | 3 | 4 | 5 Example | Example ----------|--------- 1 | 2 Example | Example ----------|--------- 3 | 4
HTTP -> HTTPS upgrade works - PASSED
Case 1 - PASSED - Confirmed that visiting http://https-everywhere.badssl.com automatically upgrades from `HTTP` --> `HTTPS` - Confirmed that visiting http://https-everywhere.badssl.com doesn't upgrade to `HTTPS` when shields are disabled - Confirmed that http://https-everywhere.badssl.com auto-upgraded to `HTTPS` once the shields is re-enabled - Confirmed that http://https-everywhere.badssl.com doesn't upgrade to `HTTPS` when `Connections upgrade to HTTPS` was disabled - Confirmed that http://https-everywhere.badssl.com auto-upgraded to `HTTPS` once `Connections upgrade to HTTPS` has been enabled Example | Example | Example | Example ----------|-----------|----------|---------- Screenshot 2024-01-22 at 2 11 57 PM | Screenshot 2024-01-22 at 2 12 18 PM | Screenshot 2024-01-22 at 2 12 43 PM | Screenshot 2024-01-22 at 2 13 11 PM
Case 2 - PASSED ### Default - `Upgrade connections to HTTPS`, `Standard` - `PASSED`
1. installed 1.62.x RC build 2. launched Brave 3. confirmed `Upgrade connections to HTTPS` is set to `Standard` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `default` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- Screenshot 2024-01-22 at 2 19 54 PM | Screenshot 2024-01-22 at 2 21 15 PM | Screenshot 2024-01-22 at 2 21 24 PM | Screenshot 2024-01-22 at 2 21 32 PM #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- Screenshot 2024-01-22 at 2 22 44 PM | Screenshot 2024-01-22 at 2 22 53 PM | Screenshot 2024-01-22 at 2 23 02 PM
### `Upgrade connections to HTTPS`, `Strict` - `PASSED`
1. installed 1.62.x RC build 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Strict` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 7. loaded `http://upgradable.arthuredelstein.net` 8. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Strict` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` ----------|-------------------------------|--------------------|--------------------------------- Screenshot 2024-01-22 at 2 30 22 PM | Screenshot 2024-01-22 at 2 30 43 PM | Screenshot 2024-01-22 at 2 30 59 PM | Screenshot 2024-01-22 at 2 31 19 PM #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- Screenshot 2024-01-22 at 2 32 40 PM | Screenshot 2024-01-22 at 2 32 52 PM | Screenshot 2024-01-22 at 2 33 00 PM
### `Upgrade connections to HTTPS`, `Disabled` - `PASSED`
1. installed 1.62.x RC build 2. launched Brave 3. changed `Upgrade connections to HTTPS` to `Disabled` in `brave://settings/shields` 4. loaded `http://insecure.arthuredelstein.net` 5. loaded `http://http.badssl.com` 6. loaded `http://upgradable.arthuredelstein.net` 7. opened a `New Private Window with Tor` and loaded each of the above `Upgrade connections, Disabled` | `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------------------|--------------------|--------------------------------- 1 | 2 | 3 | 4 #### Tor `insecure.arthuredelstein.net` | `http.badssl.com` | `upgradable.arthuredelstein.net` -------------------------------|-------------------|---------------------------------- 5 | 6 | 7
Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly - PASSED **Default settings/enabled** - Confirm that the `Rewards`, `Bookmarks`, `VPN` and `Wallet` settings are enabled by default via brave://settings/appearance - Confirmed that the `Rewards`, `Bookmarks`, `VPN` and `Wallet` buttons are shown correctly in the toolbar - Confirmed that click on each button works as expected Example | Example ----------|--------- Screenshot 2024-01-22 at 4 59 39 PM | Screenshot 2024-01-22 at 4 59 48 PM **When the settings are disabled** - Disable `Rewards`, `Bookmarks`, `VPN` and `Wallet` settings via brave://settings/appearance - Confirmed that the `Rewards`, `Bookmarks`, `VPN` and `Wallet` buttons are not visible in the toolbar Example | Example ----------|--------- Screenshot 2024-01-22 at 5 01 33 PM | Screenshot 2024-01-22 at 5 01 42 PM
Tor works with a proxy set - PASSED _`Tor works with Proxy`_ Case 1: 1. Launch Brave with `--args --enable-logging=stderr --proxy-server="socks5://localhost:9000"` 2. Visit `brave.com` ---> site doesn't load as expected due to the proxy directing traffic to localhost 3. Visit `https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/` ---> site loads since Tor doesn't use the proxy Example | Example ----------|--------- 1 | 2 Case 2: 1. Confirm Charles Proxy is set up and launched 2. Start Brave with Charles enabled 3. Go to `brave.com` in a normal window and confirm that the request is able to be seen in Charles 4. Open a Tor window 5. Navigate to `https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/` 6. Confirm the site loads as expected and is not shown in Charles Example | Example ----------|--------- Screenshot 2024-01-22 at 5 31 37 PM | Screenshot 2024-01-22 at 5 33 26 PM _`Tor works without Proxy`_ 1. Clean profile 1.62.x RC 2. Ensured that the following domains opened in a Tor window without issues: - brave.com - duckduckgo.com - https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/ - check.torproject.org (ensured that hard refreshing gets a new circuit/IP) Example | Example | Example | Example | Example ----------|-----------|-----------|-------|-------- Screenshot 2024-01-22 at 5 54 33 PM | Screenshot 2024-01-22 at 5 54 42 PM | Screenshot 2024-01-22 at 5 54 49 PM | Screenshot 2024-01-22 at 5 54 58 PM | Screenshot 2024-01-22 at 5 55 10 PM 3. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL: - brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/ - nytimes.com --> https://www.nytimesn7cgmftshazwhfgzm37qxb44r64ytbb2dj3x62d2lljsciiyd.onion/ Example | Example ----------|--------- Screenshot 2024-01-22 at 5 57 16 PM | Screenshot 2024-01-22 at 5 57 24 PM Example | Example ----------|--------- Screenshot 2024-01-22 at 5 57 31 PM | Screenshot 2024-01-22 at 5 57 38 PM
hffvld commented 10 months ago

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.007 release-keys
Brave build: 1.62.149
Chromium: 121.0.6167.75 (Official Build) (64-bit) 

1 2
1 2
kjozwiak commented 10 months ago

Labelling the above as release-notes/exclude & QA/No in favour of https://github.com/brave/brave-browser/issues/35493#issuecomment-1904923046. @LaurenWags see https://github.com/brave/brave-browser/issues/35493#issuecomment-1904925041. Can remove the in-progress label whenever you're ready 👍

hffvld commented 10 months ago

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
Brave build: 1.62.149
Chromium: 121.0.6167.75 (Official Build) (64-bit) 

1 2
1 2