Improve contrast when selecting multiple tabs - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.49k stars 2.26k forks source link

Improve contrast when selecting multiple tabs #35494

Open rebron opened 7 months ago

rebron commented 7 months ago

Description

When selecting multiple tabs, the contrast in dark mode isn't clear enough to understand the items that are selected.

Steps to Reproduce

Be in 1.63.x or higher and in dark mode.
Have multiple tabs open, 10 or so. Select a few either in sequence or randomly (e.g. tab 1, 3, 4, 9, 10)
Notice that the contrast could be better.

Actual result

Screenshot 2024-01-22 at 10 26 04 AM

Expected result/Design

Screenshot 2024-06-14 at 8 03 51 AM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.62.x and higher

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

aguscruiz commented 7 months ago

Added designs for this here: https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/Desktop-toolbar-and-menu?type=design&node-id=2575-5&mode=design

Head's up, the color theme there for dark mode doesn't seem to be fully aligned with what's on Figma, the active tab should be lighter