brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.17k stars 2.23k forks source link

Hide Rewards summary in self-custody case #35498

Closed Miyayes closed 6 months ago

Miyayes commented 6 months ago

Description

Hide the Rewards summary breakdown / line item list, given that none of the line items really apply in this case.

### Tasks
- [x] Rewards panel
- [x] brave://rewards page
- [x] Continue to show the payout status banner in Rewards panel

cc: @LaurenWags

kjozwiak commented 6 months ago

The above requires 1.63.138 or higher for 1.63.x verification 👍

GeetaSarvadnya commented 5 months ago

Verification PASSED on

Brave | 1.63.138 Chromium: 121.0.6167.85 (Official Build) beta (64-bit)
-- | --
Revision | 742a3bdf71b710125a1c1dd8e89981b9009a87bc
OS | Windows 10 Version 22H2 (Build 19045.3930)

Per https://github.com/brave/brave-browser/issues/35498#issue-2094615599, confirmed that the summary list is removed from the panel and brave://rewards in self-custody case:

Settings page BR panel Pubs page
image image image

Per https://github.com/brave/brave-browser/issues/35498#issue-2094615599, confirmed that the payout status banner continued to display on the panel:

pre-req: Have some ads viewed and cashed in with the server. Then,

Pending

Settings page BR panel NTP
image image (1) image (2)

Processing

Settings page BR panel NTP
image image (1) image (2)

Complete

Settings page BR panel NTP
image image (1) image (2)