Open simonhong opened 7 months ago
that's expected, because chromium_src
files are not validated by gn and there's no way currently to do that without forking gn or heavy patching gn/gni files..
because of that we need to always be careful about adding things into chromium_src
files.
After adding
#include "chrome/common/channel_info.h"
intochrome/elevation_service/elevator.cc
,npm run gn_check
gives complain like below.However, adding same header to
brave/chromium_src/chrome/elevation_service/elevator.cc
doesn't give above error.cc @goodov